From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinclair Yeh Subject: Re: [PATCH, RESEND 03/14] drm/vmwgfx: avoid gcc-7 parentheses warning Date: Mon, 17 Jul 2017 15:15:49 +0200 Message-ID: <20170717131548.GA15306@pc24.home> References: <20170714092540.1217397-1-arnd@arndb.de> <20170714092540.1217397-4-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: Thomas Hellstrom , Greg Kroah-Hartman , Linux Kernel Mailing List , DRI , IDE-ML , VMware Graphics , Tejun Heo , Brian Paul , Andrew Morton , Linus Torvalds , Guenter Roeck , Linux Media Mailing List List-Id: linux-ide@vger.kernel.org T24gRnJpLCBKdWwgMTQsIDIwMTcgYXQgMTA6Mjg6MjlQTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBPbiBGcmksIEp1bCAxNCwgMjAxNyBhdCA5OjIzIFBNLCBMaW51cyBUb3J2YWxkcwo+ IDx0b3J2YWxkc0BsaW51eC1mb3VuZGF0aW9uLm9yZz4gd3JvdGU6Cj4gPiBPbiBGcmksIEp1bCAx NCwgMjAxNyBhdCAxMjoyMSBQTSwgTGludXMgVG9ydmFsZHMKPiA+IDx0b3J2YWxkc0BsaW51eC1m b3VuZGF0aW9uLm9yZz4gd3JvdGU6Cj4gPj4KPiA+PiBOQUsuIFRoaXMgdGFrZXMgdW5pbnRlbnRp b25hbGx5IGluc2FuZSBjb2RlIGFuZCB0dXJucyBpdCBpbnRlbnRpb25hbGx5Cj4gPj4gaW5zYW5l LiBBbnkgbm9uLXplcm8gcmV0dXJuIGlzIGNvbnNpZGVyZWQgYW4gZXJyb3IuCj4gPj4KPiA+PiBU aGUgcmlnaHQgZml4IGlzIGFsbW9zdCBjZXJ0YWlubHkgdG8ganVzdCByZXR1cm4gLUVJTlZBTCB1 bmNvbmRpdGlvbmFsbHkuCgpDb3JyZWN0LiAgSSdsbCBmaXggdGhpcy4KCj4gPgo+ID4gQnR3LCB0 aGlzIGlzIHdoeSBJIGhhdGUgY29tcGlsZXIgd2FybmluZyBmaXggcGF0Y2ggc2VyaWVzLiBFdmVu IHdoZW4KPiA+IHRoZXkgZG9uJ3QgYWN0dWFsbHkgYnJlYWsgdGhlIGNvZGUgKGFuZCBzb21ldGlt ZXMgdGhleSBkbyB0aGF0IHRvbyksCj4gPiB0aGV5IGNhbiBhY3R1YWxseSBlbmQgdXAgbWFraW5n IHRoZSBjb2RlIHdvcnNlLgo+IAo+IEkgZ2VuZXJhbGx5IGFncmVlLCBhbmQgdGhpcyBpcyBhbHNv IHdoeSBJIGhlbGQgdXAgc2VuZGluZyBwYXRjaGVzIGZvciB0aGUKPiAtV2Zvcm1hdCB3YXJuaW5n cyB1bnRpbCB5b3UgYnJvdWdodCB0aG9zZSB1cC4gSSBhbHNvIGZyZXF1ZW50bHkgc2VuZAo+IHBh dGNoZXMgZm9yIHJlY2VudGx5IGludHJvZHVjZWQgd2FybmluZ3MsIHdoaWNoIHRlbmQgdG8gaGF2 ZSBhIGJldHRlcgo+IGNoYW5jZSBvZiBnZXR0aW5nIHJldmlld2VkIGJ5IHRoZSBwZXJzb24gdGhh dCBqdXN0IGludHJvZHVjZWQgdGhlIGNvZGUsCj4gdG8gY2F0Y2ggdGhpcyBraW5kIG9mIG1pc3Rh a2UgaW4gbXkgcGF0Y2hlcy4KPiAKPiBJIGFsc28gcmVndWxhcmx5IHJ1biBpbnRvIGNhc2VzIHdo ZXJlIEkgc2VuZCBhIGNvcnJlY3QgcGF0Y2ggYW5kIGZpbmQKPiB0aGF0IGFub3RoZXIgYnJva2Vu IHBhdGNoIGhhcyBiZWVuIGFwcGxpZWQgdGhlIGZvbGxvd2luZyBkYXkgOy0pCj4gCj4gPiBUaGUg KmludGVudCogb2YgdGhhdCBjb2RlIHdhcyB0byByZXR1cm4gemVybyBmb3IgdGhlIENBUF9TWVNf QURNSU4uCj4gPiBCdXQgdGhlIGNvZGUgaGFzIG5ldmVyIGRvbmUgdGhhdCBpbiBpdHMgbGlmZXRp bWUgYW5kIG5vYm9keSBldmVyCj4gPiBub3RpY2VkLCBzbyBjbGVhcmx5IHRoZSBjb2RlIHNob3Vs ZG4ndCBldmVuIGhhdmUgdHJpZWQuCj4gCj4gTWFrZXMgc2Vuc2UsIHllcy4gSW4gdGhpcyBjYXNl LCB0aGUgcmV2aWV3IHByb2Nlc3MgaGFzIGZhaWxlZCBhcwo+IHdlbGwsIGFzIG9uZSBvZiB0aGUg bWFpbnRhaW5lcnMgZXZlbiBnYXZlIGFuIEFjayBvbiB0aGUgd3JvbmcgcGF0Y2gsCj4gYW5kIHRo ZW4gdGhlIHBhdGNoIGdvdCBkcm9wcGVkIHdpdGhvdXQgYW55IGZlZWRiYWNrLgoKSSd2ZSBkb25l IHNvbWUgZGlnZ2luZyBhbmQgbm90aWNlZCB0aGF0IG15IC1maXhlcyBwdWxsIHJlcXVlc3QKZGlk bid0IGdldCBwaWNrZWQgdXAgbGFzdCBEZWNlbWJlci4gIEl0J3MgbW9zdCBsaWtlbHkgYmVjYXVz ZSBJCmluaXRpYWxseSBtYWRlIGFuIGFkZHJlc3MgdHlwbyBpbiB0aGUgb3JpZ2luYWwgcmVxdWVz dCwgYW5kIHRoZW4KZm9sbG93ZWQgaXQgdXAgd2l0aCBhIGRpcmVjdCBlbWFpbCB3aXRoIHRoZSBj b3JyZWN0IGFkZHJlc3MuCgpTaW5jbGFpcgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbdGQNQQ (ORCPT ); Mon, 17 Jul 2017 09:16:16 -0400 Received: from mail-sn1nam02on0076.outbound.protection.outlook.com ([104.47.36.76]:36256 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751281AbdGQNQM (ORCPT ); Mon, 17 Jul 2017 09:16:12 -0400 Authentication-Results: arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=vmware.com; Date: Mon, 17 Jul 2017 15:15:49 +0200 From: Sinclair Yeh To: Arnd Bergmann Cc: Linus Torvalds , Linux Kernel Mailing List , VMware Graphics , Thomas Hellstrom , David Airlie , Greg Kroah-Hartman , Tejun Heo , Guenter Roeck , IDE-ML , Linux Media Mailing List , Andrew Morton , DRI , Brian Paul Subject: Re: [PATCH, RESEND 03/14] drm/vmwgfx: avoid gcc-7 parentheses warning Message-ID: <20170717131548.GA15306@pc24.home> References: <20170714092540.1217397-1-arnd@arndb.de> <20170714092540.1217397-4-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) X-Originating-IP: [90.40.60.40] X-ClientProxiedBy: HE1PR0401CA0073.eurprd04.prod.outlook.com (10.168.27.41) To DM5PR05MB3290.namprd05.prod.outlook.com (10.174.191.29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 565c3db6-f981-445e-eb10-08d4cd15fd94 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR05MB3290; X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3290;3:qmDaoy1EfAuQby+1SiIMHjJMSe28RvQFaDn9Jmpdk3T4LgT4o8oGUL3oQ7ur11R8jM3t2x32EJ7iXx8BpT0cAJJA/aVhaimxRwtMGXSmK7hCxGt6Bux8QGF1th81jHqQu/pOGEl5Rrr524tBKiFemYeNDvCVxxtnRFkIam0+INbybwVSabDxBzDcz1SYLLQinWbrrvWb4FJEGntD2xtGuVZFbkn5OZZqq7o1ewondN9W1pbMFMZiRK5oSKwc2ITdNQOQPzJy72opgL8cEHAS3/BtlVeKT6M+4sLR9YZ3TA7nMUkwsg1kVDWF/C3ympjFQ07+PvZiZhHvN3YonyIIFizRMJstGFU8syWOwD56AHrM3JWcbk8m8VUnzTUxmAOghoB0+7H3d0bR/sQ4Askalq4TicuNJVQEJ0E1WoPoMcivtyOKJ4zpM0yhHQK9WwoygZ9s4Y8TVpOkGg+aCOsJsomYBJzi4hmNdtW/NmBG9iVXLlKXH8sOkwVP+f2pUtfchRnqOMC4L9AeP85Nl3tP9Er/tqorATKs6tmWsfzZGCTDifxH6AfkJEj4gdLbV7hr/VepdKPyYbCzGwqxcFn/7TFmGDz6yLLuHD/HMSEepR+n9kmDEYNCRGf7AeruZ0vOU2xcO5CYBkbNn/nNJ+yiAeRPVJEVELCZB/L11U13jEByu45OuVFUfIbtC881kWFgYsWbydwhWp9qXce3HPtP+RFdUozz+qHVWC936OTR/uM= X-MS-TrafficTypeDiagnostic: DM5PR05MB3290: X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3290;25:NIUZHVYaoccjO0W5Gw7dSC46rlTw+4brAR3VP2vFajfd2M/spNKARPG/9ZnJj13WG01zYf/QmN61yY1bTyrEySKlvZaubBfiK2aDvUb6cv9Dn5bqXxmytt0yD9rBfOpuUvP06xNh6iTQxifuRYDrmRH9RVuYfKg5BFTP/Vhw8rgIIcXqp5MkEmXr/CoxxZP3isohgzSIDl06BhhCYKI8ShI5T+H618m4zy3MmwgjCWirsysrMp+4IZANAJ/1Jg/rF296sXxJDBeI6Lp7ZIQWCzJ4gZ82zUC/YqyUhFXFNQyJ27KVIbyy7YwZJrKiNKdUIhCa/5fBPz4r7DM81OxnR+zhheDbdhAup1jZN10MwEn+nvkLC+zCjICXXh5FUL4zRRbAIEUPF78A6Re9wZvskmeADI1UvsfYlwOCm3CXT7jmv+cITu81ukTw7tZz25Bf6MslRV4/f8DG4fL2LzhH4mup/GB0iB2U41KzlDwt/GsBozhEQpIguRoD8uqFFOYpjpgVa0DgpBS5KS6pSsBJTljLFHPKw8DxEbhBRkqGvu5gp/N69Q63Ta4byONRcg9msX3NgVM1qv9Y5eq7dzQXbKvdGUF9tE4SiRAsMUsB2IcczVjP4F066Cz+Ph88PEAKvIll6gomnRzm28VlGmC+38wMbW0z/LDozurwCbrNLZYpg7kndB86LrgfSyuaL2SR4H4S5uW4ij4g1+s1eKjbFswKOwb2tGIY2GcUcRFsZLz6uYjWfDyjZ2B3Vzog2X0SjhCSKbkpZOm22OoIw3+hZb2iWd0vClH0ZpLu18do67V9JnqZEVXtd6jxyfsz4IMPAOzA6+1pfwPhQffxrdMDy1VrKhtuXJ4NMrySTAM25X5CAbS5ENeKpa7A6si+J8VUDFfUHExHlScbUojLwQotS94OcTH/Rr5eNE0d3dfDnrw= X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3290;31:hupExZCFqhkVC8dK7WcX/CaIvrQkKBj4DJdWd5VFupqhGT7J8UOwC2micng+ai2XRRyPxchdzyDO4iaGjNVUvIWxJ/UHRjZ/kW98dYxdBIMvi4lpn6lx33FOjjidIiif/rg5O6DRt8bkACEuUhmaWgUbE7uiJpHj96X44ET4teSRvdRcG4W5VSMa2MXwjUdsNfM58KKP3vEnJmgiQQRmJuvVb7lM10Pe/n68XPUAyyafDDF1nQfUVFj9/Rh1KloVwQ0BQqx3JatCmdHXT2nmczquxOrb/53IXpv+vuY0PX6TC6F6uYsxsUIywGBMNjIdgoZ8ER79TXaeCFkD5NsGbmmBzZACFmSKv+6TqLIdGZBehy0Fx4FhEjRGaKVKo8JioCD3XEC3WgnOXxq+XOU0wvmk0/5Hxd1dbb11f91Oy4mj6aZY5vfDKG9HF1W/26dTtYUL7kVZKa/yP2egyTEF3U+mCiM9Mn+t4uZH+V5DOSUV5YAD3Ouazvo4qtD1yrABEgQ+bvYE5K7NdkO5BHL0WG9G9q3HMah+7NBdHMD7I7WmV5TAx3jQAgSCbd+sZuWgfXz1L+KcdgE2R8VAx8U29DA2iW8q4Xnw04xYcY7e0G6DbwbBVEtB8iRhwGI5PLdf0cl3H37Bm+GLXVyHyTH6yEhtdPj0T8d/vbAVgEcg/MQ= X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3290;20:ZO/mEDzwWsRimnJMylLq5gfp7Wme38ycQ+eDT8fvJNTaR+k++EKgRNh8rd5+BYl2HTqNpa4XcCRSdwtNxSk4mvSZr0qlDdO81w1T+BZyZVWd0c+uTz2m17aEflUaRYpWR1SCkHEEkpLYFq4SIbBtKU1MVov/to/FNqw36THV8dBUWK4LFvg86RAwPwUNn/W/ZKYFPdLSuxA9RPrbtY6nZwIRzoha/ggl3+GRAHSbPWj29j9OMRkhrE3r+Kzp/FzZ1zhIj/8+qDk99ndkF+4/PwInKHzx3dKcchyhDeWJqauzwi3d8GJQQ3E9vNRB5UL8XqT/LyG8uHjMNJMIuwykpoe7AkADr9YCS26zsyc/CgQWxnH1ioI5So+3gQ2oUqD8AV1pVo5uLZPvPVc9rWpxFjjdneOCyHFi6DddNTQ4JvpAgn36aiZtY/F5tu/lY3WnbyLu3tIYF+O0nh8ORwbtSlh+xY43QEsdorz3qgf7TfKGpQc6yqr+98yEtz+KWAYj X-Exchange-Antispam-Report-Test: UriScan:(236129657087228)(247924648384137); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(2017060910075)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123564025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR05MB3290;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR05MB3290; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR05MB3290;4:GNGjGbYNOXJqkQHic7j7RePa9rnutO5cxotbCTJ+QQ?= =?us-ascii?Q?Tgmjl8sZtOUWsFcCeRoNqqrAhIZT7Fx25wW+9/tSt4tHWs5JewGD8IoX3FLo?= =?us-ascii?Q?iyW/igUwqz54QGY5lKJXL08/1HuMAY8JktxjiPVDBfnZ4DnP7/or8NRNS2Os?= =?us-ascii?Q?UOvfxA0y5W+ZsGlSMe72EWqTBuJjjpaHJhbugyWLXirBXoWka9bjDxGn6hny?= =?us-ascii?Q?N+rWJu2gOth4PZBHTK7wr1uDbtLRsSwrACEOEL5sQ/VWHaa8hBPm3AYoD61g?= =?us-ascii?Q?MA9S0DQblwH7CniJlPezrKy+1yOjteHX6MYKg6//LIcSSI5A4e0xJ86E7H+X?= =?us-ascii?Q?2GXXlo5f8KydPnX83ILYBu3+aCDMCyA6c+GF5R5lW1LBOxi78ZmwB8sB1bb/?= =?us-ascii?Q?YW4uLHCyLDdW2cw5fgyFwNK+olvSDn7EUt5Ama2FloctViBIkr/+Kdy8lw35?= =?us-ascii?Q?QM5V9OfqKSS4kQdkvLEORr7NAfKtJocz2slWuqGe4/agA/DaA1+lHh44v16B?= =?us-ascii?Q?QfYt8pFyRDOnoN3xdm/RUuchhs9lnDVz8vNXxaqq6490eRSr6uZDcgdhKzAE?= =?us-ascii?Q?lIh6uPGBwE2YwEb7mW3H4hczmnZMVfG/a+BJk0H02WE1b7mcAv69Io7KDI0b?= =?us-ascii?Q?EMKj2sumHMNfyWcljemh1hKe7uvw7IGjozQelhuFpfMMxx/fhm/3zR0X5358?= =?us-ascii?Q?3aeyhTsqCtF3+fFacpPx9fl/wxVUq/aehADmXiqLp1IBF5oB6CiFGuI0F/Ff?= =?us-ascii?Q?DDtf0L1Ns85mwSfIjeUgNJjyHDA6jatAPi+JPOGJ/DNnpbC8rXw2Sy1pAR3y?= =?us-ascii?Q?zEyjPva8JNUrEq11xqDsGA5ta2yr0LXONLxdA244fMHBkj5HwUlyk7pu4IGT?= =?us-ascii?Q?7UKAvmWFkSmOTdkPgQ6vSGQmMT8gi3yEcmdymWysjNU4r85qp+FOhGRo5T9u?= =?us-ascii?Q?Q7Ag5ANTdp5hEksURytyq+SANXEmJcnnPCOUDhJXZ3sjZobdJeQPNCS3e0uz?= =?us-ascii?Q?IZgB8KctL9PsluJnMhKn2pk4wSNQM1rRNfZcrPDc32oxgLWUXNUJ6edNuOaV?= =?us-ascii?Q?Nc/HKKuc39cSKcO9pDI+8E2XibuqvftyD/Jm+2KV85B3EXWfLd6Bk4YapMtP?= =?us-ascii?Q?He4geao3kf+IMSErpyM12P90fG7v16tby0X8E4K64a0JdGvAw3OGCVCx7vjC?= =?us-ascii?Q?Er9eJQfXykuipZ+hInnUjLZ8KgbrJkyLuyxxDT+631msfgYIgitOJE81Mxm1?= =?us-ascii?Q?gb1XgnkDoZjGrUlpQ=3D?= X-Forefront-PRVS: 0371762FE7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(7370300001)(6009001)(39410400002)(39450400003)(39850400002)(39400400002)(39840400002)(377454003)(24454002)(1076002)(6116002)(53546010)(6666003)(5660300001)(2950100002)(9686003)(55016002)(54906002)(4326008)(3846002)(83506001)(93886004)(50466002)(23726003)(6506006)(305945005)(53936002)(7736002)(4001350100001)(6916009)(7350300001)(54356999)(47776003)(38730400002)(76176999)(189998001)(66066001)(33656002)(36756003)(478600001)(2906002)(81166006)(8676002)(6246003)(107886003)(50986999)(25786009)(42186005)(110136004)(229853002)(86362001)(7416002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR05MB3290;H:pc24.home;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR05MB3290;23:7lWYzdVGpm4U41ksMEUWYKk2PR5/eWlsF/ylsjWOB?= =?us-ascii?Q?iE9V219SZlLLVGSrNSdEB5oD1jBGCMvVduXvgJgdwY2UJHeuX83ybP8hMvcc?= =?us-ascii?Q?lh0fiURTKbrmhtybpsQT+D9AvLc2TkY/INZMbug3Q8rraqxu10hlFWT1uZsS?= =?us-ascii?Q?QdQApON85iXsZpG8Ncu5EnSc1tL6U3kmoUHPeleyAqyR6dhccWz95maMsg5t?= =?us-ascii?Q?9MkzNlFvsUS3HcCZ6Gq7aYXZgGRTF8got6X9Ik6U1w52v2UuSod7dmnaJLZ8?= =?us-ascii?Q?yC69iu2oWuoQh4+N7FzLoAijiSBLN37SJjgvsHa42gZ3WRHQ+Fr+qM5EFzDY?= =?us-ascii?Q?qYVYYhH63mtr0GVQTYQd9iVM6kBsLYq0IwJlQ+LnzZz8aTjbeR4JJ2imJCuG?= =?us-ascii?Q?d+cpiC8ltONzGPF+L67XRzBosplclPrGbj6a6v2YIl27bwmH4aoE2tQW81Iy?= =?us-ascii?Q?wTvyirx7bAEe+K4pICN6CLVMlhGrcjuewJKvbXXqgBbedeF06P8tIUgt7cYB?= =?us-ascii?Q?3g+zWFQ2mvqsE4uR0O2RLJD2w968tBDEtxDhkp3ykyypXh5Fry9gAdMXNRiE?= =?us-ascii?Q?4joH/lY8VNNNR1wlYJqNw8pucIrzzojGBIWhRXTaOYxbHGv7OPGpk4v4y7FM?= =?us-ascii?Q?bCwn+WMDH7CV4PUjv48qvB6dj2EF5dsL9SBOrd2SUWA75/SN8q+TMM9RYpSm?= =?us-ascii?Q?79HjSJ095hdrvAwdzn/qxFQC3MQhVIYQQ06eNui+moDHRuVy55J63eEkzjdo?= =?us-ascii?Q?tRcGAZjAr8AJkgUnh99haE6s1NxBqhbNat7qUt+FVAnfBaccBfDaY8bh9D5y?= =?us-ascii?Q?DCtMiext1ygRxRy38IcB50UTuiYFKGklZCjRqGjDCLBF0Du+13SGUAIZ8oEn?= =?us-ascii?Q?Ki3qWuiSQTNa4gIdV4HmbB8FDyVZjjv6PTH+QEGQw28k0w5DVJ+f9EhA7pQx?= =?us-ascii?Q?O+7FncBuQIrgDB/eoIoZf54/SQOtgRGLa4yTkvVYVjCMufT5VUYv4f9nsh8H?= =?us-ascii?Q?TmQrnhQO/BVb7HSV12KOQT5Yo5llPBmSkYeW4YZGTRjfBjAksbP5HZHZYwFK?= =?us-ascii?Q?Lh0lqyV+Ru6Tbd6OoJLFP2/bzN799yjSz/55KWMbgjGY6D51qvwe2J5ouohc?= =?us-ascii?Q?tny2MNuVY91kl76GvipqhTN09EVIbk9Ac1HjmfAharNUoaZFE1UGvlMrcxHv?= =?us-ascii?Q?3xTDwApey3hPF2FOTWmYbfDxl6CHxOd2oIZX3ixFFG461n7ZGU2a4lVycJJY?= =?us-ascii?Q?4BfFqypiaWvNweyC2X+TNimPRlpyh9FresANUWYJo2P6m2nyJjiVDVljvmUN?= =?us-ascii?Q?D2cTB8Ti7ig58h4zX6QIHzwVCi1akZg78kTBD+YpZsu?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR05MB3290;6:+79/7/Hv6EaPNAr7fJFZewobOtfPtv6Q+UoQ2g5DNk?= =?us-ascii?Q?Rzc+xXuUxvteUkdXWz6AtP0Q37Jns90IGHBt69tv6U1JwZRN1bT+NMOj23VM?= =?us-ascii?Q?dP6cFaOyuhwuMHJjm9YA4kJsLBYtTgmUAWnljnARI4k3MJKBHooxK5j9Sp+d?= =?us-ascii?Q?0hTT+6R2INuHoRPvjuvDi5VC1BfFx5mZOYffvU57uJszjjesP++Bmb6NBk+s?= =?us-ascii?Q?ckB4djXlfipGFcjg1Tq0F8zWjEzaJiCupYHlMuv1LtEKlHx1h/Xob8rdlTh6?= =?us-ascii?Q?iPLidrsFtdvk7Hxrqo+3uDD1Jd8c5WbWGpRorYkfVqBBAgC29ivWZVq8Fbyo?= =?us-ascii?Q?Q84RTykyGakbGQ9Qh93rjDcKAohPt1Y5iBSZs0nQeSMZE6TwShqfZyOr3IIz?= =?us-ascii?Q?rR965j5xE9W0zb5a1tYQ/d2lABIUJKIHFnZE17h9TB0ZRqOn4gmY+3UZG7gz?= =?us-ascii?Q?b1fe0kNS7HT0bcCej/yfq/pxo1KzMlCAPQYwwmrtIlw4FoZXrbI7s0RitKcO?= =?us-ascii?Q?WGW6MQyY16rnqDCssXHgeib86sxo4uDRCNVVChieE8+oKepXXI9Cdu3ZkHZ3?= =?us-ascii?Q?zOwjItWsrctmP6UTvTD2pZ3gaUMzhBsmej5azyW8QHOFKswSCKLd8lZDOFgg?= =?us-ascii?Q?d4DtLCjK/aGUhIDpcVgoWpxk+eojmP0R5+CBRkTwxzz5AMCsiYNTHTWSKnW/?= =?us-ascii?Q?T80aLpYVgmVIpNAkWbsP+CuyCrby5sdJDho2F8t7r94j2GhRz/2nVnpHngE1?= =?us-ascii?Q?z3Z+DJWJLpDFYgijy0KxGJquTraw5OKHu+/8BUw7fuIXQm5obErjGV0Nzvg1?= =?us-ascii?Q?A6eabVV33osXGfzBMMvWgoBVNinNhkGmpg+R4Ze4Ygmzv+UNn2Y0hiB8XdOs?= =?us-ascii?Q?X0O2a68XCKHtAURW638clQ4VTa8ZkOwWkcT2eL+kqRnP+M4+nQ28tjE3uxJb?= =?us-ascii?Q?MS3oSdauikuEeXkesbhzD+HRu45LoDTMuE3cfgKl9mcf/dfLYTMSc38/sszX?= =?us-ascii?Q?c=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3290;5:Cxl3w3D4FZ7vDzq9Ojx29tH/OzosDWYL2i9o0ttf+qy5dfeuHgTTPHnln0sn/GEfAaK47NQm3c95x6YTtzth9mhCnb/GnA3s315XucftMdDfviMfvYzok6wiRUvJLCTE5DXArXLM0Ey7dBeCEvAGrX2qf9V/PXPHyDrrIe8EEepeAbfGrFBo3e473TvVhSoXM8tDlwU9vuiLM3tDlyHP26f9nMB1mrC3hdcwBUnMoxkzibNzrn+CEVgNvvW6C9nKHdbw8C1qWTGrgR7heD+OMeULPQS75PttY/SMrpBGnPu/C/qKRLGigdzGIIsq0lGp6Jb9OC9K8nL3bC3FcemjWU70RB0hj1XSjONT0SnHwhG/ze374tcW4Me/G/2VTOlkDbmSsIyjp2JSwvz1m+zv/TeF95F4ptquWCxvl41rL/QqYSDjanjpyHnVUpdNrnZE6anxznAo60d9T1nWAir8wVRPEYOhnhkYWVf8EDQo74Kb+AcBHQZhcAJsx66fuVhX;24:LvzMMu+o/cCCyx9cdHxZhl+M3zGSM70tuHkgOUuveY4qje7PEYPOKumAVosMTmGooWx73PyPT9ZgtZEfgQRjGm0qdFzDrQHdNlS9UBuYAec= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3290;7:Y71kpZXmxb66w3Ye4XDhM7/ZXtDiOeU666YQuY5qAZtGkubmuG+eEIFJHwbreltEmbcK4+cQMf3tqwoblqp549OOliFcDtHqy7GZqJiHH6zop6FXz8BOC+fEfpefxqOjnbaE/ij0oZxJzoIZJdbdMiLr1reWGt99UJ3Lf5XPmltYa4ZvMdhLpfPCnfkTYFU/b64NdBY8jxtLk79+yGbjyfDtoaibi395AuOa2pdPdzL8MrUmFGV3gsKKsFwHDuSLKalmGIz9HYzPGbVBn17MzFnU+7eDZeAn1sgfpRj03lRhCeNFMCtbxKtSvhmSpuFM4Rj83444GyPrVZ1p3dvgFFgjBUr12lK9O9bBtpU67hKvLz7uXwSw6bjJySIu4FHviymsmCTQupgF2TgkPYAejhH/dYlvimeUI7U2YkiTFvOuKVvXYSKPQ3w6WQD/4icnqBhRHPekkMoZokPGrWFQGtDM6nCJlWFSWy+7KbOFCWbx2FqTXnhzEyJrYQ3x60z9UmTVvF30DgPI9ZGHV0dU3LVwau+V2BVZVAa5fpd/BsjN5Ig5qxVG3hR1vsdF5HAEiDQUnZanRlnQFeY2ivnuTYktxI+WuIWUhGVFPYRGqaFi59Qze3J56RrtUY5XS6gKM68IOmubeQ0xAwOgGX2qoWIvE6EipI8TrtR41hocUjoEyQ5Ln9W2DjgVIohi5LFR4ZiLHTy+9QLEyM9Lls/tQx2/3X/GfKB19PjjQyg9RH24askakc9smHUMFvsPUibvnoX2AmFbhcCnkD3FV6RVnZTeX5I/cKBQCmb8Ph28Wjc= X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3290;20:RpKg3Aao/EDQdkNxAfZEiOOQlP0j684aDZzoHF/z0s9LP2o9P8PbWYpPbFJOFnERKrDBahVzP1CvXOy3M5KV+I4jeiEl55ISadMg57mvBhJz4zAIrtckfMAxXIKTgSJ0MRJuFqC5SWdzKVgb9/1HeM3FnLLbdr8aEDJi+Ewc08w= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2017 13:16:06.3953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR05MB3290 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2017 at 10:28:29PM +0200, Arnd Bergmann wrote: > On Fri, Jul 14, 2017 at 9:23 PM, Linus Torvalds > wrote: > > On Fri, Jul 14, 2017 at 12:21 PM, Linus Torvalds > > wrote: > >> > >> NAK. This takes unintentionally insane code and turns it intentionally > >> insane. Any non-zero return is considered an error. > >> > >> The right fix is almost certainly to just return -EINVAL unconditionally. Correct. I'll fix this. > > > > Btw, this is why I hate compiler warning fix patch series. Even when > > they don't actually break the code (and sometimes they do that too), > > they can actually end up making the code worse. > > I generally agree, and this is also why I held up sending patches for the > -Wformat warnings until you brought those up. I also frequently send > patches for recently introduced warnings, which tend to have a better > chance of getting reviewed by the person that just introduced the code, > to catch this kind of mistake in my patches. > > I also regularly run into cases where I send a correct patch and find > that another broken patch has been applied the following day ;-) > > > The *intent* of that code was to return zero for the CAP_SYS_ADMIN. > > But the code has never done that in its lifetime and nobody ever > > noticed, so clearly the code shouldn't even have tried. > > Makes sense, yes. In this case, the review process has failed as > well, as one of the maintainers even gave an Ack on the wrong patch, > and then the patch got dropped without any feedback. I've done some digging and noticed that my -fixes pull request didn't get picked up last December. It's most likely because I initially made an address typo in the original request, and then followed it up with a direct email with the correct address. Sinclair