From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v10 03/11] net/failsafe: add fail-safe PMD Date: Tue, 18 Jul 2017 01:17:07 +0200 Message-ID: <20170717231706.GV11154@bidouze.vm.6wind.com> References: <7390b7f14a1925ece0c55c6b1df8da358c725017.1500130634.git.gaetan.rivet@6wind.com> <784ab02a-2454-f209-ac52-ff1e53ec1a63@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id EE63C2030 for ; Tue, 18 Jul 2017 01:17:16 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id y43so4298847wrd.3 for ; Mon, 17 Jul 2017 16:17:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <784ab02a-2454-f209-ac52-ff1e53ec1a63@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 17, 2017 at 02:56:54PM +0100, Ferruh Yigit wrote: <...> > > +Stats per queue = Y > > +Unicast MAC filter = Y > > +Queue start/stop = Y > > +Jumbo frame = Y > > +Multicast MAC filter = Y > > Is above ones supported by PMD, I don't see them unless I miss something. > Queue start/stop was an error. All others are supported as long as the slave support it. <...> > > + sdev = TX_SUBDEV(dev); > > + rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos); > > + PRIV(dev)->infos.rx_offload_capa = rx_offload_capa; > > Is intention &= ? > rx_offload_capa is already set a little higher, and then an AND is done on it with all slaves. The "=" is correct here. Thanks for asking though, it's always useful to check :). --- I fixed all other remarks. I will wait a little for any possible additional changes you might want to point before sending the new version. -- Gaëtan Rivet 6WIND