From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbdGSEt3 (ORCPT ); Wed, 19 Jul 2017 00:49:29 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:44035 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbdGSEt1 (ORCPT ); Wed, 19 Jul 2017 00:49:27 -0400 Date: Wed, 19 Jul 2017 07:49:23 +0300 From: Baruch Siach To: Yong Cc: mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, hans.verkuil@cisco.com, peter.griffin@linaro.org, hugues.fruchet@st.com, krzk@kernel.org, bparrot@ti.com, arnd@arndb.de, jean-christophe.trotin@st.com, benjamin.gaignard@linaro.org, tiffany.lin@mediatek.com, kamil@wypas.org, kieran+renesas@ksquared.org.uk, andrew-ct.chen@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI Message-ID: <20170719044923.yae2ye4slvrmtyfe@sapphire.tkos.co.il> References: <1498561654-14658-1-git-send-email-yong.deng@magewell.com> <1498561654-14658-3-git-send-email-yong.deng@magewell.com> <20170718115530.ssy7g5vv4siqnfpo@tarshish> <20170719092249.2fb6ec720ba1b194cea320c8@magewell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170719092249.2fb6ec720ba1b194cea320c8@magewell.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yong, On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote: > On Tue, 18 Jul 2017 14:55:30 +0300 > Baruch Siach wrote: > > I am trying to get this driver working on the Olimex A33 OLinuXino. I > > didn't get it working yet, but I had some progress. See the comment below > > on one issue I encountered. > > > > On Tue, Jun 27, 2017 at 07:07:34PM +0800, Yong Deng wrote: > > > Add binding documentation for Allwinner CSI. > > > > > > Signed-off-by: Yong Deng > > > --- [...] > > > +Example: > > > + > > > + csi1: csi@01cb4000 { > > > + compatible = "allwinner,sun8i-v3s-csi"; > > > + reg = <0x01cb4000 0x1000>; > > > > You use platform_get_resource_byname() to get this IO resource. This requires > > adding mandatory > > > > reg-names = "csi"; > > > > But is it actually needed? Wouldn't a simple platform_get_resource() be > > enough? > > You are right. > This will be fixed in the next version. > I am waiting for more comments for the sunxi-csi.h. It's pleasure if > you have any suggestions about it. You mean sunxi_csi.h, right? Why do you need the sunxi_csi_ops indirection? Do you expect to add alternative implementations of these ops at some point? baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI Date: Wed, 19 Jul 2017 07:49:23 +0300 Message-ID: <20170719044923.yae2ye4slvrmtyfe@sapphire.tkos.co.il> References: <1498561654-14658-1-git-send-email-yong.deng@magewell.com> <1498561654-14658-3-git-send-email-yong.deng@magewell.com> <20170718115530.ssy7g5vv4siqnfpo@tarshish> <20170719092249.2fb6ec720ba1b194cea320c8@magewell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170719092249.2fb6ec720ba1b194cea320c8-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yong Cc: mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org, peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, hugues.fruchet-qxv4g6HH51o@public.gmane.org, krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, bparrot-l0cyMroinI0@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, jean-christophe.trotin-qxv4g6HH51o@public.gmane.org, benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, kamil-MZ2JYD8fkKLYtjvyW6yDsg@public.gmane.org, kieran+renesas-7hKh/agyDeatmTQ+vhA3Yw@public.gmane.org, andrew-ct.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Yong, On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote: > On Tue, 18 Jul 2017 14:55:30 +0300 > Baruch Siach wrote: > > I am trying to get this driver working on the Olimex A33 OLinuXino. I > > didn't get it working yet, but I had some progress. See the comment below > > on one issue I encountered. > > > > On Tue, Jun 27, 2017 at 07:07:34PM +0800, Yong Deng wrote: > > > Add binding documentation for Allwinner CSI. > > > > > > Signed-off-by: Yong Deng > > > --- [...] > > > +Example: > > > + > > > + csi1: csi@01cb4000 { > > > + compatible = "allwinner,sun8i-v3s-csi"; > > > + reg = <0x01cb4000 0x1000>; > > > > You use platform_get_resource_byname() to get this IO resource. This requires > > adding mandatory > > > > reg-names = "csi"; > > > > But is it actually needed? Wouldn't a simple platform_get_resource() be > > enough? > > You are right. > This will be fixed in the next version. > I am waiting for more comments for the sunxi-csi.h. It's pleasure if > you have any suggestions about it. You mean sunxi_csi.h, right? Why do you need the sunxi_csi_ops indirection? Do you expect to add alternative implementations of these ops at some point? baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: baruch@tkos.co.il (Baruch Siach) Date: Wed, 19 Jul 2017 07:49:23 +0300 Subject: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI In-Reply-To: <20170719092249.2fb6ec720ba1b194cea320c8@magewell.com> References: <1498561654-14658-1-git-send-email-yong.deng@magewell.com> <1498561654-14658-3-git-send-email-yong.deng@magewell.com> <20170718115530.ssy7g5vv4siqnfpo@tarshish> <20170719092249.2fb6ec720ba1b194cea320c8@magewell.com> Message-ID: <20170719044923.yae2ye4slvrmtyfe@sapphire.tkos.co.il> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Yong, On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote: > On Tue, 18 Jul 2017 14:55:30 +0300 > Baruch Siach wrote: > > I am trying to get this driver working on the Olimex A33 OLinuXino. I > > didn't get it working yet, but I had some progress. See the comment below > > on one issue I encountered. > > > > On Tue, Jun 27, 2017 at 07:07:34PM +0800, Yong Deng wrote: > > > Add binding documentation for Allwinner CSI. > > > > > > Signed-off-by: Yong Deng > > > --- [...] > > > +Example: > > > + > > > + csi1: csi at 01cb4000 { > > > + compatible = "allwinner,sun8i-v3s-csi"; > > > + reg = <0x01cb4000 0x1000>; > > > > You use platform_get_resource_byname() to get this IO resource. This requires > > adding mandatory > > > > reg-names = "csi"; > > > > But is it actually needed? Wouldn't a simple platform_get_resource() be > > enough? > > You are right. > This will be fixed in the next version. > I am waiting for more comments for the sunxi-csi.h. It's pleasure if > you have any suggestions about it. You mean sunxi_csi.h, right? Why do you need the sunxi_csi_ops indirection? Do you expect to add alternative implementations of these ops at some point? baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -