From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965115AbdGTLP4 (ORCPT ); Thu, 20 Jul 2017 07:15:56 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:37157 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934281AbdGTLPx (ORCPT ); Thu, 20 Jul 2017 07:15:53 -0400 Date: Thu, 20 Jul 2017 08:15:38 -0300 From: Mauro Carvalho Chehab To: Rob Herring Cc: Sylwester Nawrocki , Frank Rowand , "linux-media@vger.kernel.org" , Mauro Carvalho Chehab , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Kyungmin Park , Andrzej Hajda , "Lad, Prabhakar" , Songjun Wu , Kukjin Kim , Krzysztof Kozlowski , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Matthias Brugger , Laurent Pinchart , Niklas =?UTF-8?B?U8O2ZGVybHVuZA==?= , Guennadi Liakhovetski , Hyun Kwon , Michal Simek , =?UTF-8?B?U8O2cmVu?= Brinkmann , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , linux-mediatek@lists.infradead.org, "open list:MEDIA DRIVERS FOR RENESAS - FCP" Subject: Re: [PATCH] media: Convert to using %pOF instead of full_name Message-ID: <20170720081508.33563afe@vento.lan> In-Reply-To: References: <20170718214339.7774-33-robh@kernel.org> <564a6768-3b23-6dc7-ecb5-cb4f4359b633@samsung.com> Organization: Samsung X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, 19 Jul 2017 11:02:01 -0500 Rob Herring escreveu: > On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki > wrote: > > On 07/18/2017 11:43 PM, Rob Herring wrote: > >> Now that we have a custom printf format specifier, convert users of > >> full_name to use %pOF instead. This is preparation to remove storing > >> of the full path string for each node. > >> > >> Signed-off-by: Rob Herring > > > >> --- > >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +- > >> drivers/media/i2c/s5k5baf.c | 7 ++-- > >> drivers/media/platform/am437x/am437x-vpfe.c | 4 +- > >> drivers/media/platform/atmel/atmel-isc.c | 4 +- > >> drivers/media/platform/davinci/vpif_capture.c | 16 ++++---- > >> drivers/media/platform/exynos4-is/fimc-is.c | 8 ++-- > >> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +- > >> drivers/media/platform/exynos4-is/media-dev.c | 8 ++-- > >> drivers/media/platform/exynos4-is/mipi-csis.c | 4 +- > >> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +-- > >> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++-- > >> drivers/media/platform/omap3isp/isp.c | 8 ++-- > >> drivers/media/platform/pxa_camera.c | 2 +- > >> drivers/media/platform/rcar-vin/rcar-core.c | 4 +- > >> drivers/media/platform/soc_camera/soc_camera.c | 6 +-- > >> drivers/media/platform/xilinx/xilinx-vipp.c | 52 +++++++++++++------------- > >> drivers/media/v4l2-core/v4l2-async.c | 4 +- > >> drivers/media/v4l2-core/v4l2-clk.c | 3 +- > >> include/media/v4l2-clk.h | 4 +- > >> 19 files changed, 71 insertions(+), 83 deletions(-) > > > >> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c > >> index ac4704388920..9233ad0b1b6b 100644 > >> --- a/drivers/media/platform/xilinx/xilinx-vipp.c > >> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c > > > >> @@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct xvip_composite_device *xdev, > >> remote = ent->entity; > >> > >> if (link.remote_port >= remote->num_pads) { > >> - dev_err(xdev->dev, "invalid port number %u on %s\n", > >> - link.remote_port, > >> - to_of_node(link.remote_node)->full_name); > >> + dev_err(xdev->dev, "invalid port number %u on %pOF\n", > >> + link.remote_port, link.remote_node); > > > > Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ? > > Humm, yes. I thought I fixed that. After such fix, I'm OK with this patch. Are you planning to apply it on your tree, or via the media one? I guess it is probably better to apply via media, in order to avoid conflicts with other changes. Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH] media: Convert to using %pOF instead of full_name Date: Thu, 20 Jul 2017 08:15:38 -0300 Message-ID: <20170720081508.33563afe@vento.lan> References: <20170718214339.7774-33-robh@kernel.org> <564a6768-3b23-6dc7-ecb5-cb4f4359b633@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Rob Herring Cc: Sylwester Nawrocki , Frank Rowand , "linux-media@vger.kernel.org" , Mauro Carvalho Chehab , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Kyungmin Park , Andrzej Hajda , "Lad, Prabhakar" , Songjun Wu , Kukjin Kim , Krzysztof Kozlowski , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Matthias Brugger , Laurent Pinchart List-Id: devicetree@vger.kernel.org Em Wed, 19 Jul 2017 11:02:01 -0500 Rob Herring escreveu: > On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki > wrote: > > On 07/18/2017 11:43 PM, Rob Herring wrote: > >> Now that we have a custom printf format specifier, convert users of > >> full_name to use %pOF instead. This is preparation to remove storing > >> of the full path string for each node. > >> > >> Signed-off-by: Rob Herring > > > >> --- > >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +- > >> drivers/media/i2c/s5k5baf.c | 7 ++-- > >> drivers/media/platform/am437x/am437x-vpfe.c | 4 +- > >> drivers/media/platform/atmel/atmel-isc.c | 4 +- > >> drivers/media/platform/davinci/vpif_capture.c | 16 ++++---- > >> drivers/media/platform/exynos4-is/fimc-is.c | 8 ++-- > >> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +- > >> drivers/media/platform/exynos4-is/media-dev.c | 8 ++-- > >> drivers/media/platform/exynos4-is/mipi-csis.c | 4 +- > >> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +-- > >> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++-- > >> drivers/media/platform/omap3isp/isp.c | 8 ++-- > >> drivers/media/platform/pxa_camera.c | 2 +- > >> drivers/media/platform/rcar-vin/rcar-core.c | 4 +- > >> drivers/media/platform/soc_camera/soc_camera.c | 6 +-- > >> drivers/media/platform/xilinx/xilinx-vipp.c | 52 +++++++++++++------------- > >> drivers/media/v4l2-core/v4l2-async.c | 4 +- > >> drivers/media/v4l2-core/v4l2-clk.c | 3 +- > >> include/media/v4l2-clk.h | 4 +- > >> 19 files changed, 71 insertions(+), 83 deletions(-) > > > >> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c > >> index ac4704388920..9233ad0b1b6b 100644 > >> --- a/drivers/media/platform/xilinx/xilinx-vipp.c > >> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c > > > >> @@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct xvip_composite_device *xdev, > >> remote = ent->entity; > >> > >> if (link.remote_port >= remote->num_pads) { > >> - dev_err(xdev->dev, "invalid port number %u on %s\n", > >> - link.remote_port, > >> - to_of_node(link.remote_node)->full_name); > >> + dev_err(xdev->dev, "invalid port number %u on %pOF\n", > >> + link.remote_port, link.remote_node); > > > > Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ? > > Humm, yes. I thought I fixed that. After such fix, I'm OK with this patch. Are you planning to apply it on your tree, or via the media one? I guess it is probably better to apply via media, in order to avoid conflicts with other changes. Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 From: mchehab@s-opensource.com (Mauro Carvalho Chehab) Date: Thu, 20 Jul 2017 08:15:38 -0300 Subject: [PATCH] media: Convert to using %pOF instead of full_name In-Reply-To: References: <20170718214339.7774-33-robh@kernel.org> <564a6768-3b23-6dc7-ecb5-cb4f4359b633@samsung.com> Message-ID: <20170720081508.33563afe@vento.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Em Wed, 19 Jul 2017 11:02:01 -0500 Rob Herring escreveu: > On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki > wrote: > > On 07/18/2017 11:43 PM, Rob Herring wrote: > >> Now that we have a custom printf format specifier, convert users of > >> full_name to use %pOF instead. This is preparation to remove storing > >> of the full path string for each node. > >> > >> Signed-off-by: Rob Herring > > > >> --- > >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +- > >> drivers/media/i2c/s5k5baf.c | 7 ++-- > >> drivers/media/platform/am437x/am437x-vpfe.c | 4 +- > >> drivers/media/platform/atmel/atmel-isc.c | 4 +- > >> drivers/media/platform/davinci/vpif_capture.c | 16 ++++---- > >> drivers/media/platform/exynos4-is/fimc-is.c | 8 ++-- > >> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +- > >> drivers/media/platform/exynos4-is/media-dev.c | 8 ++-- > >> drivers/media/platform/exynos4-is/mipi-csis.c | 4 +- > >> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +-- > >> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++-- > >> drivers/media/platform/omap3isp/isp.c | 8 ++-- > >> drivers/media/platform/pxa_camera.c | 2 +- > >> drivers/media/platform/rcar-vin/rcar-core.c | 4 +- > >> drivers/media/platform/soc_camera/soc_camera.c | 6 +-- > >> drivers/media/platform/xilinx/xilinx-vipp.c | 52 +++++++++++++------------- > >> drivers/media/v4l2-core/v4l2-async.c | 4 +- > >> drivers/media/v4l2-core/v4l2-clk.c | 3 +- > >> include/media/v4l2-clk.h | 4 +- > >> 19 files changed, 71 insertions(+), 83 deletions(-) > > > >> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c > >> index ac4704388920..9233ad0b1b6b 100644 > >> --- a/drivers/media/platform/xilinx/xilinx-vipp.c > >> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c > > > >> @@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct xvip_composite_device *xdev, > >> remote = ent->entity; > >> > >> if (link.remote_port >= remote->num_pads) { > >> - dev_err(xdev->dev, "invalid port number %u on %s\n", > >> - link.remote_port, > >> - to_of_node(link.remote_node)->full_name); > >> + dev_err(xdev->dev, "invalid port number %u on %pOF\n", > >> + link.remote_port, link.remote_node); > > > > Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ? > > Humm, yes. I thought I fixed that. After such fix, I'm OK with this patch. Are you planning to apply it on your tree, or via the media one? I guess it is probably better to apply via media, in order to avoid conflicts with other changes. Thanks, Mauro