From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
mreitz@redhat.com, kwolf@redhat.com, armbru@redhat.com,
crosa@redhat.com, ldoktor@redhat.com,
Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v3 2/3] qemu.py: include debug information on launch error
Date: Thu, 20 Jul 2017 11:19:01 +0200 [thread overview]
Message-ID: <20170720091902.22476-3-apahim@redhat.com> (raw)
In-Reply-To: <20170720091902.22476-1-apahim@redhat.com>
When launching a VM, if an exception happens and the VM is not
initiated, it is useful to see the qemu command line that was executed
and the output of that command.
Before the patch:
>>> VM = qemu.QEMUMachine('../aarch64-softmmu/qemu-system-aarch64')
>>> VM.launch()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "qemu.py", line 137, in launch
self._post_launch()
File "qemu.py", line 121, in _post_launch
self._qmp.accept()
File "qmp/qmp.py", line 145, in accept
self.__sock, _ = self.__sock.accept()
File "/usr/lib64/python2.7/socket.py", line 206, in accept
sock, addr = self._sock.accept()
socket.timeout: timed out
After the patch:
>>> VM = qemu.QEMUMachine('../aarch64-softmmu/qemu-system-aarch64')
>>> VM.launch()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "qemu.py", line 156, in launch
raise RuntimeError(msg)
RuntimeError: Error launching VM.
Original Exception:
Traceback (most recent call last):
File "qemu.py", line 138, in launch
self._post_launch()
File "qemu.py", line 122, in _post_launch
self._qmp.accept()
File "qmp/qmp.py", line 145, in accept
self.__sock, _ = self.__sock.accept()
File "/usr/lib64/python2.7/socket.py", line 206, in accept
sock, addr = self._sock.accept()
timeout: timed out
Command:
/usr/bin/qemu-system-aarch64 -chardev socket,id=mon,
path=/var/tmp/qemu-23958-monitor.sock -mon chardev=mon,mode=control
-display none -vga none
Output:
qemu-system-aarch64: No machine specified, and there is no default
Use -machine help to list supported machines
Also, if the launch() faces an exception, the 'except' now will use args
to fill the debug information. So this patch assigns 'args' earlier,
assuring it will be available for the 'except'.
Signed-off-by: Amador Pahim <apahim@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
---
scripts/qemu.py | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index f0fade32bd..2707ae7f75 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -18,6 +18,7 @@ import os
import sys
import subprocess
import qmp.qmp
+import traceback
class QEMUMachine(object):
@@ -129,17 +130,30 @@ class QEMUMachine(object):
'''Launch the VM and establish a QMP connection'''
devnull = open('/dev/null', 'rb')
qemulog = open(self._qemu_log_path, 'wb')
+ args = self._wrapper + [self._binary] + self._base_args() + self.args
try:
self._pre_launch()
- args = self._wrapper + [self._binary] + self._base_args() + self._args
self._popen = subprocess.Popen(args, stdin=devnull, stdout=qemulog,
stderr=subprocess.STDOUT, shell=False)
self._post_launch()
except:
+ self._load_io_log()
if self.is_running():
self._popen.kill()
self._popen.wait()
- self._load_io_log()
+ else:
+ exc_type, exc_value, exc_traceback = sys.exc_info()
+ msg = ('Error launching VM.\n'
+ 'Original Exception: \n%s'
+ 'Command:\n%s\n'
+ 'Output:\n%s\n' %
+ (''.join(traceback.format_exception(exc_type,
+ exc_value,
+ exc_traceback)),
+ ' '.join(args),
+ self._iolog))
+ self._post_shutdown()
+ raise RuntimeError(msg)
self._post_shutdown()
raise
--
2.13.3
next prev parent reply other threads:[~2017-07-20 9:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 9:18 [Qemu-devel] [PATCH v3 0/3] scripts/qemu.py small fixes Amador Pahim
2017-07-20 9:19 ` [Qemu-devel] [PATCH v3 1/3] qemu.py: fix is_running() Amador Pahim
2017-07-20 11:49 ` Markus Armbruster
2017-07-20 12:57 ` Amador Pahim
2017-07-20 15:09 ` Markus Armbruster
2017-07-20 15:46 ` Amador Pahim
2017-07-20 17:49 ` Eduardo Habkost
2017-07-20 20:14 ` Amador Pahim
2017-07-21 7:34 ` Lukáš Doktor
2017-07-20 9:19 ` Amador Pahim [this message]
2017-07-20 11:58 ` [Qemu-devel] [PATCH v3 2/3] qemu.py: include debug information on launch error Markus Armbruster
2017-07-20 13:14 ` Amador Pahim
2017-07-20 14:43 ` Eduardo Habkost
2017-07-20 15:51 ` Amador Pahim
2017-07-20 15:01 ` Markus Armbruster
2017-07-20 15:50 ` Amador Pahim
2017-07-20 9:19 ` [Qemu-devel] [PATCH v3 3/3] qemu.py: make 'args' public Amador Pahim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720091902.22476-3-apahim@redhat.com \
--to=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ldoktor@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.