From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fieldses.org ([173.255.197.46]:60576 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935990AbdGTSh7 (ORCPT ); Thu, 20 Jul 2017 14:37:59 -0400 Date: Thu, 20 Jul 2017 14:37:59 -0400 To: Steve Dickson Cc: Linux NFS Mailing list Subject: Re: [PATCH 08/11] network.c: removed some warnings Message-ID: <20170720183759.GC19909@fieldses.org> References: <20170719205354.10006-1-steved@redhat.com> <20170719205354.10006-9-steved@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170719205354.10006-9-steved@redhat.com> From: bfields@fieldses.org (J. Bruce Fields) Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Jul 19, 2017 at 04:53:51PM -0400, Steve Dickson wrote: > network.c:1234:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > network.c:1382:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > network.c:1477:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > network.c:1508:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > network.c:1574:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Looks like after this an out-of-range port number will be treated as an unspecified port rather than returning an error. That sounds wrong. I didn't check the others. All of these "break" statements added without any explanation are making me nervous. --b. > Signed-off-by: Steve Dickson > --- > utils/mount/network.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/utils/mount/network.c b/utils/mount/network.c > index 281e935..19f14e5 100644 > --- a/utils/mount/network.c > +++ b/utils/mount/network.c > @@ -1235,6 +1235,7 @@ nfs_nfs_program(struct mount_options *options, unsigned long *program) > *program = tmp; > return 1; > } > + break; > case PO_BAD_VALUE: > nfs_error(_("%s: invalid value for 'nfsprog=' option"), > progname); > @@ -1383,6 +1384,7 @@ nfs_nfs_port(struct mount_options *options, unsigned long *port) > *port = tmp; > return 1; > } > + break; > case PO_BAD_VALUE: > nfs_error(_("%s: invalid value for 'port=' option"), > progname); > @@ -1478,6 +1480,7 @@ nfs_mount_program(struct mount_options *options, unsigned long *program) > *program = tmp; > return 1; > } > + break; > case PO_BAD_VALUE: > nfs_error(_("%s: invalid value for 'mountprog=' option"), > progname); > @@ -1509,6 +1512,7 @@ nfs_mount_version(struct mount_options *options, unsigned long *version) > *version = tmp; > return 1; > } > + break; > case PO_BAD_VALUE: > nfs_error(_("%s: invalid value for 'mountvers=' option"), > progname); > @@ -1575,6 +1579,7 @@ nfs_mount_port(struct mount_options *options, unsigned long *port) > *port = tmp; > return 1; > } > + break; > case PO_BAD_VALUE: > nfs_error(_("%s: invalid value for 'mountport=' option"), > progname); > -- > 2.13.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html