From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EB77221AEB0A0 for ; Wed, 26 Jul 2017 04:27:36 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id c24so18365324wra.2 for ; Wed, 26 Jul 2017 04:29:39 -0700 (PDT) Date: Wed, 26 Jul 2017 13:29:35 +0200 From: Ingo Molnar Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h Message-ID: <20170726112935.a4ztsb6yke7bhsvo@gmail.com> References: <150102217021.2258.1380624380896006.stgit@dwillia2-desk3.amr.corp.intel.com> <150102218643.2258.15362632812220627446.stgit@dwillia2-desk3.amr.corp.intel.com> <20170725235512.GC23846@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: "linux-nvdimm@lists.01.org" , Peter Zijlstra , "linux-kernel@vger.kernel.org" , Arnaldo Carvalho de Melo , Alexander Shishkin , Ingo Molnar List-ID: * Dan Williams wrote: > On Tue, Jul 25, 2017 at 4:55 PM, Arnaldo Carvalho de Melo > wrote: > > Em Tue, Jul 25, 2017 at 03:36:26PM -0700, Dan Williams escreveu: > >> Replace the ccan implementation of list primitives, bitmap helpers and > >> small utility macros with the common definitions available in > >> tool/include/linux. > > > > You should first add what you need in separate patches, paving the way > > to then use it, and some stuff are already there, see below: > > Ok, I'll break out those changes separately. BTW., another general observation I have is that ndctl uses autotools - while perf uses its own build system, some of which is abstracted out into tools/build/ and reused by other tooling projects as well. I despise autotools with a passion, it's slow, bloated, and encourages all sorts of bad API/ABI practices that plagues many OSS projects. I know that Linus explicitly did a Makefile based build system for Git for (I think) similar reasons. It might be a good idea to not let autotools into the kernel tooling tree, not because ndctl's use of autotools is bad in any fashion (it appears to be a fairly straightforward use), but to generally encourage good API/ABI practices in our tooling space, and to encourage enhancements to the tools/build/ infrastructure. Thanks, Ingo _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751574AbdGZL3k (ORCPT ); Wed, 26 Jul 2017 07:29:40 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33910 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbdGZL3j (ORCPT ); Wed, 26 Jul 2017 07:29:39 -0400 Date: Wed, 26 Jul 2017 13:29:35 +0200 From: Ingo Molnar To: Dan Williams Cc: Arnaldo Carvalho de Melo , "linux-nvdimm@lists.01.org" , Peter Zijlstra , Alexander Shishkin , Ingo Molnar , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h Message-ID: <20170726112935.a4ztsb6yke7bhsvo@gmail.com> References: <150102217021.2258.1380624380896006.stgit@dwillia2-desk3.amr.corp.intel.com> <150102218643.2258.15362632812220627446.stgit@dwillia2-desk3.amr.corp.intel.com> <20170725235512.GC23846@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dan Williams wrote: > On Tue, Jul 25, 2017 at 4:55 PM, Arnaldo Carvalho de Melo > wrote: > > Em Tue, Jul 25, 2017 at 03:36:26PM -0700, Dan Williams escreveu: > >> Replace the ccan implementation of list primitives, bitmap helpers and > >> small utility macros with the common definitions available in > >> tool/include/linux. > > > > You should first add what you need in separate patches, paving the way > > to then use it, and some stuff are already there, see below: > > Ok, I'll break out those changes separately. BTW., another general observation I have is that ndctl uses autotools - while perf uses its own build system, some of which is abstracted out into tools/build/ and reused by other tooling projects as well. I despise autotools with a passion, it's slow, bloated, and encourages all sorts of bad API/ABI practices that plagues many OSS projects. I know that Linus explicitly did a Makefile based build system for Git for (I think) similar reasons. It might be a good idea to not let autotools into the kernel tooling tree, not because ndctl's use of autotools is bad in any fashion (it appears to be a fairly straightforward use), but to generally encourage good API/ABI practices in our tooling space, and to encourage enhancements to the tools/build/ infrastructure. Thanks, Ingo