From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbdGZVjN (ORCPT ); Wed, 26 Jul 2017 17:39:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37366 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbdGZVjM (ORCPT ); Wed, 26 Jul 2017 17:39:12 -0400 Date: Wed, 26 Jul 2017 14:39:11 -0700 From: Andrew Morton To: Mark Brown Cc: Arnd Bergmann , Masahiro Yamada , Charles Keepax , Tony Lindgren , Michael Grzeschik , Ramesh Shanmugasundaram , "Alex A. Mihaylov" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] iopoll: avoid -Wint-in-bool-context warning Message-Id: <20170726143911.ccad00870bb9b8e3021ea634@linux-foundation.org> In-Reply-To: <20170726142806.rvusoy3awqg3t2xm@sirena.org.uk> References: <20170726133756.2161367-1-arnd@arndb.de> <20170726142806.rvusoy3awqg3t2xm@sirena.org.uk> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Jul 2017 15:28:06 +0100 Mark Brown wrote: > On Wed, Jul 26, 2017 at 03:37:32PM +0200, Arnd Bergmann wrote: > > When we pass the result of a multiplication as the timeout or > > the delay, we can get a warning: > > This'd be easier if you sent each of the changes separately... I think it's OK - the patch encapsulates a single concept. Doesn't matter much either way, unless someone wants to take one part only into a particular tree(?).