From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C266A21D091AF for ; Wed, 26 Jul 2017 10:55:46 -0700 (PDT) Date: Wed, 26 Jul 2017 14:57:39 -0300 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h Message-ID: <20170726175739.GF23846@kernel.org> References: <150102217021.2258.1380624380896006.stgit@dwillia2-desk3.amr.corp.intel.com> <150102218643.2258.15362632812220627446.stgit@dwillia2-desk3.amr.corp.intel.com> <20170725235512.GC23846@kernel.org> <20170726112935.a4ztsb6yke7bhsvo@gmail.com> <20170726171952.frohvqpekfx4iefn@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: "linux-nvdimm@lists.01.org" , Peter Zijlstra , "linux-kernel@vger.kernel.org" , Alexander Shishkin , Ingo Molnar , Ingo Molnar List-ID: Em Wed, Jul 26, 2017 at 10:31:48AM -0700, Dan Williams escreveu: > On Wed, Jul 26, 2017 at 10:19 AM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> On Wed, Jul 26, 2017 at 4:29 AM, Ingo Molnar wrote: > > which I could initially mistake for a commit about scheduler completions ;-) > > > > Or: > > 2ad6a39c9ae9: Fix attribute sizes to match NFIT 0.8s2 > > cc7cb44385d3: Import initial infrastructure > > etc. > > I suppose all that could be corrected, SOBs added, titles clarified and prefixed > > with tools/ndctl, but then it wouldn't really be unmodified history anymore, > > right? > > At that point we might as well do a clean start - and not import ~500 extra > > commits into the kernel tree? > I think keeping the history is worth it, similar reasoning to why we > kept the btrfs history. Also, since the history is linear and already > rewritten by 'git filter-branch' to move everything to tools/ndctl/ it > wouldn't be that much more work to go clean up these few commits that > are problematic. Hey, but we can have something like: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/ It goes all the way to the 0.12 kernel. If someone wants to go that far, just clone that tree, merge it, etc. Could that be the solution for this case as well? I.e. the kernel history prior to what we have in linux.git can be accessed via that other tree, history.git, can we have ndctl-history.git and linux.git + ndctl from now on? If you prefer to go full merge, then I think prefixing + SOB'ing should be done, right? - Arnaldo _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbdGZR5x (ORCPT ); Wed, 26 Jul 2017 13:57:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:56454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdGZR5u (ORCPT ); Wed, 26 Jul 2017 13:57:50 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8281B22C93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 26 Jul 2017 14:57:39 -0300 From: Arnaldo Carvalho de Melo To: Dan Williams Cc: Ingo Molnar , "linux-nvdimm@lists.01.org" , Peter Zijlstra , Alexander Shishkin , Ingo Molnar , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h Message-ID: <20170726175739.GF23846@kernel.org> References: <150102217021.2258.1380624380896006.stgit@dwillia2-desk3.amr.corp.intel.com> <150102218643.2258.15362632812220627446.stgit@dwillia2-desk3.amr.corp.intel.com> <20170725235512.GC23846@kernel.org> <20170726112935.a4ztsb6yke7bhsvo@gmail.com> <20170726171952.frohvqpekfx4iefn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jul 26, 2017 at 10:31:48AM -0700, Dan Williams escreveu: > On Wed, Jul 26, 2017 at 10:19 AM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> On Wed, Jul 26, 2017 at 4:29 AM, Ingo Molnar wrote: > > which I could initially mistake for a commit about scheduler completions ;-) > > > > Or: > > 2ad6a39c9ae9: Fix attribute sizes to match NFIT 0.8s2 > > cc7cb44385d3: Import initial infrastructure > > etc. > > I suppose all that could be corrected, SOBs added, titles clarified and prefixed > > with tools/ndctl, but then it wouldn't really be unmodified history anymore, > > right? > > At that point we might as well do a clean start - and not import ~500 extra > > commits into the kernel tree? > I think keeping the history is worth it, similar reasoning to why we > kept the btrfs history. Also, since the history is linear and already > rewritten by 'git filter-branch' to move everything to tools/ndctl/ it > wouldn't be that much more work to go clean up these few commits that > are problematic. Hey, but we can have something like: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/ It goes all the way to the 0.12 kernel. If someone wants to go that far, just clone that tree, merge it, etc. Could that be the solution for this case as well? I.e. the kernel history prior to what we have in linux.git can be accessed via that other tree, history.git, can we have ndctl-history.git and linux.git + ndctl from now on? If you prefer to go full merge, then I think prefixing + SOB'ing should be done, right? - Arnaldo