From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063AbdG1NUe (ORCPT ); Fri, 28 Jul 2017 09:20:34 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:63934 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbdG1NUc (ORCPT ); Fri, 28 Jul 2017 09:20:32 -0400 From: Arnd Bergmann To: Joerg Roedel Cc: Arnd Bergmann , Marek Szyprowski , Kukjin Kim , Krzysztof Kozlowski , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] iommu/exynos: prevent building on big-endian kernels Date: Fri, 28 Jul 2017 15:19:19 +0200 Message-Id: <20170728131954.213595-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:/vpcgCcO/ZUaQwZxcAEnr8q0WkIpPZzfopeMbLAfKGyAzb4okDB fZi+Hcaei4rPTTupG0JZjTHsRLDg6xl2+5av6J9soaxgr2cqZIVNtpCk1sYOUzUg0piqMWo LBI+8Jv6E6JAjA5QEN8FD+WRc69CYmYyJdfoBieB26SAh1AmRItC/FzY4LPHNINBAtfwT2j VmyBRUqeesRFZWMZzgdoQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:4QEoha3eRKw=:iCzT2BicbfWFaf6eocneM+ Jm9KQ0+Ab3F9DFXooLEEpEnEvUQkHfKfNwK2Ik290acktqmAUg11A+/Hd4v1zT5mTKr96a8WU aKl5AWsmDLUbChasu0bxIZRBE3gQkbJnYqunvBte4H7PDnl/yjFTxX99ZD0tZioQjg+VOOG1s luxpS7mZioUb6rE1uc+rFdpqs6pQvUysLRVjqdHXA6wglR1opOCU5BF5EJwG1DT7SN3H2liIV Ck9jX+Hh/91UUm2URSCDinjjsAU9bpcDrFuB8oSzTzX52SrsQoggdUuG3iCHxi4Bw5xH0ucrr G7ZISZQLn4wHKvir2dFRtyT6vPln8PPLjK1vhL5w+D9BjekuOIAygjVnNjc24VSlwzXWklDvz PhQiNmgx6qznftFOdN6QIdVybPunnIswhROQkyz/jOrMIIrZmYMfpgibXt39llvtqIr2MGsVG RIMw125/qA07Ppxt0Oz8B7XY73pR2p5e8jhQN0HI0KvqMPSIeltEUMdvbKvBBaP1iSo3VaXz3 dw6KJF1GMxHyhImTWt5gHrhDkvEFD70ngTfXzfia2QfvAcWEmropNsI7E0vtfHPTNFYS5F2Un NJJQ2VeSt/VRojZ8+RY20ocuOCP21qEw+gqkYPsgcnmjzay8DgL7YeCF5H9sHOqqcrh2Mr5Xt lyQdE6Qvscxh6Q2tupzNe+CP/f5e2wVIISqICDHdB+kb1KCQQxUTDdIUW68DWZvfz4xf+MJYP wMyhrssk2DpRy30JaQ8Tv3VgAjXyiPtdlKaS4g== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since we print the correct warning, an allmodconfig build is no longer clean but always prints it, which defeats compile-testing: drivers/iommu/exynos-iommu.c:58:2: error: #warning "revisit driver if we can enable big-endian ptes" [-Werror=cpp] This replaces the #warning with a dependency, moving warning text into a comment. Fixes: 1f59adb1766d ("iommu/exynos: Replace non-existing big-endian Kconfig option") Signed-off-by: Arnd Bergmann --- drivers/iommu/Kconfig | 1 + drivers/iommu/exynos-iommu.c | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index f73ff28f77e2..c5d80fe3dab9 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -253,6 +253,7 @@ config TEGRA_IOMMU_SMMU config EXYNOS_IOMMU bool "Exynos IOMMU Support" depends on ARCH_EXYNOS && MMU + depends on !CPU_BIG_ENDIAN # revisit driver if we can enable big-endian ptes select IOMMU_API select ARM_DMA_USE_IOMMU help diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index b7aebaf28b82..c6b69e91132b 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -54,10 +54,6 @@ typedef u32 sysmmu_pte_t; #define lv2ent_small(pent) ((*(pent) & 2) == 2) #define lv2ent_large(pent) ((*(pent) & 3) == 1) -#ifdef CONFIG_CPU_BIG_ENDIAN -#warning "revisit driver if we can enable big-endian ptes" -#endif - /* * v1.x - v3.x SYSMMU supports 32bit physical and 32bit virtual address spaces * v5.0 introduced support for 36bit physical address space by shifting -- 2.9.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 28 Jul 2017 15:19:19 +0200 Subject: [PATCH] iommu/exynos: prevent building on big-endian kernels Message-ID: <20170728131954.213595-1-arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Since we print the correct warning, an allmodconfig build is no longer clean but always prints it, which defeats compile-testing: drivers/iommu/exynos-iommu.c:58:2: error: #warning "revisit driver if we can enable big-endian ptes" [-Werror=cpp] This replaces the #warning with a dependency, moving warning text into a comment. Fixes: 1f59adb1766d ("iommu/exynos: Replace non-existing big-endian Kconfig option") Signed-off-by: Arnd Bergmann --- drivers/iommu/Kconfig | 1 + drivers/iommu/exynos-iommu.c | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index f73ff28f77e2..c5d80fe3dab9 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -253,6 +253,7 @@ config TEGRA_IOMMU_SMMU config EXYNOS_IOMMU bool "Exynos IOMMU Support" depends on ARCH_EXYNOS && MMU + depends on !CPU_BIG_ENDIAN # revisit driver if we can enable big-endian ptes select IOMMU_API select ARM_DMA_USE_IOMMU help diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index b7aebaf28b82..c6b69e91132b 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -54,10 +54,6 @@ typedef u32 sysmmu_pte_t; #define lv2ent_small(pent) ((*(pent) & 2) == 2) #define lv2ent_large(pent) ((*(pent) & 3) == 1) -#ifdef CONFIG_CPU_BIG_ENDIAN -#warning "revisit driver if we can enable big-endian ptes" -#endif - /* * v1.x - v3.x SYSMMU supports 32bit physical and 32bit virtual address spaces * v5.0 introduced support for 36bit physical address space by shifting -- 2.9.0