From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751566AbdGaTbV convert rfc822-to-8bit (ORCPT ); Mon, 31 Jul 2017 15:31:21 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:49520 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbdGaTbU (ORCPT ); Mon, 31 Jul 2017 15:31:20 -0400 Date: Mon, 31 Jul 2017 20:30:25 +0100 From: Alan Cox To: David Lechner Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] Invert margin colors when terminal is inverted Message-ID: <20170731203025.6a59fdbd@alans-desktop> In-Reply-To: <1501528185-9976-1-git-send-email-david@lechnology.com> References: <1501528185-9976-1-git-send-email-david@lechnology.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Jul 2017 14:09:43 -0500 David Lechner wrote: > This is v2 of "fbcon: Use background color for margins​"[1]. > > It turns out that using the text background color was not a good choice. So, > I've started over. Can you explain why making the margins simply match the border colour (when possible) isn't a better option ? They are after all simply software extensions to the border. Alan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Date: Mon, 31 Jul 2017 19:30:25 +0000 Subject: Re: [PATCH v2 0/2] Invert margin colors when terminal is inverted Message-Id: <20170731203025.6a59fdbd@alans-desktop> List-Id: References: <1501528185-9976-1-git-send-email-david@lechnology.com> In-Reply-To: <1501528185-9976-1-git-send-email-david@lechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: David Lechner Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org On Mon, 31 Jul 2017 14:09:43 -0500 David Lechner wrote: > This is v2 of "fbcon: Use background color for margins=E2=80=8B"[1]. >=20 > It turns out that using the text background color was not a good choice. = So, > I've started over. Can you explain why making the margins simply match the border colour (when possible) isn't a better option ? They are after all simply software extensions to the border. Alan