From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support
Date: Tue, 1 Aug 2017 16:28:43 +0200 [thread overview]
Message-ID: <20170801142843.GE23157@lunn.ch> (raw)
In-Reply-To: <20170731221719.16695-11-vivien.didelot@savoirfairelinux.com>
On Mon, Jul 31, 2017 at 06:17:18PM -0400, Vivien Didelot wrote:
> The PHY's EEE settings are already accessed by the DSA layer through the
> Marvell PHY driver and there is nothing to be done for switch's MACs.
I'm confused, or missing something. Does not patch #1 mean that if the
DSA driver does not have a set_eee function, we always return -ENODEV
in slave.c?
There might be nothing to configure here, but some of the switches do
support EEE. So we need at least a NOP set_eee. Better still it should
return -ENODEV for those switches which don't actually support EEE,
and 0 for those that do?
Andrew
next prev parent reply other threads:[~2017-08-01 14:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 22:17 [PATCH net-next 00/11] net: dsa: rework EEE support Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 01/11] net: dsa: make EEE ops optional Vivien Didelot
2017-08-01 14:07 ` Andrew Lunn
2017-07-31 22:17 ` [PATCH net-next 02/11] net: dsa: qca8k: fix EEE init Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 03/11] net: dsa: qca8k: enable EEE once Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 04/11] net: dsa: qca8k: do not cache unneeded EEE fields Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 05/11] net: dsa: qca8k: remove qca8k_get_eee Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 06/11] net: dsa: bcm_sf2: remove unneeded supported flags Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 07/11] net: dsa: mv88e6xxx: call phy_init_eee Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 08/11] net: dsa: call phy_init_eee in DSA layer Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 09/11] net: dsa: remove PHY device argument from .set_eee Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support Vivien Didelot
2017-08-01 14:28 ` Andrew Lunn [this message]
2017-08-01 15:36 ` Vivien Didelot
2017-08-01 16:06 ` Andrew Lunn
2017-08-01 16:33 ` Florian Fainelli
2017-08-01 17:27 ` Andrew Lunn
2017-08-01 18:53 ` Florian Fainelli
2017-08-01 16:34 ` Vivien Didelot
2017-08-01 20:08 ` Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 11/11] net: dsa: rename switch EEE ops Vivien Didelot
2017-08-01 14:31 ` [PATCH net-next 00/11] net: dsa: rework EEE support Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801142843.GE23157@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.