From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752180AbdHCWfQ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 3 Aug 2017 18:35:16 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:50404 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752035AbdHCWfO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 3 Aug 2017 18:35:14 -0400
Date: Thu, 03 Aug 2017 15:35:13 -0700 (PDT)
Message-Id: <20170803.153513.1478323340993171697.davem@davemloft.net>
To: aviad.krawczyk@huawei.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bc.y@huawei.com,
        victor.gissin@huawei.com, zhaochen6@huawei.com, tony.qu@huawei.com
Subject: Re: [PATCH V3 net-next 03/21] net-next/hinic: Initialize api cmd
 resources
From: David Miller <davem@davemloft.net>
In-Reply-To: <18d3bfccc0eb9c7da53075c6fe2ba9aa583e0bff.1501752425.git.aviad.krawczyk@huawei.com>
References: <cover.1501752425.git.aviad.krawczyk@huawei.com>
        <18d3bfccc0eb9c7da53075c6fe2ba9aa583e0bff.1501752425.git.aviad.krawczyk@huawei.com>
X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 03 Aug 2017 15:35:14 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Aviad Krawczyk <aviad.krawczyk@huawei.com>
Date: Thu, 3 Aug 2017 17:54:09 +0800

> +static int alloc_cmd_buf(struct hinic_api_cmd_chain *chain,
> +			 struct hinic_api_cmd_cell *cell, int cell_idx)
> +{
> +	struct hinic_hwif *hwif = chain->hwif;
> +	struct pci_dev *pdev = hwif->pdev;
> +	struct hinic_api_cmd_cell_ctxt *cell_ctxt;
> +	dma_addr_t cmd_paddr;
> +	u8 *cmd_vaddr;
> +	int err = 0;

Order local variables from longest to shortest line.

> +static int api_cmd_create_cell(struct hinic_api_cmd_chain *chain,
> +			       int cell_idx,
> +			       struct hinic_api_cmd_cell *pre_node,
> +			       struct hinic_api_cmd_cell **node_vaddr)
> +{
> +	struct hinic_hwif *hwif = chain->hwif;
> +	struct pci_dev *pdev = hwif->pdev;
> +	struct hinic_api_cmd_cell_ctxt *cell_ctxt;
> +	struct hinic_api_cmd_cell *node;
> +	dma_addr_t node_paddr;
> +	int err;

Likewise.
> +static void api_cmd_destroy_cell(struct hinic_api_cmd_chain *chain,
> +				 int cell_idx)
> +{
> +	struct hinic_hwif *hwif = chain->hwif;
> +	struct pci_dev *pdev = hwif->pdev;
> +	struct hinic_api_cmd_cell_ctxt *cell_ctxt;
> +	struct hinic_api_cmd_cell *node;
> +	dma_addr_t node_paddr;
> +	size_t node_size;

Likewise.

etc. etc. etc.

Please audit your entire submission for this problem.

Thanks.