From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbdHCMKx (ORCPT ); Thu, 3 Aug 2017 08:10:53 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:52789 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbdHCMKw (ORCPT ); Thu, 3 Aug 2017 08:10:52 -0400 Date: Thu, 3 Aug 2017 14:10:50 +0200 From: Boris Brezillon To: Cihangir Akturk Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/29] drm/atmel-hlcdc: switch to drm_*{get,put} helpers Message-ID: <20170803141050.16e78d78@bbrezillon> In-Reply-To: <1501761585-11757-6-git-send-email-cakturk@gmail.com> References: <1501761585-11757-1-git-send-email-cakturk@gmail.com> <1501761585-11757-6-git-send-email-cakturk@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Aug 2017 14:58:20 +0300 Cihangir Akturk wrote: > drm_*_reference() and drm_*_unreference() functions are just > compatibility alias for drm_*_get() and drm_*_put() adn should not be s/adn/and/ > used by new code. So convert all users of compatibility functions to use > the new APIs. > > Signed-off-by: Cihangir Akturk Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > index 1124200..fc3f910 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > @@ -809,7 +809,7 @@ static void atmel_hlcdc_plane_destroy(struct drm_plane *p) > struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p); > > if (plane->base.fb) > - drm_framebuffer_unreference(plane->base.fb); > + drm_framebuffer_put(plane->base.fb); > > drm_plane_cleanup(p); > } > @@ -958,7 +958,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p) > state = drm_plane_state_to_atmel_hlcdc_plane_state(p->state); > > if (state->base.fb) > - drm_framebuffer_unreference(state->base.fb); > + drm_framebuffer_put(state->base.fb); > > kfree(state); > p->state = NULL; > @@ -996,7 +996,7 @@ atmel_hlcdc_plane_atomic_duplicate_state(struct drm_plane *p) > } > > if (copy->base.fb) > - drm_framebuffer_reference(copy->base.fb); > + drm_framebuffer_get(copy->base.fb); > > return ©->base; > } > @@ -1015,7 +1015,7 @@ static void atmel_hlcdc_plane_atomic_destroy_state(struct drm_plane *p, > } > > if (s->fb) > - drm_framebuffer_unreference(s->fb); > + drm_framebuffer_put(s->fb); > > kfree(state); > } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 05/29] drm/atmel-hlcdc: switch to drm_*{get,put} helpers Date: Thu, 3 Aug 2017 14:10:50 +0200 Message-ID: <20170803141050.16e78d78@bbrezillon> References: <1501761585-11757-1-git-send-email-cakturk@gmail.com> <1501761585-11757-6-git-send-email-cakturk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 064526E182 for ; Thu, 3 Aug 2017 12:10:53 +0000 (UTC) In-Reply-To: <1501761585-11757-6-git-send-email-cakturk@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Cihangir Akturk Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAgMyBBdWcgMjAxNyAxNDo1ODoyMCArMDMwMApDaWhhbmdpciBBa3R1cmsgPGNha3R1 cmtAZ21haWwuY29tPiB3cm90ZToKCj4gZHJtXypfcmVmZXJlbmNlKCkgYW5kIGRybV8qX3VucmVm ZXJlbmNlKCkgZnVuY3Rpb25zIGFyZSBqdXN0Cj4gY29tcGF0aWJpbGl0eSBhbGlhcyBmb3IgZHJt XypfZ2V0KCkgYW5kIGRybV8qX3B1dCgpIGFkbiBzaG91bGQgbm90IGJlCgpzL2Fkbi9hbmQvCgo+ IHVzZWQgYnkgbmV3IGNvZGUuIFNvIGNvbnZlcnQgYWxsIHVzZXJzIG9mIGNvbXBhdGliaWxpdHkg ZnVuY3Rpb25zIHRvIHVzZQo+IHRoZSBuZXcgQVBJcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaWhh bmdpciBBa3R1cmsgPGNha3R1cmtAZ21haWwuY29tPgoKQWNrZWQtYnk6IEJvcmlzIEJyZXppbGxv biA8Ym9yaXMuYnJlemlsbG9uQGZyZWUtZWxlY3Ryb25zLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9hdG1lbC1obGNkYy9hdG1lbF9obGNkY19wbGFuZS5jIHwgOCArKysrLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMvYXRtZWxfaGxjZGNfcGxhbmUuYyBi L2RyaXZlcnMvZ3B1L2RybS9hdG1lbC1obGNkYy9hdG1lbF9obGNkY19wbGFuZS5jCj4gaW5kZXgg MTEyNDIwMC4uZmMzZjkxMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxj ZGMvYXRtZWxfaGxjZGNfcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hdG1lbC1obGNk Yy9hdG1lbF9obGNkY19wbGFuZS5jCj4gQEAgLTgwOSw3ICs4MDksNyBAQCBzdGF0aWMgdm9pZCBh dG1lbF9obGNkY19wbGFuZV9kZXN0cm95KHN0cnVjdCBkcm1fcGxhbmUgKnApCj4gIAlzdHJ1Y3Qg YXRtZWxfaGxjZGNfcGxhbmUgKnBsYW5lID0gZHJtX3BsYW5lX3RvX2F0bWVsX2hsY2RjX3BsYW5l KHApOwo+ICAKPiAgCWlmIChwbGFuZS0+YmFzZS5mYikKPiAtCQlkcm1fZnJhbWVidWZmZXJfdW5y ZWZlcmVuY2UocGxhbmUtPmJhc2UuZmIpOwo+ICsJCWRybV9mcmFtZWJ1ZmZlcl9wdXQocGxhbmUt PmJhc2UuZmIpOwo+ICAKPiAgCWRybV9wbGFuZV9jbGVhbnVwKHApOwo+ICB9Cj4gQEAgLTk1OCw3 ICs5NTgsNyBAQCBzdGF0aWMgdm9pZCBhdG1lbF9obGNkY19wbGFuZV9yZXNldChzdHJ1Y3QgZHJt X3BsYW5lICpwKQo+ICAJCXN0YXRlID0gZHJtX3BsYW5lX3N0YXRlX3RvX2F0bWVsX2hsY2RjX3Bs YW5lX3N0YXRlKHAtPnN0YXRlKTsKPiAgCj4gIAkJaWYgKHN0YXRlLT5iYXNlLmZiKQo+IC0JCQlk cm1fZnJhbWVidWZmZXJfdW5yZWZlcmVuY2Uoc3RhdGUtPmJhc2UuZmIpOwo+ICsJCQlkcm1fZnJh bWVidWZmZXJfcHV0KHN0YXRlLT5iYXNlLmZiKTsKPiAgCj4gIAkJa2ZyZWUoc3RhdGUpOwo+ICAJ CXAtPnN0YXRlID0gTlVMTDsKPiBAQCAtOTk2LDcgKzk5Niw3IEBAIGF0bWVsX2hsY2RjX3BsYW5l X2F0b21pY19kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9wbGFuZSAqcCkKPiAgCX0KPiAgCj4g IAlpZiAoY29weS0+YmFzZS5mYikKPiAtCQlkcm1fZnJhbWVidWZmZXJfcmVmZXJlbmNlKGNvcHkt PmJhc2UuZmIpOwo+ICsJCWRybV9mcmFtZWJ1ZmZlcl9nZXQoY29weS0+YmFzZS5mYik7Cj4gIAo+ ICAJcmV0dXJuICZjb3B5LT5iYXNlOwo+ICB9Cj4gQEAgLTEwMTUsNyArMTAxNSw3IEBAIHN0YXRp YyB2b2lkIGF0bWVsX2hsY2RjX3BsYW5lX2F0b21pY19kZXN0cm95X3N0YXRlKHN0cnVjdCBkcm1f cGxhbmUgKnAsCj4gIAl9Cj4gIAo+ICAJaWYgKHMtPmZiKQo+IC0JCWRybV9mcmFtZWJ1ZmZlcl91 bnJlZmVyZW5jZShzLT5mYik7Cj4gKwkJZHJtX2ZyYW1lYnVmZmVyX3B1dChzLT5mYik7Cj4gIAo+ ICAJa2ZyZWUoc3RhdGUpOwo+ICB9CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK