From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247AbdHCOzm (ORCPT ); Thu, 3 Aug 2017 10:55:42 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:57032 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbdHCOzl (ORCPT ); Thu, 3 Aug 2017 10:55:41 -0400 Date: Thu, 3 Aug 2017 16:55:39 +0200 From: Boris Brezillon To: Cihangir Akturk Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/29] drm/atmel-hlcdc: switch to drm_*{get,put} helpers Message-ID: <20170803165539.647ecb05@bbrezillon> In-Reply-To: <20170803141050.16e78d78@bbrezillon> References: <1501761585-11757-1-git-send-email-cakturk@gmail.com> <1501761585-11757-6-git-send-email-cakturk@gmail.com> <20170803141050.16e78d78@bbrezillon> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Aug 2017 14:10:50 +0200 Boris Brezillon wrote: > On Thu, 3 Aug 2017 14:58:20 +0300 > Cihangir Akturk wrote: > > > drm_*_reference() and drm_*_unreference() functions are just > > compatibility alias for drm_*_get() and drm_*_put() adn should not be > > s/adn/and/ > > > used by new code. So convert all users of compatibility functions to use > > the new APIs. > > > > Signed-off-by: Cihangir Akturk > > Acked-by: Boris Brezillon Applied to drm-misc-next (as suggested by Daniel) after fixing the typo. Thanks, Boris > > > --- > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > > index 1124200..fc3f910 100644 > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > > @@ -809,7 +809,7 @@ static void atmel_hlcdc_plane_destroy(struct drm_plane *p) > > struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p); > > > > if (plane->base.fb) > > - drm_framebuffer_unreference(plane->base.fb); > > + drm_framebuffer_put(plane->base.fb); > > > > drm_plane_cleanup(p); > > } > > @@ -958,7 +958,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p) > > state = drm_plane_state_to_atmel_hlcdc_plane_state(p->state); > > > > if (state->base.fb) > > - drm_framebuffer_unreference(state->base.fb); > > + drm_framebuffer_put(state->base.fb); > > > > kfree(state); > > p->state = NULL; > > @@ -996,7 +996,7 @@ atmel_hlcdc_plane_atomic_duplicate_state(struct drm_plane *p) > > } > > > > if (copy->base.fb) > > - drm_framebuffer_reference(copy->base.fb); > > + drm_framebuffer_get(copy->base.fb); > > > > return ©->base; > > } > > @@ -1015,7 +1015,7 @@ static void atmel_hlcdc_plane_atomic_destroy_state(struct drm_plane *p, > > } > > > > if (s->fb) > > - drm_framebuffer_unreference(s->fb); > > + drm_framebuffer_put(s->fb); > > > > kfree(state); > > } >