From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] eventdev: fix missing includes
Date: Fri, 4 Aug 2017 16:05:24 +0530
Message-ID: <20170804103521.GA5144@jerin>
References: <20170804102035.4051-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0081.outbound.protection.outlook.com [104.47.33.81])
 by dpdk.org (Postfix) with ESMTP id 6FFD41F5
 for <dev@dpdk.org>; Fri,  4 Aug 2017 12:35:47 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20170804102035.4051-1-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri,  4 Aug 2017 12:20:35 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: [PATCH] eventdev: fix missing includes
> X-Mailer: git-send-email 2.13.2
> 
> The PCI helper file depends on some EAL definitions.
> Spotted with devtools/check-includes.sh:
> 	error: implicit declaration of function ‘rte_eal_process_type’
> 	error: ‘RTE_PROC_PRIMARY’ undeclared
> 	error: implicit declaration of function ‘rte_socket_id’
> 
> There was also this error because the inline keyword was missing:
> 	error: ‘rte_event_pmd_pci_probe’ defined but not used
> 
> Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  lib/Makefile                               | 2 +-
>  lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/Makefile b/lib/Makefile
> index 86caba17b..22962910d 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += librte_ip_frag
>  DEPDIRS-librte_ip_frag := librte_eal librte_mempool librte_mbuf librte_ether
>  DEPDIRS-librte_ip_frag += librte_hash
>  DIRS-$(CONFIG_RTE_LIBRTE_GRO) += librte_gro
> -DEPDIRS-librte_gro := librte_eal librte_mbuf librte_ether librte_net
> +DEPDIRS-librte_gro := librte_eal librte_mbuf

Looks like unrelated change. Right?