From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] mark pseudo user as deleted instead of removing them
Date: Fri, 4 Aug 2017 21:12:18 +0200 [thread overview]
Message-ID: <20170804191216.x35bhjg6uskvzzu3@ltop.local> (raw)
In-Reply-To: <CANeU7Q=WRs47kXndEj6bPTJFUoVH211pAKwv3aV0Sx87oxZasA@mail.gmail.com>
On Fri, Aug 04, 2017 at 02:19:54PM -0400, Christopher Li wrote:
> First thing first, I don't have strong reason to object this patch.
> So it can be merge into RC5.
OK, good.
> > I would be fine with this patch (but it would need a bit more testing).
> > I would be fine with no patch at all.
> > I would be ok with your patch (the one with list duplication) but I
> > think it's not a good one, even as a temporary bandaid (for the reasons
> > I explained the first time I commented on it).
>
> Fair enough. Yes. I can apply it. The question is, do you want to remove
> the duplicate set of API? (by testing "list->rm").
Sure but I think I will even not test anything at all.
For the others lists we don't touch to the ->rm field and
we have the guarantee that it will be initialized to zero
so adding nr or adding (nr - rm) will be the same anyway
(and doing the substraction certainly won't cost more than
adding a test).
-- Luc
next prev parent reply other threads:[~2017-08-04 19:12 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 15:32 [PATCH RFC] Let pseudo->users loop on duplicate version of list Christopher Li
2017-07-11 20:53 ` Christopher Li
2017-07-11 21:04 ` Dibyendu Majumdar
2017-07-12 5:29 ` Christopher Li
2017-07-12 15:56 ` Dibyendu Majumdar
2017-07-12 17:03 ` Christopher Li
2017-07-12 18:05 ` Dibyendu Majumdar
2017-07-13 5:27 ` Christopher Li
2017-07-19 21:14 ` Luc Van Oostenryck
2017-07-19 21:42 ` Christopher Li
2017-07-19 22:51 ` Luc Van Oostenryck
2017-07-20 2:34 ` Christopher Li
2017-08-02 23:44 ` Luc Van Oostenryck
2017-08-03 0:50 ` Christopher Li
2017-08-03 10:18 ` Luc Van Oostenryck
2017-08-03 23:48 ` Christopher Li
2017-08-04 0:41 ` Luc Van Oostenryck
2017-08-04 2:22 ` Christopher Li
2017-08-04 10:38 ` Luc Van Oostenryck
2017-08-04 14:48 ` Christopher Li
2017-08-04 16:58 ` Luc Van Oostenryck
[not found] ` <20170804002230.5047-1-luc.vanoostenryck@gmail.com>
2017-08-04 14:54 ` Fwd: [PATCH] mark pseudo user as deleted instead of removing them Christopher Li
2017-08-04 15:29 ` Christopher Li
2017-08-04 15:58 ` Luc Van Oostenryck
2017-08-04 18:19 ` Christopher Li
2017-08-04 19:12 ` Luc Van Oostenryck [this message]
2017-08-04 19:24 ` Christopher Li
2017-08-04 20:09 ` [PATCH 0/4] fix list corruption with recursive remove_usage() Luc Van Oostenryck
2017-08-04 20:09 ` [PATCH 1/4] ptrlist: add a counter for the number of removed elemnets Luc Van Oostenryck
2017-08-04 20:09 ` [PATCH 2/4] ptrlist: adjust ptr_list_size for the new ->rm field Luc Van Oostenryck
2017-08-04 20:09 ` [PATCH 3/4] ptrlist: add MARK_CURRENT_DELETED Luc Van Oostenryck
2017-08-04 20:09 ` [PATCH 4/4] mark pseudo users as deleted instead of removing them Luc Van Oostenryck
2017-08-04 20:17 ` Christopher Li
2017-08-04 20:18 ` Christopher Li
2017-08-04 20:34 ` Luc Van Oostenryck
2017-08-04 20:48 ` Christopher Li
2017-08-04 21:03 ` Luc Van Oostenryck
2017-08-04 21:14 ` Christopher Li
2017-08-04 21:34 ` Luc Van Oostenryck
2017-08-04 16:54 ` [PATCH] mark pseudo user " Linus Torvalds
2017-08-04 18:33 ` Christopher Li
2017-08-04 20:08 ` Christopher Li
2017-08-04 20:37 ` Christopher Li
2017-07-13 12:23 ` [PATCH RFC] Let pseudo->users loop on duplicate version of list Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804191216.x35bhjg6uskvzzu3@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.