From mboxrd@z Thu Jan  1 00:00:00 1970
From: Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH v2 13/20] lpfc: Fix MRQ > 1 context list handling
Date: Mon, 7 Aug 2017 11:02:09 +0200
Message-ID: <20170807090209.GP3978@linux-x5ow.site>
References: <20170805004731.1335-1-jsmart2021@gmail.com>
 <20170805004731.1335-14-jsmart2021@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <linux-scsi-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:43813 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752299AbdHGJCN (ORCPT <rfc822;linux-scsi@vger.kernel.org>);
        Mon, 7 Aug 2017 05:02:13 -0400
Content-Disposition: inline
In-Reply-To: <20170805004731.1335-14-jsmart2021@gmail.com>
Sender: linux-scsi-owner@vger.kernel.org
List-Id: linux-scsi@vger.kernel.org
To: James Smart <jsmart2021@gmail.com>
Cc: linux-scsi@vger.kernel.org, Dick Kennedy <dick.kennedy@broadcom.com>, James Smart <james.smart@broadcom.com>

On Fri, Aug 04, 2017 at 05:47:24PM -0700, James Smart wrote:
> +				tgtp = (struct lpfc_nvmet_tgtport *)
> +					phba->targetport->private;

Please don't case void pointers.

[...]

> +			list_splice(&get_infop->nvmet_ctx_list,
> +				    &current_infop->nvmet_ctx_list);
> +			INIT_LIST_HEAD(&get_infop->nvmet_ctx_list);

			list_splice_init(&get_infop->nvmet_ctx_list,
					 &current_infop->nvmet_ctx_list);


-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850