From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: NVDIMM-ML <linux-nvdimm@lists.01.org>
Subject: Re: [RFC/Patch 1/5] Remove old enum definition of "Translate Spa"
Date: Mon, 07 Aug 2017 09:03:13 +0900 [thread overview]
Message-ID: <20170807090309.F95F.E1E9C6FF@jp.fujitsu.com> (raw)
In-Reply-To: <CAPcyv4g7cWsUESUg__RmTGQoV4L+ePM=fzbZdcpiaTEH_bhM0w@mail.gmail.com>
> On Fri, Aug 4, 2017 at 2:06 AM, Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> >
> > Remove old enum definition of "Translate Spa".
> >
> > Translate SPA becomes standard specification on ACPI 6.2,
> > but current definition is likely temporary.
> > So it is removed.
> >
> > Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
> >
> >
> > ---
> > drivers/acpi/nfit/core.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index 19182d0..5334755 100644
> > --- a/drivers/acpi/nfit/core.c
> > +++ b/drivers/acpi/nfit/core.c
> > @@ -1626,7 +1626,6 @@ static int acpi_nfit_register_dimms(struct acpi_nfit_desc *acpi_desc)
> > * these commands.
> > */
> > enum nfit_aux_cmds {
> > - NFIT_CMD_TRANSLATE_SPA = 5,
> > NFIT_CMD_ARS_INJECT_SET = 7,
> > NFIT_CMD_ARS_INJECT_CLEAR = 8,
> > NFIT_CMD_ARS_INJECT_GET = 9,
> > @@ -1655,7 +1654,6 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc)
> > (1 << ND_CMD_ARS_START) |
> > (1 << ND_CMD_ARS_STATUS) |
> > (1 << ND_CMD_CLEAR_ERROR) |
> > - (1 << NFIT_CMD_TRANSLATE_SPA) |
> > (1 << NFIT_CMD_ARS_INJECT_SET) |
> > (1 << NFIT_CMD_ARS_INJECT_CLEAR) |
> > (1 << NFIT_CMD_ARS_INJECT_GET);
>
> Hmm, those definitions are brand new as of the 4.13 kernel, see commit
> 7db5bb33add5 "libnvdimm, acpi, nfit: Add bus level dsm mask for pass
> thru". What's going on here is that we stopped defining new ND_CMD
> numbers for each new DSM that is added to the specification. Instead,
> we use the ND_CMD_CALL mechanism to wrap these new command payloads
> and pass them through to the BIOS. So, these definitions are needed to
> allow that passthrough mechanism to work.
Ah, Ok.
I'll check it.
Thanks,
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-08-07 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 9:02 [RFC/Patch 0/5] ndctl list show broken nvdimm info Yasunori Goto
2017-08-04 9:06 ` [RFC/Patch 1/5] Remove old enum definition of "Translate Spa" Yasunori Goto
2017-08-04 23:09 ` Dan Williams
2017-08-07 0:03 ` Yasunori Goto [this message]
2017-08-04 9:08 ` [RFC/Patch 2/5] Support Translate SPA for NVDIMM Root Device Yasunori Goto
2017-08-04 23:30 ` Dan Williams
2017-08-04 9:10 ` [RFC/Patch 3/5] nfit_test supports Translate SPA Yasunori Goto
2017-08-04 9:12 ` [RFC/Patch 4/5] libndctl Make interfaces to use " Yasunori Goto
2017-08-05 0:03 ` Dan Williams
2017-08-07 0:08 ` Yasunori Goto
2017-08-04 9:13 ` [RFC/Patch 5/5] ndctl: show dimm's name which has badblock by ndctl list command Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807090309.F95F.E1E9C6FF@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.