From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbdHGJvx (ORCPT ); Mon, 7 Aug 2017 05:51:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49144 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbdHGJvw (ORCPT ); Mon, 7 Aug 2017 05:51:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 49DE0FF4C Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Mon, 7 Aug 2017 11:51:50 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v1 09/15] perf, tools: Dedup events in expression parsing Message-ID: <20170807095150.GA13591@krava> References: <20170724234015.5165-1-andi@firstfloor.org> <20170724234015.5165-10-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170724234015.5165-10-andi@firstfloor.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 07 Aug 2017 09:51:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2017 at 04:40:09PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Avoid adding redundant events while parsing an expression. > When we add an "other" event check first if it already exists. hi, got this: [jolsa@krava perf]$ ./perf test expr -v 6: Simple expression parser : --- start --- test child forked, pid 13589 syntax error FAILED tests/expr.c:53 find other test child finished with -1 ---- end ---- Simple expression parser: FAILED! jirka