All of lore.kernel.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] arm64: neon: Remove support for nested or hardirq kernel-mode NEON
Date: Mon, 7 Aug 2017 12:35:28 +0100	[thread overview]
Message-ID: <20170807113528.yklmm7lqoqxkyy3b@armageddon.cambridge.arm.com> (raw)
In-Reply-To: <CAKv+Gu_aVPiDtmQiq_3rUVpm23jBMpRGhh8uVw3evceEbO6cag@mail.gmail.com>

On Mon, Aug 07, 2017 at 12:31:47PM +0100, Ard Biesheuvel wrote:
> On 7 August 2017 at 12:23, Catalin Marinas <catalin.marinas@arm.com> wrote:
> > On Thu, Aug 03, 2017 at 05:23:23PM +0100, Dave P Martin wrote:
> >> diff --git a/arch/arm64/include/asm/simd.h b/arch/arm64/include/asm/simd.h
> >> index 96959b5..5a1a927 100644
> >> --- a/arch/arm64/include/asm/simd.h
> >> +++ b/arch/arm64/include/asm/simd.h
> >> @@ -9,15 +9,46 @@
> >>  #ifndef __ASM_SIMD_H
> >>  #define __ASM_SIMD_H
> >>
> >> +#include <linux/compiler.h>
> >> +#include <linux/percpu.h>
> >> +#include <linux/preempt.h>
> >>  #include <linux/types.h>
> >>
> >> +#ifdef CONFIG_KERNEL_MODE_NEON
> >> +
> >> +DECLARE_PER_CPU(bool, kernel_neon_busy);
> > [...]
> >> @@ -233,49 +254,69 @@ void fpsimd_flush_task_state(struct task_struct *t)
> >>
> >>  #ifdef CONFIG_KERNEL_MODE_NEON
> >>
> >> -static DEFINE_PER_CPU(struct fpsimd_partial_state, hardirq_fpsimdstate);
> >> -static DEFINE_PER_CPU(struct fpsimd_partial_state, softirq_fpsimdstate);
> >> +DEFINE_PER_CPU(bool, kernel_neon_busy);
> >
> > This variable needs to be exported to modules (allmodconfig fails to
> > build with these patches). Any preference for GPL vs non-GPL export?
> 
> It should match whatever kernel_neon_begin|end use.

Ah, good point. I'll drop the _GPL part.

-- 
Catalin

  reply	other threads:[~2017-08-07 11:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 16:23 [PATCH 0/5] Simplify kernel-mode NEON Dave Martin
2017-08-03 16:23 ` [PATCH 1/5] arm64: neon: replace generic definition of may_use_simd() Dave Martin
2017-08-03 16:23 ` [PATCH 2/5] arm64: neon: Add missing header guard in <asm/neon.h> Dave Martin
2017-08-03 16:23 ` [PATCH 3/5] arm64: fpsimd: Consistently use __this_cpu_ ops where appropriate Dave Martin
2017-08-03 16:23 ` [PATCH 4/5] arm64: neon: Allow EFI runtime services to use FPSIMD in irq context Dave Martin
2017-08-03 16:23 ` [PATCH 5/5] arm64: neon: Remove support for nested or hardirq kernel-mode NEON Dave Martin
2017-08-07 11:23   ` Catalin Marinas
2017-08-07 11:31     ` Ard Biesheuvel
2017-08-07 11:35       ` Catalin Marinas [this message]
2017-08-04 12:08 ` [PATCH 0/5] Simplify " Catalin Marinas
2017-08-04 12:22   ` Catalin Marinas
2017-08-04 12:25     ` Ard Biesheuvel
2017-08-04 12:41       ` Dave P Martin
2017-08-04 13:12       ` Catalin Marinas
2017-08-04 13:21         ` Ard Biesheuvel
2017-08-04 13:26           ` Dave P Martin
2017-08-04 14:05             ` Catalin Marinas
2017-08-04 14:25               ` Dave Martin
2017-08-04 14:50                 ` Catalin Marinas
2017-08-04 14:00           ` Catalin Marinas
2017-08-04 14:04             ` Ard Biesheuvel
2017-08-04 13:22         ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170807113528.yklmm7lqoqxkyy3b@armageddon.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.