From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/3] lib/igt_aux: Export statistics of signal helper.
Date: Mon, 7 Aug 2017 17:51:03 +0200 [thread overview]
Message-ID: <20170807155103.y2j73xsd4szxp2bl@phenom.ffwll.local> (raw)
In-Reply-To: <150209999539.23563.3718944947970344088@mail.alporthouse.com>
On Mon, Aug 07, 2017 at 10:59:55AM +0100, Chris Wilson wrote:
> Quoting Maarten Lankhorst (2017-08-07 10:45:38)
> > Op 04-08-17 om 09:50 schreef Chris Wilson:
> > > Quoting Maarten Lankhorst (2017-08-02 11:29:17)
> > >> Export 2 functions, igt_signal_helper_get_num and
> > >> igt_signal_helper_get_hz.
> > >>
> > >> This will allow tests to measure how much time in a test was spent
> > >> in a uninterruptible state, which is useful when testing whether
> > >> certain ioctl's can be interrupted or not.
> > > Use sig_ioctl, the purpose of that wrapper is to measure whether or not it
> > > was interrupted. Refine it to suit your purposes, it is the surgical
> > > scalpel compared to the shotgun of signal_helper.
> > > -Chris
> >
> > I've been using the igt display helpers now so I don't have to worry about the ioctl's. Using sig_ioctl would mean having to perform the ioctl's myself, and that makes the code a lot more verbose..
>
> You know that we igt uses igt_ioctl so that we can switch the ioctl
> wrapper. What you have here is sig_ioctl so rather than painting the
> shotgun signal helper a different colour, use the interface that
> actually supports what you have in mind.
Might be good to spicy the docs up a bit to make this clearer, maybe even
with an example and some links between the different bits? Mika/Maarten?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-08-07 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 10:29 [PATCH i-g-t 1/3] lib/igt_aux: Export statistics of signal helper Maarten Lankhorst
2017-08-02 10:29 ` [PATCH i-g-t 2/3] lib/igt_kms: Remove vblank wait after plane update Maarten Lankhorst
2017-08-04 8:07 ` Mika Kahola
2017-08-07 8:42 ` Maarten Lankhorst
2017-08-08 9:30 ` Mika Kahola
2017-08-02 10:29 ` [PATCH i-g-t 3/3] tests: Add kms_atomic_interruptible test Maarten Lankhorst
2017-08-04 7:50 ` Mika Kahola
2017-08-07 8:47 ` Maarten Lankhorst
2017-08-04 7:46 ` [PATCH i-g-t 1/3] lib/igt_aux: Export statistics of signal helper Mika Kahola
2017-08-04 7:50 ` Chris Wilson
2017-08-07 9:45 ` Maarten Lankhorst
2017-08-07 9:59 ` Chris Wilson
2017-08-07 15:51 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807155103.y2j73xsd4szxp2bl@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.