From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 01/17] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Date: Tue, 8 Aug 2017 12:03:19 +0100 Message-ID: <20170808110319.ssagukhfp72r5vys@dell> References: <1501235239-11145-1-git-send-email-rf@opensource.wolfsonmicro.com> <1501235239-11145-2-git-send-email-rf@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1501235239-11145-2-git-send-email-rf@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Richard Fitzgerald Cc: gnurou@gmail.com, alsa-devel@alsa-project.org, jason@lakedaemon.net, devicetree@vger.kernel.org, linus.walleij@linaro.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-gpio@vger.kernel.org, broonie@kernel.org, tglx@linutronix.de List-Id: linux-gpio@vger.kernel.org T24gRnJpLCAyOCBKdWwgMjAxNywgUmljaGFyZCBGaXR6Z2VyYWxkIHdyb3RlOgoKPiBUaGlzIHBh dGNoIGFkZHMgYSBoZWFkZXIgZmlsZSBvZiByZWdpc3RlciBkZWZpbml0aW9ucyBmb3IgQ2lycnVz Cj4gTG9naWMgIk1hZGVyYSIgY2xhc3MgY29kZWNzLiBUaGVzZSBjb2RlY3MgYXJlIGFsbCBiYXNl ZCBvZmYgYSBjb21tb24KPiBzZXQgb2YgaGFyZHdhcmUgSVAgc28gaGF2ZSBhIGNvbW1vbiByZWdp c3RlciBtYXAgKHdpdGggYSBmZXcgbWlub3IKPiBkZXZpY2UtdG8tZGV2aWNlIHZhcmlhdGlvbnMp Lgo+IAo+IFRoZSByZWdpc3RlcnMuaCBmaWxlIGlzIHRvb2wtZ2VuZXJhdGVkIGRpcmVjdGx5IGZy b20gdGhlIGhhcmR3YXJlIGRlc2lnbgo+IGJ1dCBoYXMgYmVlbiBtYW51YWxseSBzdHJpcHBlZCBk b3duIHRvIHJlZHVjZSBzaXplIChmdWxsIHJlZ2lzdGVyCj4gbWFwIGlzID40NDAwMCBsaW5lcyku IEFsbCBuYW1lcyBhcmUga2VwdCB0aGUgc2FtZSBhcyBkYXRhc2hlZXQgbmFtZXMKPiBzbyB0aGF0 IHRoZXkgY2FuIGJlIGNyb3NzLXJlZmVyZW5jZWQgYmV0d2VlbiBzb3VyY2UgYW5kIGRhdGFzaGVl dCB3aXRob3V0Cj4gY29uZnVzaW9uLgo+IAo+IFRoZSByZWdpc3RlciBtYXAgbGF5b3V0IGlzIGtl cHQgZnVsbHktZGVmaW5lZCByYXRoZXIgdGhhbiBmYWN0b3JlZCBpbnRvCj4gbWFjcm9zIGFuZC9v ciBibG9jay1pbmRleGluZyBjb2RlLiBUaGUgbWFqb3IgcmVhc29ucyBmb3IgdGhpcyBhcmU6Cj4g Cj4gIC0gIzEgaXMgdGhhdCBpdCBtYWtlcyB0aGUgc291cmNlIGhpZ2hseSBncmVwcGFibGUsIHdo aWNoIGlzIGltcG9ydGFudC4KPiAgICAiV2hhdCBkb2VzIHRoZSBkcml2ZXIgZG8gd2l0aCByZWdp c3RlciBiaXRzIFhZWiIgb3IgIldoZXJlIGRvZXMgaXQgdXNlCj4gICAgcmVnaXN0ZXIgYml0cyBY WVoiIGFyZSBjb21tb25seSB0eXBlcyBvZiBxdWVzdGlvbnMuIFRoZXNlIGNhbiBiZSBxdWlja2x5 Cj4gICAgYW5zd2VyZWQgYnkgYSBncmVwLiBTcXVhc2hpbmcgZGVmaW5pdGlvbnMgaW50byBnZW5l cmF0b3IgbWFjcm9zIG9yIGJsb2NrLQo+ICAgIGluZGV4aW5nIGNvZGUgaXMgYSB3YXkgb2YgZGVm ZWF0aW5nIGdyZXAuCj4gCj4gIC0gbW9zdCBvZiB0aGUgcmVnaXN0ZXIgZGVmaW5pdGlvbnMgYXJl IHVzZWQgaW4gdGFibGVzLCBzbyBhIGNvbnN0YW50IHZhbHVlCj4gICAgaXMgcmVxdWlyZWQuIFVz aW5nIGdlbmVyYXRvciBtYWNyb3MgbWFrZSB0aGUgdGFibGUgZGVmaW5pdGlvbiBjbHVua3kgYW5k Cj4gICAgb2JzY3VyZS4KPiAKPiAgLSB0aGUgY29kZSBpcyBjbGVhcmVyIHdoZW4gaXQncyB0aGVy ZSBpbiB0aGUgc291cmNlIGV4YWN0bHkgd2hhdCByZWdpc3Rlcgo+ICAgIGFuZCBmaWVsZCBpdCBp cyB1c2luZwo+IAo+ICAtIGl0IGlzIGVhc2llciB0byBkaWZmIHRoZSByZWdpc3RlciBtYXAgb2Yg YSBuZXcgKHVuc3VwcG9ydGVkKSBjb2RlYyBhZ2FpbnN0Cj4gICAgd2hhdCBpcyBhbHJlYWR5IHN1 cHBvcnRlZCBhbmQgbWVyZ2UgaW4gZGlmZmVyZW5jZXMKPiAKPiAgLSBpdCBtYWtlcyB0aGUgcmVn aXN0ZXIgbWFwIGF2YWlsYWJsZSBpbiBzb3VyY2UgZm9yIG1haW50ZW5hbmNlL2RlYnVnZ2luZwo+ ICAgIGluc3RlYWQgb2YgaGF2aW5nIHRvIHJlZmVyIGJhY2sgdG8gdGhlIGRhdGFzaGVldCBmb3Ig YSByZWdpc3RlciBtYXAKPiAKPiBTaWduZWQtb2ZmLWJ5OiBSaWNoYXJkIEZpdHpnZXJhbGQgPHJm QG9wZW5zb3VyY2Uud29sZnNvbm1pY3JvLmNvbT4KPiAtLS0KPiBDaGFuZ2VzIHNpbmNlIFYzOgo+ IC0gTWFudWFsbHkgc3RyaXBwZWQgb3V0IGEgbG90IG1vcmUgc3R1ZmYsIGRlZmluZXMgd2UncmUg bm90IHVzaW5nIHJpZ2h0IG5vdwo+IC0gQWRkZWQgdGhlIGV4cGxhbmF0aW9uIGFib3ZlIHRvIHRo ZSBjb21taXQgbWVzc2FnZSBvZiB3aHkgd2UgZGVmaW5lIHRoZQo+ICAgbWFwIGVmZmVjdGl2ZWx5 IHZlcmJhdGltCj4gCj4gIE1BSU5UQUlORVJTICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg MTAgKwo+ICBpbmNsdWRlL2xpbnV4L21mZC9tYWRlcmEvcmVnaXN0ZXJzLmggfCAzOTg3ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAzOTk3IGlu c2VydGlvbnMoKykKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbWZkL21hZGVy YS9yZWdpc3RlcnMuaAoKRm9yIG15IG93biByZWZlcmVuY2U6CiAgQWNrZWQtZm9yLU1GRC1ieTog TGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNU TWljcm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNv dXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0 dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0 cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbdHHLDZ (ORCPT ); Tue, 8 Aug 2017 07:03:25 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36149 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbdHHLDX (ORCPT ); Tue, 8 Aug 2017 07:03:23 -0400 Date: Tue, 8 Aug 2017 12:03:19 +0100 From: Lee Jones To: Richard Fitzgerald Cc: broonie@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com, robh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 01/17] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Message-ID: <20170808110319.ssagukhfp72r5vys@dell> References: <1501235239-11145-1-git-send-email-rf@opensource.wolfsonmicro.com> <1501235239-11145-2-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1501235239-11145-2-git-send-email-rf@opensource.wolfsonmicro.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Jul 2017, Richard Fitzgerald wrote: > This patch adds a header file of register definitions for Cirrus > Logic "Madera" class codecs. These codecs are all based off a common > set of hardware IP so have a common register map (with a few minor > device-to-device variations). > > The registers.h file is tool-generated directly from the hardware design > but has been manually stripped down to reduce size (full register > map is >44000 lines). All names are kept the same as datasheet names > so that they can be cross-referenced between source and datasheet without > confusion. > > The register map layout is kept fully-defined rather than factored into > macros and/or block-indexing code. The major reasons for this are: > > - #1 is that it makes the source highly greppable, which is important. > "What does the driver do with register bits XYZ" or "Where does it use > register bits XYZ" are commonly types of questions. These can be quickly > answered by a grep. Squashing definitions into generator macros or block- > indexing code is a way of defeating grep. > > - most of the register definitions are used in tables, so a constant value > is required. Using generator macros make the table definition clunky and > obscure. > > - the code is clearer when it's there in the source exactly what register > and field it is using > > - it is easier to diff the register map of a new (unsupported) codec against > what is already supported and merge in differences > > - it makes the register map available in source for maintenance/debugging > instead of having to refer back to the datasheet for a register map > > Signed-off-by: Richard Fitzgerald > --- > Changes since V3: > - Manually stripped out a lot more stuff, defines we're not using right now > - Added the explanation above to the commit message of why we define the > map effectively verbatim > > MAINTAINERS | 10 + > include/linux/mfd/madera/registers.h | 3987 ++++++++++++++++++++++++++++++++++ > 2 files changed, 3997 insertions(+) > create mode 100644 include/linux/mfd/madera/registers.h For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog