From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Eric Blake <eblake@redhat.com>,
jsnow@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] iotests: fix 185
Date: Tue, 8 Aug 2017 17:16:00 +0200 [thread overview]
Message-ID: <20170808151600.GN4850@dhcp-200-186.str.redhat.com> (raw)
In-Reply-To: <2983bfe2-0646-2a50-0025-0211c4725f63@virtuozzo.com>
Am 08.08.2017 um 17:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 08.08.2017 18:07, Eric Blake wrote:
> > On 08/08/2017 04:04 AM, Vladimir Sementsov-Ogievskiy wrote:
> >
> > > > > > Throttling "guaranties" that there will not be more than one
> > > > > > request. But
> > > > > > what prevent less than one, i.e. zero, like in my reproduction?
> > > > > Yes, I understand. Can we somehow make sure that at least one iteration
> > > > > is made? I'd really like to keep the functional test for block job
> > > > > throttling. I suppose a simple 'sleep 0.1' would do the trick, though
> > > > > it's not very clean.
> > > > >
> > > > > Kevin
> > > >
> > > > I've started with 'sleep 0.5', now there are >100 successful
> > > > iterations... The other way is to check in test that there was 0 or 1
> > > > requests, but for this it looks better to rewrite it in python.
> > > >
> > > >
> > > is sleep for ms portable?
> > Sadly, sub-second sleep is a GNU coreutils feature; I suspect the BSD
> > machines may fail to parse it. (Of course, we could do some sort of
> > 'sleep $SMALL', where $SMALL is 0.5 if sleep supports it, and 1 otherwise).
> >
> sleep for 1 second may lead to more then one request done before qemu quite.
_supported_os Linux
So do we really care about portability? And are all the other test cases
working on the BSDs?
Kevin
next prev parent reply other threads:[~2017-08-08 15:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 14:16 [Qemu-devel] [PATCH] iotests: fix 185 Vladimir Sementsov-Ogievskiy
2017-08-07 14:29 ` [Qemu-devel] [PATCH for-2.10] " Eric Blake
2017-08-07 15:46 ` Vladimir Sementsov-Ogievskiy
2017-08-07 15:57 ` Vladimir Sementsov-Ogievskiy
2017-08-07 16:19 ` Vladimir Sementsov-Ogievskiy
2017-08-07 15:57 ` [Qemu-devel] [PATCH] " Kevin Wolf
2017-08-08 8:42 ` Vladimir Sementsov-Ogievskiy
2017-08-08 8:53 ` Kevin Wolf
2017-08-08 9:04 ` Vladimir Sementsov-Ogievskiy
2017-08-08 9:04 ` Vladimir Sementsov-Ogievskiy
2017-08-08 10:18 ` Vladimir Sementsov-Ogievskiy
2017-08-08 15:07 ` Eric Blake
2017-08-08 15:10 ` Vladimir Sementsov-Ogievskiy
2017-08-08 15:16 ` Kevin Wolf [this message]
2017-08-08 17:27 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808151600.GN4850@dhcp-200-186.str.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.