From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752401AbdHHQ3s (ORCPT ); Tue, 8 Aug 2017 12:29:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44776 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbdHHQ3q (ORCPT ); Tue, 8 Aug 2017 12:29:46 -0400 Date: Tue, 8 Aug 2017 09:29:45 -0700 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Laurent Pinchart , thongsyho , Nhan Nguyen Subject: Re: [PATCH 4.4 17/91] drm: rcar-du: Simplify and fix probe error handling Message-ID: <20170808162945.GA4660@kroah.com> References: <20170804231555.678888089@linuxfoundation.org> <20170804231556.633658434@linuxfoundation.org> <1502119078.2047.23.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502119078.2047.23.camel@codethink.co.uk> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 07, 2017 at 04:17:58PM +0100, Ben Hutchings wrote: > On Fri, 2017-08-04 at 16:15 -0700, Greg Kroah-Hartman wrote: > [...] > > @@ -291,6 +290,15 @@ static int rcar_du_probe(struct platform > > rcdu->dev = &pdev->dev; > > rcdu->info = of_match_device(rcar_du_of_table, rcdu->dev)->data; > > > > + platform_set_drvdata(pdev, rcdu); > > + > > + /* I/O resources */ > > + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem); > > + if (IS_ERR(rcdu->mmio)) > > + ret = PTR_ERR(rcdu->mmio); > [...] > > Last line above should be: > > return PTR_ERR(rcdu->mmio); > > This is an error introduced in the backport, not the upstream commit. Good catch, thanks for this, I've now fixed it up. greg k-h