From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753856AbdHIQSv (ORCPT ); Wed, 9 Aug 2017 12:18:51 -0400 Received: from mga14.intel.com ([192.55.52.115]:2473 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752741AbdHIQSu (ORCPT ); Wed, 9 Aug 2017 12:18:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,348,1498546800"; d="scan'208";a="1203809155" Date: Wed, 9 Aug 2017 09:18:49 -0700 From: Matt Roper To: Jean Delvare Cc: intel-gfx@lists.freedesktop.org, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2) Message-ID: <20170809161849.GA4496@mdroper-desk.amr.corp.intel.com> References: <20160308133713.24e0b71a@endymion> <1457461957-23029-1-git-send-email-matthew.d.roper@intel.com> <20160317151820.28fe70da@endymion> <20170731103605.1810e281@endymion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170731103605.1810e281@endymion> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 31, 2017 at 10:36:05AM +0200, Jean Delvare wrote: > Hi Matt, Mauro, > > On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote: > > On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote: > > > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for > > > decoding DMI memory device entries. Move the structure definition to > > > dmi.h so that it can be shared between those drivers and also other > > > parts of the kernel; the i915 graphics driver is going to need to use > > > this structure soon as well. As part of this move we rename the > > > structure s/memdev_dmi_entry/dmi_entry_memdev/ to ensure it has a proper > > > 'dmi' prefix. > > > > > > v2: > > > - Rename structure to dmi_entry_memdev. (Jean) > > > - Use __packed instead of __attribute__((__packed__)) for consistency > > > with the rest of the dmi.h header. (Jean) > > > > Looks better. (...) > > What happened to this patch? I never received v3. Is it sill needed? We ended up going a different direction in the graphics driver and wound up not needing access to this structure. If there's still interest in the general refactoring here, let me know and I can incorporate your last feedback and respin a v3. Matt > -- > Jean Delvare > SUSE L3 Support -- Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2) Date: Wed, 9 Aug 2017 09:18:49 -0700 Message-ID: <20170809161849.GA4496@mdroper-desk.amr.corp.intel.com> References: <20160308133713.24e0b71a@endymion> <1457461957-23029-1-git-send-email-matthew.d.roper@intel.com> <20160317151820.28fe70da@endymion> <20170731103605.1810e281@endymion> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B4DB89D46 for ; Wed, 9 Aug 2017 16:18:51 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170731103605.1810e281@endymion> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jean Delvare Cc: intel-gfx@lists.freedesktop.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdWwgMzEsIDIwMTcgYXQgMTA6MzY6MDVBTSArMDIwMCwgSmVhbiBEZWx2YXJlIHdy b3RlOgo+IEhpIE1hdHQsIE1hdXJvLAo+IAo+IE9uIFRodSwgMTcgTWFyIDIwMTYgMTU6MTg6MjAg KzAxMDAsIEplYW4gRGVsdmFyZSB3cm90ZToKPiA+IE9uIFR1ZSwgIDggTWFyIDIwMTYgMTA6MzI6 MzcgLTA4MDAsIE1hdHQgUm9wZXIgd3JvdGU6Cj4gPiA+IEEgY291cGxlIG9mIHRoZSBFREFDIGRy aXZlcnMgaGF2ZSBhIG5pY2UgbWVtZGV2X2RtaV9lbnRyeSBzdHJ1Y3R1cmUgZm9yCj4gPiA+IGRl Y29kaW5nIERNSSBtZW1vcnkgZGV2aWNlIGVudHJpZXMuICBNb3ZlIHRoZSBzdHJ1Y3R1cmUgZGVm aW5pdGlvbiB0bwo+ID4gPiBkbWkuaCBzbyB0aGF0IGl0IGNhbiBiZSBzaGFyZWQgYmV0d2VlbiB0 aG9zZSBkcml2ZXJzIGFuZCBhbHNvIG90aGVyCj4gPiA+IHBhcnRzIG9mIHRoZSBrZXJuZWw7IHRo ZSBpOTE1IGdyYXBoaWNzIGRyaXZlciBpcyBnb2luZyB0byBuZWVkIHRvIHVzZQo+ID4gPiB0aGlz IHN0cnVjdHVyZSBzb29uIGFzIHdlbGwuICBBcyBwYXJ0IG9mIHRoaXMgbW92ZSB3ZSByZW5hbWUg dGhlCj4gPiA+IHN0cnVjdHVyZSBzL21lbWRldl9kbWlfZW50cnkvZG1pX2VudHJ5X21lbWRldi8g dG8gZW5zdXJlIGl0IGhhcyBhIHByb3Blcgo+ID4gPiAnZG1pJyBwcmVmaXguCj4gPiA+IAo+ID4g PiB2MjoKPiA+ID4gIC0gUmVuYW1lIHN0cnVjdHVyZSB0byBkbWlfZW50cnlfbWVtZGV2LiAgKEpl YW4pCj4gPiA+ICAtIFVzZSBfX3BhY2tlZCBpbnN0ZWFkIG9mIF9fYXR0cmlidXRlX18oKF9fcGFj a2VkX18pKSBmb3IgY29uc2lzdGVuY3kKPiA+ID4gICAgd2l0aCB0aGUgcmVzdCBvZiB0aGUgZG1p LmggaGVhZGVyLiAgKEplYW4pICAKPiA+IAo+ID4gTG9va3MgYmV0dGVyLiAoLi4uKQo+IAo+IFdo YXQgaGFwcGVuZWQgdG8gdGhpcyBwYXRjaD8gSSBuZXZlciByZWNlaXZlZCB2My4gSXMgaXQgc2ls bCBuZWVkZWQ/CgpXZSBlbmRlZCB1cCBnb2luZyBhIGRpZmZlcmVudCBkaXJlY3Rpb24gaW4gdGhl IGdyYXBoaWNzIGRyaXZlciBhbmQgd291bmQKdXAgbm90IG5lZWRpbmcgYWNjZXNzIHRvIHRoaXMg c3RydWN0dXJlLiAgSWYgdGhlcmUncyBzdGlsbCBpbnRlcmVzdCBpbgp0aGUgZ2VuZXJhbCByZWZh Y3RvcmluZyBoZXJlLCBsZXQgbWUga25vdyBhbmQgSSBjYW4gaW5jb3Jwb3JhdGUgeW91cgpsYXN0 IGZlZWRiYWNrIGFuZCByZXNwaW4gYSB2My4KCgpNYXR0Cgo+IC0tIAo+IEplYW4gRGVsdmFyZQo+ IFNVU0UgTDMgU3VwcG9ydAoKLS0gCk1hdHQgUm9wZXIKR3JhcGhpY3MgU29mdHdhcmUgRW5naW5l ZXIKSW9URyBQbGF0Zm9ybSBFbmFibGluZyAmIERldmVsb3BtZW50CkludGVsIENvcnBvcmF0aW9u Cig5MTYpIDM1Ni0yNzk1Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=