From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbdHJAVI (ORCPT ); Wed, 9 Aug 2017 20:21:08 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:59037 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbdHJAVG (ORCPT ); Wed, 9 Aug 2017 20:21:06 -0400 Date: Thu, 10 Aug 2017 02:20:41 +0200 From: Andrew Lunn To: Florian Fainelli Cc: David Wu , davem@davemloft.net, heiko@sntech.de, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, olof@lixom.net, linux@armlinux.org.uk, arnd@arndb.de, peppe.cavallaro@st.com, alexandre.torgue@st.com, huangtao@rock-chips.com, hwg@rock-chips.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding Message-ID: <20170810002041.GA10776@lunn.ch> References: <1502280475-736-1-git-send-email-david.wu@rock-chips.com> <1502280630-2254-1-git-send-email-david.wu@rock-chips.com> <778B0470-8ABD-46AD-A63D-F0CF4911C800@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <778B0470-8ABD-46AD-A63D-F0CF4911C800@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 09, 2017 at 03:47:34PM -0700, Florian Fainelli wrote: > On August 9, 2017 5:10:30 AM PDT, David Wu wrote: > >Add the documentation for internal phy. A boolean property > >indicates that a internal phy will be used. > > > >Signed-off-by: David Wu > >--- > > Documentation/devicetree/bindings/net/phy.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > > >diff --git a/Documentation/devicetree/bindings/net/phy.txt > >b/Documentation/devicetree/bindings/net/phy.txt > >index b558576..942c892 100644 > >--- a/Documentation/devicetree/bindings/net/phy.txt > >+++ b/Documentation/devicetree/bindings/net/phy.txt > >@@ -52,6 +52,9 @@ Optional Properties: > > Mark the corresponding energy efficient ethernet mode as broken and > > request the ethernet to stop advertising it. > > > >+- phy-is-internal: If set, indicates that phy will connect to the MAC > >as a > >+ internal phy. > > Something along the lines of: > > If set, indicates that the PHY is integrated into the same physical package as the Ethernet MAC. Hi Florian, David. I'm happy with the property name. But i think the text needs more description. We deal with Ethernet switches with integrated PHYs. Yet for us, this property is unneeded. Seeing this property means some bit of software needs to ensure the internal PHY should be used, when given the choice between an internal and external PHY. So i would say something like: If set, indicates that the PHY is integrated into the same physical package as the Ethernet MAC. If needed, muxers should be configured to ensure the internal PHY is used. The absence of this property indicates the muxers should be configured so that the external PHY is used. This last part is important. If the bootloader has set the internal PHY to be used, you need to reset it. Otherwise we are going to get into a mess sometime later and need to add a phy-is-external property. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Thu, 10 Aug 2017 02:20:41 +0200 Subject: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding In-Reply-To: <778B0470-8ABD-46AD-A63D-F0CF4911C800@gmail.com> References: <1502280475-736-1-git-send-email-david.wu@rock-chips.com> <1502280630-2254-1-git-send-email-david.wu@rock-chips.com> <778B0470-8ABD-46AD-A63D-F0CF4911C800@gmail.com> Message-ID: <20170810002041.GA10776@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Aug 09, 2017 at 03:47:34PM -0700, Florian Fainelli wrote: > On August 9, 2017 5:10:30 AM PDT, David Wu wrote: > >Add the documentation for internal phy. A boolean property > >indicates that a internal phy will be used. > > > >Signed-off-by: David Wu > >--- > > Documentation/devicetree/bindings/net/phy.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > > >diff --git a/Documentation/devicetree/bindings/net/phy.txt > >b/Documentation/devicetree/bindings/net/phy.txt > >index b558576..942c892 100644 > >--- a/Documentation/devicetree/bindings/net/phy.txt > >+++ b/Documentation/devicetree/bindings/net/phy.txt > >@@ -52,6 +52,9 @@ Optional Properties: > > Mark the corresponding energy efficient ethernet mode as broken and > > request the ethernet to stop advertising it. > > > >+- phy-is-internal: If set, indicates that phy will connect to the MAC > >as a > >+ internal phy. > > Something along the lines of: > > If set, indicates that the PHY is integrated into the same physical package as the Ethernet MAC. Hi Florian, David. I'm happy with the property name. But i think the text needs more description. We deal with Ethernet switches with integrated PHYs. Yet for us, this property is unneeded. Seeing this property means some bit of software needs to ensure the internal PHY should be used, when given the choice between an internal and external PHY. So i would say something like: If set, indicates that the PHY is integrated into the same physical package as the Ethernet MAC. If needed, muxers should be configured to ensure the internal PHY is used. The absence of this property indicates the muxers should be configured so that the external PHY is used. This last part is important. If the bootloader has set the internal PHY to be used, you need to reset it. Otherwise we are going to get into a mess sometime later and need to add a phy-is-external property. Andrew