From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
wei.liu2@citrix.com
Subject: [PATCH] libxc: correct error message in xc_sr_common.c
Date: Thu, 10 Aug 2017 13:24:27 +0200 [thread overview]
Message-ID: <20170810112428.5769-1-jgross@suse.com> (raw)
When the record length for sending the p2m frames in a migration
stream is too large, the issued error message is not very helpful:
xc: Record (0x00000003, x86 PV P2M frames) length 0x8 exceeds max
(0x800000): Internal error
When printing the error use the size which was tested instead that of
the record header length.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/libxc/xc_sr_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libxc/xc_sr_common.c b/tools/libxc/xc_sr_common.c
index 48fa676f4e..79b9c3e940 100644
--- a/tools/libxc/xc_sr_common.c
+++ b/tools/libxc/xc_sr_common.c
@@ -71,8 +71,8 @@ int write_split_record(struct xc_sr_context *ctx, struct xc_sr_record *rec,
if ( record_length > REC_LENGTH_MAX )
{
- ERROR("Record (0x%08x, %s) length %#x exceeds max (%#x)", rec->type,
- rec_type_to_str(rec->type), rec->length, REC_LENGTH_MAX);
+ ERROR("Record (0x%08x, %s) length %#zx exceeds max (%#x)", rec->type,
+ rec_type_to_str(rec->type), record_length, REC_LENGTH_MAX);
return -1;
}
--
2.12.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2017-08-10 11:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 11:24 Juergen Gross [this message]
2017-08-10 11:24 ` [PATCH] libxc: increase maximum migration stream record length Juergen Gross
2017-08-10 12:26 ` Andrew Cooper
2017-08-30 17:38 ` Juergen Gross
2017-08-31 10:24 ` Ian Jackson
2017-09-01 17:07 ` Wei Liu
2017-08-10 12:04 ` [PATCH] libxc: correct error message in xc_sr_common.c Andrew Cooper
2017-08-10 13:40 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810112428.5769-1-jgross@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.