From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC v2 13/23] x86/power/64: Adapt assembly for PIE support Date: Fri, 11 Aug 2017 14:36:18 +0200 Message-ID: <20170811123618.GC16126__7237.18585582009$1502455048$gmane$org@amd> References: <20170810172615.51965-1-thgarnie@google.com> <20170810172615.51965-14-thgarnie@google.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5728788101218462637==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dg9As-0004RV-HO for xen-devel@lists.xenproject.org; Fri, 11 Aug 2017 12:36:22 +0000 In-Reply-To: <20170810172615.51965-14-thgarnie@google.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Thomas Garnier Cc: Nicolas Pitre , Michal Hocko , kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , Peter Zijlstra , Catalin Marinas , Christopher Li , Alexei Starovoitov , David Howells , Paul Gortmaker , Peter Foley , "H . Peter Anvin" , kernel-hardening@lists.openwall.com, Christoph Lameter , Thomas Gleixner , Kees Cook , x86@kernel.org, Herbert Xu , Daniel Borkmann , Matthew Wilcox , Joerg Roedel , "Rafael J . Wysocki" , Daniel Micay , Baoquan He List-Id: xen-devel@lists.xenproject.org --===============5728788101218462637== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vOmOzSkFvhd7u8Ms" Content-Disposition: inline --vOmOzSkFvhd7u8Ms Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2017-08-10 10:26:05, Thomas Garnier wrote: > Change the assembly code to use only relative references of symbols for t= he > kernel to be PIE compatible. >=20 > Position Independent Executable (PIE) support will allow to extended the > KASLR randomization range below the -2G memory limit. >=20 > Signed-off-by: Thomas Garnier Acked-by: Pavel Machek > --- a/arch/x86/power/hibernate_asm_64.S > +++ b/arch/x86/power/hibernate_asm_64.S > @@ -24,7 +24,7 @@ > #include > =20 > ENTRY(swsusp_arch_suspend) > - movq $saved_context, %rax > + leaq saved_context(%rip), %rax > movq %rsp, pt_regs_sp(%rax) > movq %rbp, pt_regs_bp(%rax) > movq %rsi, pt_regs_si(%rax) > @@ -115,7 +115,7 @@ ENTRY(restore_registers) > movq %rax, %cr4; # turn PGE back on > =20 > /* We don't restore %rax, it must be 0 anyway */ > - movq $saved_context, %rax > + leaq saved_context(%rip), %rax > movq pt_regs_sp(%rax), %rsp > movq pt_regs_bp(%rax), %rbp > movq pt_regs_si(%rax), %rsi --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --vOmOzSkFvhd7u8Ms Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlmNpMIACgkQMOfwapXb+vJG3ACfVMzKXQzx7J3rvbkT2TBtbrjp JrUAnR5LW+sxtWmaznI1DNIMBYBOlQXY =ii2P -----END PGP SIGNATURE----- --vOmOzSkFvhd7u8Ms-- --===============5728788101218462637== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5728788101218462637==--