From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753205AbdHKNIg (ORCPT ); Fri, 11 Aug 2017 09:08:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:55115 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752949AbdHKNIe (ORCPT ); Fri, 11 Aug 2017 09:08:34 -0400 Date: Fri, 11 Aug 2017 15:08:31 +0200 From: Michal Hocko To: Pavel Tatashin Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, ard.biesheuvel@linaro.org, will.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org Subject: Re: [v6 15/15] mm: debug for raw alloctor Message-ID: <20170811130831.GN30811@dhcp22.suse.cz> References: <1502138329-123460-1-git-send-email-pasha.tatashin@oracle.com> <1502138329-123460-16-git-send-email-pasha.tatashin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502138329-123460-16-git-send-email-pasha.tatashin@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 07-08-17 16:38:49, Pavel Tatashin wrote: > When CONFIG_DEBUG_VM is enabled, this patch sets all the memory that is > returned by memblock_virt_alloc_try_nid_raw() to ones to ensure that no > places excpect zeroed memory. Please fold this into the patch which introduces memblock_virt_alloc_try_nid_raw. I am not sure CONFIG_DEBUG_VM is the best config because that tends to be enabled quite often. Maybe CONFIG_MEMBLOCK_DEBUG? Or even make it kernel command line parameter? > Signed-off-by: Pavel Tatashin > Reviewed-by: Steven Sistare > Reviewed-by: Daniel Jordan > Reviewed-by: Bob Picco > --- > mm/memblock.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 3fbf3bcb52d9..29fcb1dd8a81 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1363,12 +1363,19 @@ void * __init memblock_virt_alloc_try_nid_raw( > phys_addr_t min_addr, phys_addr_t max_addr, > int nid) > { > + void *ptr; > + > memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=0x%llx max_addr=0x%llx %pF\n", > __func__, (u64)size, (u64)align, nid, (u64)min_addr, > (u64)max_addr, (void *)_RET_IP_); > > - return memblock_virt_alloc_internal(size, align, > - min_addr, max_addr, nid); > + ptr = memblock_virt_alloc_internal(size, align, > + min_addr, max_addr, nid); > +#ifdef CONFIG_DEBUG_VM > + if (ptr && size > 0) > + memset(ptr, 0xff, size); > +#endif > + return ptr; > } > > /** > -- > 2.14.0 -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Date: Fri, 11 Aug 2017 13:08:31 +0000 Subject: Re: [v6 15/15] mm: debug for raw alloctor Message-Id: <20170811130831.GN30811@dhcp22.suse.cz> List-Id: References: <1502138329-123460-1-git-send-email-pasha.tatashin@oracle.com> <1502138329-123460-16-git-send-email-pasha.tatashin@oracle.com> In-Reply-To: <1502138329-123460-16-git-send-email-pasha.tatashin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Mon 07-08-17 16:38:49, Pavel Tatashin wrote: > When CONFIG_DEBUG_VM is enabled, this patch sets all the memory that is > returned by memblock_virt_alloc_try_nid_raw() to ones to ensure that no > places excpect zeroed memory. Please fold this into the patch which introduces memblock_virt_alloc_try_nid_raw. I am not sure CONFIG_DEBUG_VM is the best config because that tends to be enabled quite often. Maybe CONFIG_MEMBLOCK_DEBUG? Or even make it kernel command line parameter? > Signed-off-by: Pavel Tatashin > Reviewed-by: Steven Sistare > Reviewed-by: Daniel Jordan > Reviewed-by: Bob Picco > --- > mm/memblock.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 3fbf3bcb52d9..29fcb1dd8a81 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1363,12 +1363,19 @@ void * __init memblock_virt_alloc_try_nid_raw( > phys_addr_t min_addr, phys_addr_t max_addr, > int nid) > { > + void *ptr; > + > memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=0x%llx max_addr=0x%llx %pF\n", > __func__, (u64)size, (u64)align, nid, (u64)min_addr, > (u64)max_addr, (void *)_RET_IP_); > > - return memblock_virt_alloc_internal(size, align, > - min_addr, max_addr, nid); > + ptr = memblock_virt_alloc_internal(size, align, > + min_addr, max_addr, nid); > +#ifdef CONFIG_DEBUG_VM > + if (ptr && size > 0) > + memset(ptr, 0xff, size); > +#endif > + return ptr; > } > > /** > -- > 2.14.0 -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 04CE86B02F4 for ; Fri, 11 Aug 2017 09:08:34 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id e204so6381211wma.2 for ; Fri, 11 Aug 2017 06:08:33 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id w20si657279wra.281.2017.08.11.06.08.32 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 Aug 2017 06:08:32 -0700 (PDT) Date: Fri, 11 Aug 2017 15:08:31 +0200 From: Michal Hocko Subject: Re: [v6 15/15] mm: debug for raw alloctor Message-ID: <20170811130831.GN30811@dhcp22.suse.cz> References: <1502138329-123460-1-git-send-email-pasha.tatashin@oracle.com> <1502138329-123460-16-git-send-email-pasha.tatashin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502138329-123460-16-git-send-email-pasha.tatashin@oracle.com> Sender: owner-linux-mm@kvack.org List-ID: To: Pavel Tatashin Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, ard.biesheuvel@linaro.org, will.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org On Mon 07-08-17 16:38:49, Pavel Tatashin wrote: > When CONFIG_DEBUG_VM is enabled, this patch sets all the memory that is > returned by memblock_virt_alloc_try_nid_raw() to ones to ensure that no > places excpect zeroed memory. Please fold this into the patch which introduces memblock_virt_alloc_try_nid_raw. I am not sure CONFIG_DEBUG_VM is the best config because that tends to be enabled quite often. Maybe CONFIG_MEMBLOCK_DEBUG? Or even make it kernel command line parameter? > Signed-off-by: Pavel Tatashin > Reviewed-by: Steven Sistare > Reviewed-by: Daniel Jordan > Reviewed-by: Bob Picco > --- > mm/memblock.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 3fbf3bcb52d9..29fcb1dd8a81 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1363,12 +1363,19 @@ void * __init memblock_virt_alloc_try_nid_raw( > phys_addr_t min_addr, phys_addr_t max_addr, > int nid) > { > + void *ptr; > + > memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=0x%llx max_addr=0x%llx %pF\n", > __func__, (u64)size, (u64)align, nid, (u64)min_addr, > (u64)max_addr, (void *)_RET_IP_); > > - return memblock_virt_alloc_internal(size, align, > - min_addr, max_addr, nid); > + ptr = memblock_virt_alloc_internal(size, align, > + min_addr, max_addr, nid); > +#ifdef CONFIG_DEBUG_VM > + if (ptr && size > 0) > + memset(ptr, 0xff, size); > +#endif > + return ptr; > } > > /** > -- > 2.14.0 -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: mhocko@kernel.org (Michal Hocko) Date: Fri, 11 Aug 2017 15:08:31 +0200 Subject: [v6 15/15] mm: debug for raw alloctor In-Reply-To: <1502138329-123460-16-git-send-email-pasha.tatashin@oracle.com> References: <1502138329-123460-1-git-send-email-pasha.tatashin@oracle.com> <1502138329-123460-16-git-send-email-pasha.tatashin@oracle.com> Message-ID: <20170811130831.GN30811@dhcp22.suse.cz> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon 07-08-17 16:38:49, Pavel Tatashin wrote: > When CONFIG_DEBUG_VM is enabled, this patch sets all the memory that is > returned by memblock_virt_alloc_try_nid_raw() to ones to ensure that no > places excpect zeroed memory. Please fold this into the patch which introduces memblock_virt_alloc_try_nid_raw. I am not sure CONFIG_DEBUG_VM is the best config because that tends to be enabled quite often. Maybe CONFIG_MEMBLOCK_DEBUG? Or even make it kernel command line parameter? > Signed-off-by: Pavel Tatashin > Reviewed-by: Steven Sistare > Reviewed-by: Daniel Jordan > Reviewed-by: Bob Picco > --- > mm/memblock.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 3fbf3bcb52d9..29fcb1dd8a81 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1363,12 +1363,19 @@ void * __init memblock_virt_alloc_try_nid_raw( > phys_addr_t min_addr, phys_addr_t max_addr, > int nid) > { > + void *ptr; > + > memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=0x%llx max_addr=0x%llx %pF\n", > __func__, (u64)size, (u64)align, nid, (u64)min_addr, > (u64)max_addr, (void *)_RET_IP_); > > - return memblock_virt_alloc_internal(size, align, > - min_addr, max_addr, nid); > + ptr = memblock_virt_alloc_internal(size, align, > + min_addr, max_addr, nid); > +#ifdef CONFIG_DEBUG_VM > + if (ptr && size > 0) > + memset(ptr, 0xff, size); > +#endif > + return ptr; > } > > /** > -- > 2.14.0 -- Michal Hocko SUSE Labs