From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753613AbdHKRnc (ORCPT <rfc822;w@1wt.eu>);
        Fri, 11 Aug 2017 13:43:32 -0400
Received: from ganesha.gnumonks.org ([213.95.27.120]:53036 "EHLO
        ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753435AbdHKRna (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Aug 2017 13:43:30 -0400
Date: Fri, 11 Aug 2017 19:42:59 +0200
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: mka@chromium.org, lorenzo@google.com,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        Florian Westphal <fw@strlen.de>,
        "David S. Miller" <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_nat_h323: fix logical-not-parentheses
 warning
Message-ID: <20170811174259.GA3743@salvia>
References: <20170731183949.73763-1-ndesaulniers@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170731183949.73763-1-ndesaulniers@google.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Nick,

On Mon, Jul 31, 2017 at 11:39:49AM -0700, Nick Desaulniers wrote:
> Clang produces the following warning:
[...]
> Also, it's even cleaner to use the form:
> 
> if (x)
> 
> but then if the return codes change from treating 0 as success (unlikely),
> then all call sites must be updated.
> 
> I'm happy to send v2 that changes to that form, and updates the other call
> sites to be:
> 
> if (set_h225_addr())
>   handle_failures()
> else
>   handle_success()

That sounds very reasonable, send a v2 if this triggers a larger
patch.

Or I can just take this patch, as you prefer.

Thanks!