From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753750AbdHKVLg (ORCPT ); Fri, 11 Aug 2017 17:11:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46910 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753612AbdHKVLf (ORCPT ); Fri, 11 Aug 2017 17:11:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 638C372D98 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Fri, 11 Aug 2017 16:11:31 -0500 From: Josh Poimboeuf To: Miroslav Benes Cc: jeyu@kernel.org, jikos@kernel.org, pmladek@suse.com, lpechacek@suse.cz, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , "H. Peter Anvin" , Ingo Molnar , Michael Ellerman , Oleg Nesterov , Thomas Gleixner Subject: Re: [PATCH v2 0/3] livepatch: Introduce force sysfs attribute Message-ID: <20170811211131.n7mo4xsucteba7hz@treble> References: <20170810104815.14727-1-mbenes@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170810104815.14727-1-mbenes@suse.cz> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 11 Aug 2017 21:11:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2017 at 12:48:12PM +0200, Miroslav Benes wrote: > Now there is a sysfs attribute called "force", which provides two > functionalities, "signal" and "force" (previously "unmark"). I haven't > managed to come up with better names. Proposals are welcome. On the > other hand I do not mind it much. Now "force" has two meanings, which is a little confusing. What do you think about just having two separate write-only sysfs flags? echo 1 > /sys/kernel/livepatch/signal echo 1 > /sys/kernel/livepatch/force That way there's no ambiguity. -- Josh