Re: [PATCH 1/2] drm/bridge: add Silicon Image SiI9234 driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

On Fri, Aug 11, 2017 at 12:00:43PM +0300, Laurent Pinchart wrote:

> (now CC'ing Mark Brown with his correct e-mail address)

This is a *lot* of quoted discussion...

> > Okay, I see no problem adding support for all those three supplies, but
> > I was wondering how to model them in the device tree, because from the
> > software perspective ALL power supplies needed by this chip are enabled by a
> > single GPIO line switch.

> > I see 3 possible solutions:
> > 1. Keep only single vcc supply for now and use fixed gpio regulator for it
> > as a provider. Add a comment that it fact it provides 3 different power
> > signals.
> > 2. Extend fixed gpio regulator driver and bindings so it will be possible to
> > have more than one fixed regulator controlled by the same gpio pin.
> > 3. Model VCC_3.3V_MHL and VCC_1.8V_MHL providers as "vctrl-regulator" and
> > use this VSIL_1.2 as control voltage for them.

> > Which one do you prefer?

> 2 would be best I think, but that's more work. Mark, what do you think ?

Just model them all individually and let the regulator framework sort it
out.  It's got the concept of shared GPIO enables already so you should
be able to just describe the system directly and the framework will
figure things out, and even if it didn't there should be no need to
change any of the bindings here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]