From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhVsl-0006aV-Of for qemu-devel@nongnu.org; Tue, 15 Aug 2017 03:03:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhVsZ-00071d-0C for qemu-devel@nongnu.org; Tue, 15 Aug 2017 03:03:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33140) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhVsY-00071H-N8 for qemu-devel@nongnu.org; Tue, 15 Aug 2017 03:03:06 -0400 Date: Tue, 15 Aug 2017 09:03:02 +0200 From: Cornelia Huck Message-ID: <20170815090302.3f315027.cohuck@redhat.com> In-Reply-To: References: <20170814204450.24118-1-farman@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Eric Farman , borntraeger@de.ibm.com, agraf@suse.de, qemu-devel@nongnu.org On Tue, 15 Aug 2017 07:02:10 +0200 Thomas Huth wrote: > On 14.08.2017 22:44, Eric Farman wrote: > > How often does one really do a "make clean" ? Rather infrequently, > > as I only stumbled on this today. > > > > Perhaps I have missed the RM variable somewhere, as I see similar syntax > > in some of the tests/tcg/ Makefiles, but I don't see it being set here. > > My configure statement isn't terribly interesting, just enabling debug > > for an s390x target, and as such there's no RM variable in its output. > > I'll trust that Thomas will chime in with where it should have been. > > In the meantime, this does the trick for me. > > RM is one of the variables that should be pre-initialized by Make, and > AFAIK should be used to increase portability (well, it's likely not > important for QEMU since we require a posix-shell like built environment > anyway). > > According to the info page of Make, chapter "10.3 Variables Used by > Implicit Rules": > > `RM' > Command to remove a file; default `rm -f'. > > I've also checked it again and "make clean" works fine here (using GNU > Make 3.82). Which version of Make (and Linux distro) are you using? Interesting. It fails for me with GNU Make 3.82 on my RHEL guest as well. > Anyway, maybe I also simply missed something, so I'm certainly also fine > with the patch to revert it to "rm -f". Given that other bios makefiles use rm -f as well, let's just change back until we figure out what's wrong.