From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbdHONis (ORCPT ); Tue, 15 Aug 2017 09:38:48 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:52476 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbdHONip (ORCPT ); Tue, 15 Aug 2017 09:38:45 -0400 Date: Tue, 15 Aug 2017 14:38:41 +0100 From: Catalin Marinas To: Dou Liyang Cc: Will Deacon , mpe@ellerman.id.au, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/11] arm64: numa: Remove the unused parent_node() macro Message-ID: <20170815133840.f5ykdecovzhiydbh@armageddon.cambridge.arm.com> References: <1501076076-1974-1-git-send-email-douly.fnst@cn.fujitsu.com> <1501076076-1974-2-git-send-email-douly.fnst@cn.fujitsu.com> <20170804133017.GD15287@arm.com> <0e088b13-12eb-3bf6-696d-9fdd79e96670@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e088b13-12eb-3bf6-696d-9fdd79e96670@cn.fujitsu.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 04, 2017 at 11:28:36PM +0800, Dou Liyang wrote: > Hi will, > > At 08/04/2017 09:30 PM, Will Deacon wrote: > > On Wed, Jul 26, 2017 at 09:34:26PM +0800, Dou Liyang wrote: > > > Commit a7be6e5a7f8d ("mm: drop useless local parameters of > > > __register_one_node()") removes the last user of parent_node(). > > > > > > The parent_node() macro in ARM64 platform is unnecessary. > > > > > > Remove it for cleanup. > > > > > > Reported-by: Michael Ellerman > > > Signed-off-by: Dou Liyang > > > Cc: Michael Ellerman > > > Cc: Will Deacon > > > Cc: linux-arm-kernel@lists.infradead.org > > > --- > > > arch/arm64/include/asm/numa.h | 3 --- > > > 1 file changed, 3 deletions(-) > > > > > > diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h > > > index bf466d1..ef7b238 100644 > > > --- a/arch/arm64/include/asm/numa.h > > > +++ b/arch/arm64/include/asm/numa.h > > > @@ -7,9 +7,6 @@ > > > > > > #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) > > > > > > -/* currently, arm64 implements flat NUMA topology */ > > > -#define parent_node(node) (node) > > > - > > > > Acked-by: Will Deacon > > > > Where you intending for this to go via the arm64 tree? > > I intend for this to go to upstream tree. shall we? Queued for 4.14. Thanks. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Tue, 15 Aug 2017 14:38:41 +0100 Subject: [PATCH 01/11] arm64: numa: Remove the unused parent_node() macro In-Reply-To: <0e088b13-12eb-3bf6-696d-9fdd79e96670@cn.fujitsu.com> References: <1501076076-1974-1-git-send-email-douly.fnst@cn.fujitsu.com> <1501076076-1974-2-git-send-email-douly.fnst@cn.fujitsu.com> <20170804133017.GD15287@arm.com> <0e088b13-12eb-3bf6-696d-9fdd79e96670@cn.fujitsu.com> Message-ID: <20170815133840.f5ykdecovzhiydbh@armageddon.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Aug 04, 2017 at 11:28:36PM +0800, Dou Liyang wrote: > Hi will, > > At 08/04/2017 09:30 PM, Will Deacon wrote: > > On Wed, Jul 26, 2017 at 09:34:26PM +0800, Dou Liyang wrote: > > > Commit a7be6e5a7f8d ("mm: drop useless local parameters of > > > __register_one_node()") removes the last user of parent_node(). > > > > > > The parent_node() macro in ARM64 platform is unnecessary. > > > > > > Remove it for cleanup. > > > > > > Reported-by: Michael Ellerman > > > Signed-off-by: Dou Liyang > > > Cc: Michael Ellerman > > > Cc: Will Deacon > > > Cc: linux-arm-kernel at lists.infradead.org > > > --- > > > arch/arm64/include/asm/numa.h | 3 --- > > > 1 file changed, 3 deletions(-) > > > > > > diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h > > > index bf466d1..ef7b238 100644 > > > --- a/arch/arm64/include/asm/numa.h > > > +++ b/arch/arm64/include/asm/numa.h > > > @@ -7,9 +7,6 @@ > > > > > > #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) > > > > > > -/* currently, arm64 implements flat NUMA topology */ > > > -#define parent_node(node) (node) > > > - > > > > Acked-by: Will Deacon > > > > Where you intending for this to go via the arm64 tree? > > I intend for this to go to upstream tree. shall we? Queued for 4.14. Thanks. -- Catalin