All of
 help / color / mirror / Atom feed
From: Petr Mladek <>
To: Nikitas Angelinas <>
Cc: Sergey Senozhatsky <>,
	Steven Rostedt <>,
Subject: Re: [PATCH] printk: Clean up do_syslog() error handling
Date: Tue, 15 Aug 2017 17:03:13 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20170730033636.GA935@vostro>

On Sat 2017-07-29 20:36:36, Nikitas Angelinas wrote:
> The error variable in do_syslog() is preemptively set to the error code
> before the error condition is checked, and then set to 0 if the error
> condition is not encountered. This is not necessary, as it is likely
> simpler to return immediately upon encountering the error condition. A
> redundant set of the error variable to 0 is also removed.
> This patch has been build-tested on x86_64, but not tested for
> functionality.
> Signed-off-by: Nikitas Angelinas <>

The code looks better. Also the patch looks correct.

Acked-by: Petr Mladek <>

I have pushed it into for-4.14 branch.

Best Regards,

      parent reply	other threads:[~2017-08-15 15:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-30  3:36 Nikitas Angelinas
2017-08-01  7:38 ` Sergey Senozhatsky
2017-08-15 15:03 ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] printk: Clean up do_syslog() error handling' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.