From: Oleg Nesterov <oleg@redhat.com>
To: Jamie Iles <jamie.iles@oracle.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.
Date: Tue, 15 Aug 2017 18:16:58 +0200 [thread overview]
Message-ID: <20170815161658.GA1344@redhat.com> (raw)
In-Reply-To: <20170815112806.10728-1-jamie.iles@oracle.com>
On 08/15, Jamie Iles wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1194,7 +1194,11 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
> recalc_sigpending_and_wake(t);
> }
> }
> - if (action->sa.sa_handler == SIG_DFL)
> + /*
> + * Don't clear SIGNAL_UNKILLABLE for traced tasks, users won't expect
> + * debugging to leave init killable.
> + */
> + if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
> t->signal->flags &= ~SIGNAL_UNKILLABLE;
> ret = specific_send_sig_info(sig, info, t);
> spin_unlock_irqrestore(&t->sighand->siglock, flags);
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2017-08-15 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 11:28 [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks Jamie Iles
2017-08-15 16:16 ` Oleg Nesterov [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-05-04 12:51 Jamie Iles
2017-05-05 16:26 ` Oleg Nesterov
2017-05-05 16:34 ` Jamie Iles
2017-06-08 10:07 ` Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815161658.GA1344@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jamie.iles@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.