All of lore.kernel.org
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: peterz@infradead.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, juri.lelli@gmail.com,
	kernel-team@lge.com
Subject: Re: [PATCH v6 1/2] sched/deadline: Add support for SD_PREFER_SIBLING on find_later_rq()
Date: Wed, 16 Aug 2017 23:04:14 +0900	[thread overview]
Message-ID: <20170816140414.GW20323@X58A-UD3R> (raw)
In-Reply-To: <20170816093244.6e35f423@gandalf.local.home>

On Wed, Aug 16, 2017 at 09:32:44AM -0400, Steven Rostedt wrote:
> On Wed, 16 Aug 2017 11:17:36 +0900
> Byungchul Park <byungchul.park@lge.com> wrote:
> 
> 
> > Yes, that's what I intended. IOW:
> > 
> > If (we found a proper sd, not having SD_PREFER_SIBLING?)
> > 	use the sd;
> > else if (we found a proper sd, having SD_PREFER_SIBLING?)
> > 	use the smallest sd among SD_PREFER_SIBLING sds;
> 
> BTW, what do you mean by "smallest sd"?

There might be more than one SD_PREFER_SIBLING domain in its hierachy.
In that case, we have to choose one of them. Imagine the following
example, in case that the source cpu is cpu 0:

[Domain hierachy for cpu 0]

cpu 0 -+ domain 1                 -+
       | SD_PREFER_SIBLING flaged  |
cpu 1 -+                           +- domain 2
                                   |  SD_PREFER_SIBLING flaged
cpu 2 -+---------------------------+
       |
cpu 3 -+

In this case, we have to choose domain 1 than 2, because cpus in domain 1
are closer to the source cpu, cpu 0. That's what I meant.

  reply	other threads:[~2017-08-16 14:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07  3:50 [PATCH v6 0/2] Make find_later_rq() choose a closer cpu in topology Byungchul Park
2017-08-07  3:50 ` [PATCH v6 1/2] sched/deadline: Add support for SD_PREFER_SIBLING on find_later_rq() Byungchul Park
2017-08-15 15:19   ` Steven Rostedt
2017-08-16  0:38     ` Byungchul Park
2017-08-16  1:42       ` Steven Rostedt
2017-08-16  2:17         ` Byungchul Park
2017-08-16 13:32           ` Steven Rostedt
2017-08-16 14:04             ` Byungchul Park [this message]
2017-08-16 14:25               ` Steven Rostedt
2017-08-07  3:50 ` [PATCH v6 2/2] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq() Byungchul Park
2017-08-10 12:12   ` Byungchul Park
2017-08-18  1:25 ` [PATCH v6 0/2] Make find_later_rq() choose a closer cpu in topology Byungchul Park
2017-08-18  4:51   ` Joel Fernandes (Google)
2017-08-18  5:34     ` Byungchul Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170816140414.GW20323@X58A-UD3R \
    --to=byungchul.park@lge.com \
    --cc=juri.lelli@gmail.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.