From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbdHQJ2w convert rfc822-to-8bit (ORCPT ); Thu, 17 Aug 2017 05:28:52 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:55972 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684AbdHQJ2t (ORCPT ); Thu, 17 Aug 2017 05:28:49 -0400 Date: Thu, 17 Aug 2017 11:28:45 +0200 From: Boris Brezillon To: Linus Walleij Cc: Wolfram Sang , "linux-i2c@vger.kernel.org" , Jonathan Corbet , "linux-doc@vger.kernel.org" , Greg Kroah-Hartman , Arnd Bergmann , Przemyslaw Sroka , Arkadiusz Golec , Alan Douglas , Bartosz Folta , Damian Kos , Alicja Jurasik-Urbaniak , Jan Kotas , Cyprian Wronka , Alexandre Belloni , Thomas Petazzoni , Nishanth Menon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC 2/5] i3c: Add core I3C infrastructure Message-ID: <20170817112845.6f7ade8b@bbrezillon> In-Reply-To: References: <1501518290-5723-1-git-send-email-boris.brezillon@free-electrons.com> <1501518290-5723-3-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Thu, 17 Aug 2017 11:03:10 +0200, Linus Walleij a écrit : > On Mon, Jul 31, 2017 at 6:24 PM, Boris Brezillon > wrote: > > > This infrastructure is not complete yet and will be extended over > > time. > > I noticed the lack of pm_* from the core. > > This will be noticed very quickly since the means the problem seen > in e.g. commit 04f59143b571 and the wakeup IRQ business will make it > impossible to do power-efficient drivers until that is resolved. > > It'd be nice to have it to PM right from the start, and the I2C core has > all the right infrastructure in place, so when this stabilize I'd say > atleast it'd be *nice* if the PM business was added in the same > kernel release that introduce this core infrastructure, even if it will > be a separate patch. > > I.e. I consider that more of necessary bread and butter and less of > nice to have topping on the cake. > > What I have seen that leaf vendors doing (i3c) device drivers do > otherwise is complain "it is broken" and then they start to hack > around it instead of helping out with the core. (I think you're > well aware of that phenomenon.) Noted. I'll try to provide core infrastructure for PM in my v2, but it's kind of hard to design something when you don't have real devices. I guess I can mimic I2C for now and make it evolve based on users needs. Regards, Boris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [RFC 2/5] i3c: Add core I3C infrastructure Date: Thu, 17 Aug 2017 11:28:45 +0200 Message-ID: <20170817112845.6f7ade8b@bbrezillon> References: <1501518290-5723-1-git-send-email-boris.brezillon@free-electrons.com> <1501518290-5723-3-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Wolfram Sang , "linux-i2c@vger.kernel.org" , Jonathan Corbet , "linux-doc@vger.kernel.org" , Greg Kroah-Hartman , Arnd Bergmann , Przemyslaw Sroka , Arkadiusz Golec , Alan Douglas , Bartosz Folta , Damian Kos , Alicja Jurasik-Urbaniak , Jan Kotas , Cyprian Wronka , Alexandre Belloni , Thomas Petazzoni , Nishanth Menon , Rob Herring , Pawel Moll List-Id: devicetree@vger.kernel.org Le Thu, 17 Aug 2017 11:03:10 +0200, Linus Walleij a écrit : > On Mon, Jul 31, 2017 at 6:24 PM, Boris Brezillon > wrote: > > > This infrastructure is not complete yet and will be extended over > > time. > > I noticed the lack of pm_* from the core. > > This will be noticed very quickly since the means the problem seen > in e.g. commit 04f59143b571 and the wakeup IRQ business will make it > impossible to do power-efficient drivers until that is resolved. > > It'd be nice to have it to PM right from the start, and the I2C core has > all the right infrastructure in place, so when this stabilize I'd say > atleast it'd be *nice* if the PM business was added in the same > kernel release that introduce this core infrastructure, even if it will > be a separate patch. > > I.e. I consider that more of necessary bread and butter and less of > nice to have topping on the cake. > > What I have seen that leaf vendors doing (i3c) device drivers do > otherwise is complain "it is broken" and then they start to hack > around it instead of helping out with the core. (I think you're > well aware of that phenomenon.) Noted. I'll try to provide core infrastructure for PM in my v2, but it's kind of hard to design something when you don't have real devices. I guess I can mimic I2C for now and make it evolve based on users needs. Regards, Boris