From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v3 4/4] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset() Date: Thu, 17 Aug 2017 15:22:06 +0300 Message-ID: <20170817122206.2dte2yrgrssioi7m@ideak-desk.fi.intel.com> References: <20170814195832.20524-1-hdegoede@redhat.com> <20170814195832.20524-4-hdegoede@redhat.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170814195832.20524-4-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede Cc: dri-devel@lists.freedesktop.org, Daniel Vetter , intel-gfx List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBdWcgMTQsIDIwMTcgYXQgMDk6NTg6MzJQTSArMDIwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KCkgZG9lcyBmb3JjZXdha2UgcHV0 cyBhbmQgZ2V0cyBhcyBzdWNoCj4gd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBuby1vbmUgdHJp ZXMgdG8gYWNjZXNzIHRoZSBQVU5JVC0+UE1JQyBidXMKPiAob24gc3lzdGVtcyB3aGVyZSB0aGlz IGJ1cyBpcyBzaGFyZWQpIHdoaWxlIGl0IHJ1bnMsIG90aGVyd2lzZSBiYWQKPiB0aGluZ3MgaGFw cGVuLgo+IAo+IE5vcm1hbGx5IHRoaXMgaXMgdGFrZW4gY2FyZSBvZiBieSB0aGUgaTkxNV9wbWlj X2J1c19hY2Nlc3Nfbm90aWZpZXIoKQo+IHdoaWNoIGRvZXMgYW4gaW50ZWxfdW5jb3JlX2ZvcmNl d2FrZV9nZXQoRk9SQ0VXQUtFX0FMTCkgd2hlbiBzb21lIG90aGVyCj4gZHJpdmVyIHRyaWVzIHRv IGFjY2VzcyB0aGUgUE1JQyBidXMsIHNvIHRoYXQgbGF0ZXIgZm9yY2V3YWtlIGdldHMgYXJlCj4g bm8tb3BzIChmb3IgdGhlIGR1cmF0aW9uIG9mIHRoZSBidXMgYWNjZXNzKS4KPiAKPiBCdXQgaW50 ZWxfdW5jb3JlX2ZvcmNld2FrZV9yZXNldCBnZXRzIGNhbGxlZCBpbiAzIGNhc2VzOgo+IDEpIEJl Zm9yZSByZWdpc3RlcmluZyB0aGUgcG1pY19idXNfYWNjZXNzX25vdGlmaWVyCj4gMikgQWZ0ZXIg dW5yZWdpc3RlcmluZyB0aGUgcG1pY19idXNfYWNjZXNzX25vdGlmaWVyCj4gMykgVG8gcmVzZXQg Zm9yY2V3YWtlIHN0YXRlIG9uIGEgR1BVIHJlc2V0Cj4gCj4gSW4gYWxsIDMgY2FzZXMgdGhlIGk5 MTVfcG1pY19idXNfYWNjZXNzX25vdGlmaWVyKCkgcHJvdGVjdGlvbiBpcwo+IGluc3VmZmljaWVu dC4KPiAKPiBUaGlzIGNvbW1pdCBmaXhlcyB0aGlzIHJhY2UgYnkgY2FsbGluZyBpb3NmX21iaV9w dW5pdF9hY3F1aXJlKCkgYmVmb3JlCj4gY2FsbGluZyBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jl c2V0KCkuIEluIHRoZSBjYXNlIHdoZXJlIGl0IGlzIGNhbGxlZAo+IGRpcmVjdGx5IGFmdGVyIHVu cmVnaXN0ZXJpbmcgdGhlIHBtaWNfYnVzX2FjY2Vzc19ub3RpZmllciwgd2UgbmVlZCB0bwo+IGhv bGQgdGhlIHB1bml0LWxvY2sgb3ZlciBib3RoIGNhbGxzIHRvIGF2b2lkIGEgcmFjZSB3aGVyZQo+ IGludGVsX3VuY29yZV9md19yZWxlYXNlX3RpbWVyKCkgbWF5IGV4ZWN1dGUgYmV0d2VlbiB0aGUg MiBjYWxscy4KPiAKPiBUbyBhbGxvdyBob2xkaW5nIHRoZSBsb2NrIG92ZXIgYm90aCBjYWxscyB3 ZSBuZWVkIGFuIHVubG9ja2VkCj4gdmFyaWFudCBvZiBpb3NmX21iaV91bnJlZ2lzdGVyX3BtaWNf YnVzX2FjY2Vzc19ub3RpZmllci4gU2luY2UKPiBpbnRlbF91bmNvcmUuYyBpcyB0aGUgb25seSB1 c2VyIG9mIHRoaXMgZnVuY3Rpb24sIHdlIHNpbXBseQo+IG1vZGlmeSBpdCBpbiB0aGlzIGNvbW1p dC4gRG9pbmcgdGhpcyBpbiBhIHNlcGFyYXRlIGNvbW1pdCB3b3VsZAo+IHJlcXVpcmUgZmlyc3Qg YWRkaW5nIGFuIHVubG9ja2VkIHZhcmlhbnQsIHRoZW4gdGhpcyBjb21taXQgYW5kCj4gdGhlbiBy ZW1vdmluZyB0aGUgdW51c2VkIG5vcm1hbCB2YXJpYW50Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEhh bnMgZGUgR29lZGUgPGhkZWdvZWRlQHJlZGhhdC5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2MjoK PiAtUmViYXNlIG9uIGN1cnJlbnQgKEp1bHkgNnRoIDIwMTcpIGRybS1uZXh0Cj4gCj4gQ2hhbmdl cyBpbiB2MzoKPiAtS2VlcCBwdW5pdCBhY3F1aXJlZCAvIGxvY2tlZCBvdmVyIHRoZSB1bnJlZ2lz dGVyICsgZm9yY2V3YWtlX3Jlc2V0Cj4gIGNhbGwgY29tYm8gdG8gYXZvaWQgYSByYWNlIGhpdHRp bmcgYmV0d2VlbiB0aGUgMiBjYWxscwo+IC1UaGlzIHJlcXVpcmVzIG1vZGlmeWluZyBpb3NmX21i aV91bnJlZ2lzdGVyX3BtaWNfYnVzX2FjY2Vzc19ub3RpZmllcgo+ICB0byBub3QgdGFrZSB0aGUg bG9jayBpdHNlbGYsIHNpbmNlIHdlIGFyZSB0aGUgb25seSB1c2VycyB0aGlzIGlzIGRvbmUKPiAg aW4gdGhpcyBzYW1lIGNvbW1pdAo+IC0tLQo+ICBhcmNoL3g4Ni9pbmNsdWRlL2FzbS9pb3NmX21i aS5oICAgICB8IDEwICsrKysrKysrLS0KPiAgYXJjaC94ODYvcGxhdGZvcm0vaW50ZWwvaW9zZl9t YmkuYyAgfCAxNCArKysrKy0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91 bmNvcmUuYyB8IDE3ICsrKysrKysrKysrKystLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMjYgaW5z ZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2lu Y2x1ZGUvYXNtL2lvc2ZfbWJpLmggYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9pb3NmX21iaS5oCj4g aW5kZXggYzMxM2NhYzM2ZjU2Li5mODg0MWJiMDZkOTggMTAwNjQ0Cj4gLS0tIGEvYXJjaC94ODYv aW5jbHVkZS9hc20vaW9zZl9tYmkuaAo+ICsrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL2lvc2Zf bWJpLmgKPiBAQCAtMTQxLDkgKzE0MSwxNCBAQCBpbnQgaW9zZl9tYmlfcmVnaXN0ZXJfcG1pY19i dXNfYWNjZXNzX25vdGlmaWVyKHN0cnVjdCBub3RpZmllcl9ibG9jayAqbmIpOwo+ICAvKioKPiAg ICogaW9zZl9tYmlfcmVnaXN0ZXJfcG1pY19idXNfYWNjZXNzX25vdGlmaWVyIC0gVW5yZWdpc3Rl ciBQTUlDIGJ1cyBub3RpZmllcgoKWW91IG1pc3NlZCB0aGUgcmVuYW1lIGluIHRoZSBkb2MuCgo+ ICAgKgo+ICsgKiBOb3RlIHRoZSBjYWxsZXIgbXVzdCBjYWxsIGlvc2ZfbWJpX3B1bml0X2FjcXVp cmUoKSBiZWZvcmUgY2FsbGluZyB0aGlzCj4gKyAqIHRvIGVuc3VyZSB0aGUgYnVzIGlzIGluYWN0 aXZlIGJlZm9yZSB1bnJlZ2lzdGVyaW5nIChhbmQgY2FsbAo+ICsgKiBpb3NmX21iaV9wdW5pdF9y ZWxlYXNlKCkgYWZ0ZXJ3YXJkcykuCj4gKyAqCj4gICAqIEBuYjogbm90aWZpZXJfYmxvY2sgdG8g dW5yZWdpc3Rlcgo+ICAgKi8KPiAtaW50IGlvc2ZfbWJpX3VucmVnaXN0ZXJfcG1pY19idXNfYWNj ZXNzX25vdGlmaWVyKHN0cnVjdCBub3RpZmllcl9ibG9jayAqbmIpOwo+ICtpbnQgaW9zZl9tYmlf dW5yZWdpc3Rlcl9wbWljX2J1c19hY2Nlc3Nfbm90aWZpZXJfdW5sb2NrZWQoCj4gKwlzdHJ1Y3Qg bm90aWZpZXJfYmxvY2sgKm5iKTsKPiAgCj4gIC8qKgo+ICAgKiBpb3NmX21iaV9jYWxsX3BtaWNf YnVzX2FjY2Vzc19ub3RpZmllcl9jaGFpbiAtIENhbGwgUE1JQyBidXMgbm90aWZpZXIgY2hhaW4K PiBAQCAtMTkxLDcgKzE5Niw4IEBAIGludCBpb3NmX21iaV9yZWdpc3Rlcl9wbWljX2J1c19hY2Nl c3Nfbm90aWZpZXIoc3RydWN0IG5vdGlmaWVyX2Jsb2NrICpuYikKPiAgfQo+ICAKPiAgc3RhdGlj IGlubGluZQo+IC1pbnQgaW9zZl9tYmlfdW5yZWdpc3Rlcl9wbWljX2J1c19hY2Nlc3Nfbm90aWZp ZXIoc3RydWN0IG5vdGlmaWVyX2Jsb2NrICpuYikKPiAraW50IGlvc2ZfbWJpX3VucmVnaXN0ZXJf cG1pY19idXNfYWNjZXNzX25vdGlmaWVyX3VubG9ja2VkKAo+ICsJc3RydWN0IG5vdGlmaWVyX2Js b2NrICpuYikKPiAgewo+ICAJcmV0dXJuIDA7Cj4gIH0KPiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYv cGxhdGZvcm0vaW50ZWwvaW9zZl9tYmkuYyBiL2FyY2gveDg2L3BsYXRmb3JtL2ludGVsL2lvc2Zf bWJpLmMKPiBpbmRleCBhOTUyYWMxOTk3NDEuLjU1OTZhM2VjMWI4OSAxMDA2NDQKPiAtLS0gYS9h cmNoL3g4Ni9wbGF0Zm9ybS9pbnRlbC9pb3NmX21iaS5jCj4gKysrIGIvYXJjaC94ODYvcGxhdGZv cm0vaW50ZWwvaW9zZl9tYmkuYwo+IEBAIC0yMTgsMTkgKzIxOCwxNSBAQCBpbnQgaW9zZl9tYmlf cmVnaXN0ZXJfcG1pY19idXNfYWNjZXNzX25vdGlmaWVyKHN0cnVjdCBub3RpZmllcl9ibG9jayAq bmIpCj4gIH0KPiAgRVhQT1JUX1NZTUJPTChpb3NmX21iaV9yZWdpc3Rlcl9wbWljX2J1c19hY2Nl c3Nfbm90aWZpZXIpOwo+ICAKPiAtaW50IGlvc2ZfbWJpX3VucmVnaXN0ZXJfcG1pY19idXNfYWNj ZXNzX25vdGlmaWVyKHN0cnVjdCBub3RpZmllcl9ibG9jayAqbmIpCj4gK2ludCBpb3NmX21iaV91 bnJlZ2lzdGVyX3BtaWNfYnVzX2FjY2Vzc19ub3RpZmllcl91bmxvY2tlZCgKPiArCXN0cnVjdCBu b3RpZmllcl9ibG9jayAqbmIpCj4gIHsKPiAtCWludCByZXQ7Cj4gKwlXQVJOX09OKCFtdXRleF9p c19sb2NrZWQoJmlvc2ZfbWJpX3B1bml0X211dGV4KSk7Cj4gIAo+IC0JLyogV2FpdCBmb3IgdGhl IGJ1cyB0byBnbyBpbmFjdGl2ZSBiZWZvcmUgdW5yZWdpc3RlcmluZyAqLwo+IC0JbXV0ZXhfbG9j aygmaW9zZl9tYmlfcHVuaXRfbXV0ZXgpOwo+IC0JcmV0ID0gYmxvY2tpbmdfbm90aWZpZXJfY2hh aW5fdW5yZWdpc3RlcigKPiArCXJldHVybiBibG9ja2luZ19ub3RpZmllcl9jaGFpbl91bnJlZ2lz dGVyKAo+ICAJCQkJJmlvc2ZfbWJpX3BtaWNfYnVzX2FjY2Vzc19ub3RpZmllciwgbmIpOwo+IC0J bXV0ZXhfdW5sb2NrKCZpb3NmX21iaV9wdW5pdF9tdXRleCk7Cj4gLQo+IC0JcmV0dXJuIHJldDsK PiAgfQo+IC1FWFBPUlRfU1lNQk9MKGlvc2ZfbWJpX3VucmVnaXN0ZXJfcG1pY19idXNfYWNjZXNz X25vdGlmaWVyKTsKPiArRVhQT1JUX1NZTUJPTChpb3NmX21iaV91bnJlZ2lzdGVyX3BtaWNfYnVz X2FjY2Vzc19ub3RpZmllcl91bmxvY2tlZCk7Cj4gIAo+ICBpbnQgaW9zZl9tYmlfY2FsbF9wbWlj X2J1c19hY2Nlc3Nfbm90aWZpZXJfY2hhaW4odW5zaWduZWQgbG9uZyB2YWwsIHZvaWQgKnYpCj4g IHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+IGluZGV4IDU2OWQxMTU5MThlYi4u N2JlNjE1MDUyMGVkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Vu Y29yZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiBAQCAt MjI5LDYgKzIyOSw3IEBAIGludGVsX3VuY29yZV9md19yZWxlYXNlX3RpbWVyKHN0cnVjdCBocnRp bWVyICp0aW1lcikKPiAgCXJldHVybiBIUlRJTUVSX05PUkVTVEFSVDsKPiAgfQo+ICAKPiArLyog Tm90ZSBjYWxsZXJzIG11c3QgaGF2ZSBhY3F1aXJlZCB0aGUgUFVOSVQtPlBNSUMgYnVzLCBiZWZv cmUgY2FsbGluZyB0aGlzLiAqLwoKTml0OiBjb3VsZCB1c2UgYW4gaW9zZl9hc3NlcnRfbWJpX3B1 bml0X211dGV4X2hlbGQoKSBoZWxwZXIgaW5zdGVhZCBvZgp0aGUgY29tbWVudC4gKHRha2luZyBD T05GSUdfSU9TRl9NQkkgaW50byBhY2NvdW50KQoKPiAgc3RhdGljIHZvaWQgaW50ZWxfdW5jb3Jl X2ZvcmNld2FrZV9yZXNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJ CQkJIGJvb2wgcmVzdG9yZSkKPiAgewo+IEBAIC00MTYsMTQgKzQxNywxOCBAQCBzdGF0aWMgdm9p ZCBfX2ludGVsX3VuY29yZV9lYXJseV9zYW5pdGl6ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gIAkJCQkgICBHVF9GSUZPX0NUTF9SQzZfUE9MSUNZX1NUQUxMKTsKPiAgCX0K PiAgCj4gKwlpb3NmX21iaV9wdW5pdF9hY3F1aXJlKCk7Cj4gIAlpbnRlbF91bmNvcmVfZm9yY2V3 YWtlX3Jlc2V0KGRldl9wcml2LCByZXN0b3JlX2ZvcmNld2FrZSk7Cj4gKwlpb3NmX21iaV9wdW5p dF9yZWxlYXNlKCk7Cj4gIH0KPiAgCj4gIHZvaWQgaW50ZWxfdW5jb3JlX3N1c3BlbmQoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gLQlpb3NmX21iaV91bnJlZ2lzdGVy X3BtaWNfYnVzX2FjY2Vzc19ub3RpZmllcigKPiArCWlvc2ZfbWJpX3B1bml0X2FjcXVpcmUoKTsK PiArCWlvc2ZfbWJpX3VucmVnaXN0ZXJfcG1pY19idXNfYWNjZXNzX25vdGlmaWVyX3VubG9ja2Vk KAo+ICAJCSZkZXZfcHJpdi0+dW5jb3JlLnBtaWNfYnVzX2FjY2Vzc19uYik7Cj4gIAlpbnRlbF91 bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KGRldl9wcml2LCBmYWxzZSk7Cj4gKwlpb3NmX21iaV9wdW5p dF9yZWxlYXNlKCk7Cj4gIH0KPiAgCj4gIHZvaWQgaW50ZWxfdW5jb3JlX3Jlc3VtZV9lYXJseShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gQEAgLTEyNDYsMTIgKzEyNTEsMTQg QEAgdm9pZCBpbnRlbF91bmNvcmVfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gIAo+ICB2b2lkIGludGVsX3VuY29yZV9maW5pKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiAgewo+IC0JaW9zZl9tYmlfdW5yZWdpc3Rlcl9wbWljX2J1c19hY2Nlc3Nf bm90aWZpZXIoCj4gLQkJJmRldl9wcml2LT51bmNvcmUucG1pY19idXNfYWNjZXNzX25iKTsKPiAt Cj4gIAkvKiBQYXJhbm9pYTogbWFrZSBzdXJlIHdlIGhhdmUgZGlzYWJsZWQgZXZlcnl0aGluZyBi ZWZvcmUgd2UgZXhpdC4gKi8KPiAgCWludGVsX3VuY29yZV9zYW5pdGl6ZShkZXZfcHJpdik7Cj4g Kwo+ICsJaW9zZl9tYmlfcHVuaXRfYWNxdWlyZSgpOwo+ICsJaW9zZl9tYmlfdW5yZWdpc3Rlcl9w bWljX2J1c19hY2Nlc3Nfbm90aWZpZXJfdW5sb2NrZWQoCj4gKwkJJmRldl9wcml2LT51bmNvcmUu cG1pY19idXNfYWNjZXNzX25iKTsKPiAgCWludGVsX3VuY29yZV9mb3JjZXdha2VfcmVzZXQoZGV2 X3ByaXYsIGZhbHNlKTsKPiArCWlvc2ZfbWJpX3B1bml0X3JlbGVhc2UoKTsKPiAgfQo+ICAKPiAg I2RlZmluZSBHRU5fUkFOR0UobCwgaCkgR0VOTUFTSygoaCkgLSAxLCAobCkgLSAxKQo+IEBAIC0x NTI0LDcgKzE1MzEsOSBAQCBzdGF0aWMgaW50IGdlbjZfcmVzZXRfZW5naW5lcyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAJcmV0ID0gZ2VuNl9od19kb21haW5fcmVz ZXQoZGV2X3ByaXYsIGh3X21hc2spOwo+ICAKPiArCWlvc2ZfbWJpX3B1bml0X2FjcXVpcmUoKTsK PiAgCWludGVsX3VuY29yZV9mb3JjZXdha2VfcmVzZXQoZGV2X3ByaXYsIHRydWUpOwo+ICsJaW9z Zl9tYmlfcHVuaXRfcmVsZWFzZSgpOwo+ICAKPiAgCXJldHVybiByZXQ7Cj4gIH0KClRoZXJlIGlz IG9uZSBtb3JlIHNwb3QgaW4gaW50ZWxfdW5jb3JlX2NoZWNrX2ZvcmNld2FrZV9kb21haW5zKCkg Y2FsbGluZwppbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KCkgeW91IG1pc3NlZC4KCldpdGgg dGhlIGFib3ZlIGZpeGVzIGFuZCBvcHRpb25hbCBjaGFuZ2UgZm9yIHRoZSBuaXQgbG9va3Mgb2s6 ClJldmlld2VkLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cgo+IC0tIAo+IDIu MTMuNAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK