From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1diko7-00077E-4J for qemu-devel@nongnu.org; Fri, 18 Aug 2017 13:11:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1diko3-0005R0-Tp for qemu-devel@nongnu.org; Fri, 18 Aug 2017 13:11:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49688) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1diko3-0005OB-Nr for qemu-devel@nongnu.org; Fri, 18 Aug 2017 13:11:35 -0400 From: Amador Pahim Date: Fri, 18 Aug 2017 19:05:22 +0200 Message-Id: <20170818170526.13496-8-apahim@redhat.com> In-Reply-To: <20170818170526.13496-1-apahim@redhat.com> References: <20170818170526.13496-1-apahim@redhat.com> Subject: [Qemu-devel] [PATCH v7 07/11] qemu.py: include debug information on launch error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@gmail.com, famz@redhat.com, berrange@redhat.com, ehabkost@redhat.com, mreitz@redhat.com, kwolf@redhat.com, armbru@redhat.com, crosa@redhat.com, ldoktor@redhat.com, Amador Pahim When launching a VM, if an exception happens and the VM is not initiated, it might be useful to see the qemu command line and the qemu command output. This patch creates that message. Notice that self._iolog needs to be cleaned up in the beginning of the launch() to make sure we will not expose the qemu log from a previous launch if the current one fails. Signed-off-by: Amador Pahim --- scripts/qemu.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 0bcec4b3b1..29fd2469f9 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -147,6 +147,7 @@ class QEMUMachine(object): def launch(self): '''Launch the VM and establish a QMP connection''' + self._iolog = None self._qemu_full_args = None devnull = open(os.path.devnull, 'rb') qemulog = open(self._qemu_log_path, 'wb') @@ -162,6 +163,13 @@ class QEMUMachine(object): self._post_launch() except: self.shutdown() + + LOG.debug('Error launching VM') + if self._qemu_full_args: + LOG.debug('Command: %r', ' '.join(self._qemu_full_args)) + if self._iolog: + LOG.debug('Output: %r', self._iolog) + raise def shutdown(self): -- 2.13.5