From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dimnp-0004WN-AT for qemu-devel@nongnu.org; Fri, 18 Aug 2017 15:19:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dimnk-0003Ve-DD for qemu-devel@nongnu.org; Fri, 18 Aug 2017 15:19:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34526) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dimnk-0003U1-76 for qemu-devel@nongnu.org; Fri, 18 Aug 2017 15:19:24 -0400 Date: Fri, 18 Aug 2017 20:19:08 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170818191907.GI2222@work-vm> References: <20170628190047.26159-1-dgilbert@redhat.com> <20170628190047.26159-26-dgilbert@redhat.com> <20170705005657-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170705005657-mutt-send-email-mst@kernel.org> Subject: Re: [Qemu-devel] [RFC 25/29] vhu: enable = false on get_vring_base List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, a.perevalov@samsung.com, marcandre.lureau@redhat.com, maxime.coquelin@redhat.com, quintela@redhat.com, peterx@redhat.com, lvivier@redhat.com, aarcange@redhat.com * Michael S. Tsirkin (mst@redhat.com) wrote: > On Wed, Jun 28, 2017 at 08:00:43PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > When we receive a GET_VRING_BASE message set enable = false > > to stop any new received packets modifying the ring. > > > > Signed-off-by: Dr. David Alan Gilbert > > I think I already reviewed a similar patch. > Spec says: > Client must only process each ring when it is started. > > IMHO the real fix is to fix client to check the started > flag before processing the ring. Done, I added a vu_queue_started to match vu_queue_enabled and then used it. Dave > > --- > > contrib/libvhost-user/libvhost-user.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c > > index ceddeac74f..d37052b7b0 100644 > > --- a/contrib/libvhost-user/libvhost-user.c > > +++ b/contrib/libvhost-user/libvhost-user.c > > @@ -652,6 +652,7 @@ vu_get_vring_base_exec(VuDev *dev, VhostUserMsg *vmsg) > > vmsg->size = sizeof(vmsg->payload.state); > > > > dev->vq[index].started = false; > > + dev->vq[index].enable = false; > > if (dev->iface->queue_set_started) { > > dev->iface->queue_set_started(dev, index, false); > > } > > -- > > 2.13.0 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK