All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Dou Liyang <douly.fnst@cn.fujitsu.com>,
	qemu-devel@nongnu.org, pbonzini@redhat.com, rth@twiddle.net,
	imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0
Date: Fri, 18 Aug 2017 16:20:23 -0300	[thread overview]
Message-ID: <20170818192023.GH3108@localhost.localdomain> (raw)
In-Reply-To: <20170818213432-mutt-send-email-mst@kernel.org>

On Fri, Aug 18, 2017 at 09:35:00PM +0300, Michael S. Tsirkin wrote:
> On Wed, Aug 16, 2017 at 09:45:35AM +0800, Dou Liyang wrote:
> > Currently, Using the fisrt node without memory on the machine makes
> > QEMU unhappy. With this example command line:
> >   ... \
> >   -m 1024M,slots=4,maxmem=32G \
> >   -numa node,nodeid=0 \
> >   -numa node,mem=1024M,nodeid=1 \
> >   -numa node,nodeid=2 \
> >   -numa node,nodeid=3 \
> > Guest reports "No NUMA configuration found" and the NUMA topology is
> > wrong.
> > 
> > This is because when QEMU builds ACPI SRAT, it regards node0 as the
> > default node to deal with the memory hole(640K-1M). this means the
> > node0 must have some memory(>1M), but, actually it can have no
> > memory.
> > 
> > Fix this problem by replace the node0 with the first node which has
> > memory on it. Add a new function for each node. Also do some cleanup.
> > 
> > Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
> 
> This isn't a regression, is it? If it isn't, it's not a 2.10 candidate
> IMHO.

As noted in another reply to v2, I agree and I'm treating it as a
2.11 candidate.

-- 
Eduardo

      reply	other threads:[~2017-08-18 19:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16  1:45 [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0 Dou Liyang
2017-08-17  5:58 ` Dou Liyang
2017-08-18 16:48   ` Eduardo Habkost
2017-08-20 11:52     ` Dou Liyang
2017-08-21  8:57       ` Igor Mammedov
2017-08-21 11:23         ` Dou Liyang
2017-08-21 13:25           ` Igor Mammedov
2017-08-18 18:35 ` Michael S. Tsirkin
2017-08-18 19:20   ` Eduardo Habkost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170818192023.GH3108@localhost.localdomain \
    --to=ehabkost@redhat.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.