All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: tiwai@suse.de
Cc: alsa-devel@alsa-project.org,
	linux1394-devel@lists.sourceforge.net, clemens@ladisch.de,
	ffado-devel@lists.sf.net
Subject: [PATCH 0/2] ALSA: firewire-motu: add support for AudioExpress
Date: Sun, 20 Aug 2017 21:25:02 +0900	[thread overview]
Message-ID: <20170820122504.24486-1-o-takashi@sakamocchi.jp> (raw)

Hi,

This patchset is to add support for MOTU AudioExpress. Any PCM frames and
MIDI messages are transferred in rx/tx isochronous packets.
Correspondingly, this adds an arrangement for specification flag for
position of existence flag of MIDI messages.

I note that this unit has a quirk of acknowledge code against request
subaction on asynchronous communication. In detail, please refer to 2nd
patch of this set. To easy my development, I applied a patch to
'firewire-ohci' module on my develop ment tree. You can see the content in
the end of this message. It's really a band-aid for the aim and can not be
merged as what it is.

Unfortunately, current implementations of IEC 61883-1/6 packet streaming
engine is not good enough in a point to presentation timestamp, as I
reported[1]. Any plaback stream for the unit still causes periodical noise.

[1] [alsa-devel] Status of ALSA firewire stack at Linux v4.12 development period
http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120061.html

-------- 8< --------
diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c
index 8bf89267dc25..06a0906a9b56 100644
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -1499,6 +1499,10 @@ static int handle_at_packet(struct context *context,
                packet->ack = evt - 0x10;
                break;
 
+       case 0x10:
+               packet->ack = ACK_PENDING;
+               break;
+
        case OHCI1394_evt_no_status:
                if (context->flushing) {
                        packet->ack = RCODE_GENERATION;
-------- 8< --------


Takashi Sakamoto (2):
  ALSA: firewire-motu: add specification flag for position of flag for
    MIDI messages
  ALSA: firewire-motu: add support for MOTU Audio Express

 sound/firewire/motu/motu-pcm.c         |  2 +-
 sound/firewire/motu/motu-protocol-v2.c |  5 -----
 sound/firewire/motu/motu-protocol-v3.c |  5 -----
 sound/firewire/motu/motu-stream.c      | 38 ++++++++++++++++++++++++++++++++--
 sound/firewire/motu/motu.c             | 24 ++++++++++++++++++---
 sound/firewire/motu/motu.h             |  6 +++++-
 6 files changed, 63 insertions(+), 17 deletions(-)

-- 
2.11.0

             reply	other threads:[~2017-08-20 12:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-20 12:25 Takashi Sakamoto [this message]
2017-08-20 12:25 ` [PATCH 1/2] ALSA: firewire-motu: add specification flag for position of flag for MIDI messages Takashi Sakamoto
2017-08-20 12:25 ` [PATCH 2/2] ALSA: firewire-motu: add support for MOTU Audio Express Takashi Sakamoto
2017-08-21 10:41 ` [PATCH 0/2] ALSA: firewire-motu: add support for AudioExpress Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170820122504.24486-1-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=ffado-devel@lists.sf.net \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.