All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, agraf@suse.de, thuth@redhat.com,
	david@redhat.com, pmorel@linux.vnet.ibm.com,
	zyimin@linux.vnet.ibm.com, Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PATCH v4 04/10] s390x: chsc nt2 events are pci-only
Date: Mon, 21 Aug 2017 11:16:08 +0200	[thread overview]
Message-ID: <20170821091614.28251-5-cohuck@redhat.com> (raw)
In-Reply-To: <20170821091614.28251-1-cohuck@redhat.com>

The nt2 event class is pci-only - don't look for events if pci is
not in the active cpu model.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/s390x/s390-pci-bus.c  |  4 ++--
 hw/s390x/s390-pci-bus.h  |  4 ++--
 hw/s390x/s390-pci-stub.c |  4 ++--
 target/s390x/ioinst.c    | 16 ++++++++++++++++
 4 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 61cfd2138f..c57f6ebae0 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -47,7 +47,7 @@ S390pciState *s390_get_phb(void)
     return phb;
 }
 
-int chsc_sei_nt2_get_event(void *res)
+int pci_chsc_sei_nt2_get_event(void *res)
 {
     ChscSeiNt2Res *nt2_res = (ChscSeiNt2Res *)res;
     PciCcdfAvail *accdf;
@@ -87,7 +87,7 @@ int chsc_sei_nt2_get_event(void *res)
     return rc;
 }
 
-int chsc_sei_nt2_have_event(void)
+int pci_chsc_sei_nt2_have_event(void)
 {
     S390pciState *s = s390_get_phb();
 
diff --git a/hw/s390x/s390-pci-bus.h b/hw/s390x/s390-pci-bus.h
index 67af2c12ff..5df6292509 100644
--- a/hw/s390x/s390-pci-bus.h
+++ b/hw/s390x/s390-pci-bus.h
@@ -319,8 +319,8 @@ typedef struct S390pciState {
 } S390pciState;
 
 S390pciState *s390_get_phb(void);
-int chsc_sei_nt2_get_event(void *res);
-int chsc_sei_nt2_have_event(void);
+int pci_chsc_sei_nt2_get_event(void *res);
+int pci_chsc_sei_nt2_have_event(void);
 void s390_pci_sclp_configure(SCCB *sccb);
 void s390_pci_sclp_deconfigure(SCCB *sccb);
 void s390_pci_iommu_enable(S390PCIIOMMU *iommu);
diff --git a/hw/s390x/s390-pci-stub.c b/hw/s390x/s390-pci-stub.c
index 2e7e42a2af..cc7278a865 100644
--- a/hw/s390x/s390-pci-stub.c
+++ b/hw/s390x/s390-pci-stub.c
@@ -7,12 +7,12 @@
 #include "s390-pci-bus.h"
 
 /* target/s390x/ioinst.c */
-int chsc_sei_nt2_get_event(void *res)
+int pci_chsc_sei_nt2_get_event(void *res)
 {
     return 1;
 }
 
-int chsc_sei_nt2_have_event(void)
+int pci_chsc_sei_nt2_have_event(void)
 {
     return 0;
 }
diff --git a/target/s390x/ioinst.c b/target/s390x/ioinst.c
index 51fbea620d..3fa3301f50 100644
--- a/target/s390x/ioinst.c
+++ b/target/s390x/ioinst.c
@@ -599,6 +599,22 @@ static int chsc_sei_nt0_have_event(void)
     return 0;
 }
 
+static int chsc_sei_nt2_get_event(void *res)
+{
+    if (s390_has_feat(S390_FEAT_ZPCI)) {
+        return pci_chsc_sei_nt2_get_event(res);
+    }
+    return 1;
+}
+
+static int chsc_sei_nt2_have_event(void)
+{
+    if (s390_has_feat(S390_FEAT_ZPCI)) {
+        return pci_chsc_sei_nt2_have_event();
+    }
+    return 0;
+}
+
 #define CHSC_SEI_NT0    (1ULL << 63)
 #define CHSC_SEI_NT2    (1ULL << 61)
 static void ioinst_handle_chsc_sei(ChscReq *req, ChscResp *res)
-- 
2.13.5

  parent reply	other threads:[~2017-08-21  9:16 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21  9:16 [Qemu-devel] [PATCH v4 00/10] zpci detangling Cornelia Huck
2017-08-21  9:16 ` [Qemu-devel] [PATCH v4 01/10] 9pfs: fix dependencies Cornelia Huck
2017-08-21  9:16 ` [Qemu-devel] [PATCH v4 02/10] kvm: remove hard dependency on pci Cornelia Huck
2017-08-21 16:02   ` Pierre Morel
2017-08-22  9:04     ` Cornelia Huck
2017-08-23 11:05       ` Pierre Morel
2017-08-21  9:16 ` [Qemu-devel] [PATCH v4 03/10] s390x/pci: add stubs Cornelia Huck
2017-08-21  9:16 ` Cornelia Huck [this message]
2017-08-21 12:24   ` [Qemu-devel] [PATCH v4 04/10] s390x: chsc nt2 events are pci-only Thomas Huth
2017-08-21  9:16 ` [Qemu-devel] [PATCH v4 05/10] s390x/pci: do not advertise pci on non-pci builds Cornelia Huck
2017-08-21 12:29   ` Thomas Huth
2017-08-21  9:16 ` [Qemu-devel] [PATCH v4 06/10] s390x/ccw: create s390 phb conditionally Cornelia Huck
2017-08-21  9:16 ` [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions Cornelia Huck
2017-08-21 11:41   ` Halil Pasic
2017-08-21 13:16     ` Cornelia Huck
2017-08-21 13:32       ` Halil Pasic
2017-08-21 13:36         ` Cornelia Huck
2017-08-21 14:58   ` Pierre Morel
2017-08-21 16:24     ` Halil Pasic
2017-08-22  8:39       ` Cornelia Huck
2017-08-22  9:20         ` Halil Pasic
2017-08-22  9:39           ` Cornelia Huck
2017-08-22 12:57             ` Cornelia Huck
2017-08-22 13:00               ` Halil Pasic
2017-08-22 12:58             ` Halil Pasic
2017-08-22 13:24               ` Cornelia Huck
2017-08-22 13:54                 ` Halil Pasic
2017-08-22 14:15                   ` Cornelia Huck
2017-08-22 14:34                     ` Halil Pasic
2017-08-22 15:10                       ` Cornelia Huck
2017-08-22 14:06                 ` Cornelia Huck
2017-08-22 14:27                   ` Halil Pasic
2017-08-22 14:34                     ` Cornelia Huck
2017-08-21  9:16 ` [Qemu-devel] [PATCH v4 08/10] s390x/pci: fence off instructions for non-pci Cornelia Huck
2017-08-23 14:10   ` Halil Pasic
2017-08-23 15:40     ` Cornelia Huck
2017-08-21  9:16 ` [Qemu-devel] [PATCH v4 09/10] s390x/kvm: msi route fixup " Cornelia Huck
2017-08-21 12:00   ` Halil Pasic
2017-08-21 12:13     ` Cornelia Huck
2017-08-21 15:10       ` Halil Pasic
2017-08-21 15:17         ` Thomas Huth
2017-08-21 15:30           ` Halil Pasic
2017-08-23 10:03             ` Cornelia Huck
2017-08-21  9:16 ` [Qemu-devel] [PATCH v4 10/10] s390x: refine pci dependencies Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821091614.28251-5-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=zyimin@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.