From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH libdrm 3/3] amdgpu: rework and remove amdgpu_get_auth() Date: Mon, 21 Aug 2017 18:37:01 +0200 Message-ID: <20170821163701.qehsyvtgi4s4lfh2@phenom.ffwll.local> References: <20170122184813.12995-1-emil.l.velikov@gmail.com> <20170122184813.12995-3-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id BED5289B83 for ; Mon, 21 Aug 2017 16:37:05 +0000 (UTC) Received: by mail-wr0-x244.google.com with SMTP id f8so13401745wrf.3 for ; Mon, 21 Aug 2017 09:37:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: amd-gfx mailing list , ML dri-devel List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBdWcgMjEsIDIwMTcgYXQgMDE6MzE6MjhQTSArMDEwMCwgRW1pbCBWZWxpa292IHdy b3RlOgo+IEhpIGFsbCwKPiAKPiBDYW4gYW55b25lIHNraW0gdGhyb3VnaCB0aGlzIHBhdGNoPwo+ IAo+IFRoYW5rcwo+IEVtaWwKPiAKPiBPbiAyMiBKYW51YXJ5IDIwMTcgYXQgMTg6NDgsIEVtaWwg VmVsaWtvdiA8ZW1pbC5sLnZlbGlrb3ZAZ21haWwuY29tPiB3cm90ZToKPiA+IEFsbCBvbmUgbmVl ZHMgaXMgdG8gZXN0YWJsaXNoIGlmIGRldi0+ZmQgaXMgdGhlIGZsaW5rIChwcmltYXJ5L2NhcmQp Cj4gPiBub2RlLCByYXRoZXIgdGhhbiB1c2UgRFJNX0lPQ1RMX0dFVF9DTElFTlQgdG8gcXVlcnkg dGhlIGF1dGggc3RhdHVzLgo+ID4KPiA+IFRoZSBsYXR0ZXIgaXMgW3NvbWV3aGF0XSBkZXByZWNh dGVkIGFuZCBpbmNvcnJlY3QuIFdlIG5lZWQgdG8ga25vdyBbYW5kCj4gPiBzdG9yZV0gdGhlIHBy aW1hcnkgbm9kZSBGRCwgc2luY2Ugd2UncmUgZ29pbmcgdG8gdXNlIGl0IFthdCBhIGxhdGVyCj4g PiBzdGFnZV0gZm9yIGJ1ZmZlciBpbXBvcnQvZXhwb3J0IHNoYXJpbmcuCj4gPgo+ID4gQ2M6IGFt ZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBTaWduZWQtb2ZmLWJ5OiBFbWlsIFZlbGlr b3YgPGVtaWwubC52ZWxpa292QGdtYWlsLmNvbT4KPiA+IC0tLQo+ID4gQWdhaW4gbm90IDEwMCUg c3VyZSBidXQgdGhpbmdzIGxvb2sgcXVpdGUgZmlzaHkgYXMtaXMuLi4gVGhlCj4gPiBjb25kaXRp b25hbHMgbWlnaHQgYmUgb2ZmLgo+ID4KPiA+IE5vdGU6IG9yaWdpbmFsIGNvZGUgW2FuZCB0aGlz IG9uZV0gZG8gbm90IGNvbnNpZGVyIGlmIGZsaW5rX2ZkIGlzCj4gPiBhbHJlYWR5IHNldCwgdGh1 cyBhcyB3ZSBkdXAgd2UnbGwgbGVhayBpdC4KPiA+IC0tLQo+ID4gIGFtZGdwdS9hbWRncHVfZGV2 aWNlLmMgfCA0MyArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNDEgZGVsZXRpb25zKC0pCj4gPgo+ ID4gZGlmZiAtLWdpdCBhL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgYi9hbWRncHUvYW1kZ3B1X2Rl dmljZS5jCj4gPiBpbmRleCBmNGVkZTAzMS4uNmYwNGQ5MzYgMTAwNjQ0Cj4gPiAtLS0gYS9hbWRn cHUvYW1kZ3B1X2RldmljZS5jCj4gPiArKysgYi9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4gPiBA QCAtMTAxLDM0ICsxMDEsNiBAQCBzdGF0aWMgaW50IGZkX2NvbXBhcmUodm9pZCAqa2V5MSwgdm9p ZCAqa2V5MikKPiA+ICAgICAgICAgcmV0dXJuIHJlc3VsdDsKPiA+ICB9Cj4gPgo+ID4gLS8qKgo+ ID4gLSogR2V0IHRoZSBhdXRoZW50aWNhdGVkIGZvcm0gZmQsCj4gPiAtKgo+ID4gLSogXHBhcmFt ICAgZmQgICAtIFxjIFtpbl0gIEZpbGUgZGVzY3JpcHRvciBmb3IgQU1EIEdQVSBkZXZpY2UKPiA+ IC0qIFxwYXJhbSAgIGF1dGggLSBcYyBbb3V0XSBQb2ludGVyIHRvIG91dHB1dCB0aGUgZmQgaXMg YXV0aGVudGljYXRlZCBvciBub3QKPiA+IC0qICAgICAgICAgICAgICAgICAgICAgICAgICBBIHJl bmRlciBub2RlIGZkLCBvdXRwdXQgYXV0aCA9IDAKPiA+IC0qICAgICAgICAgICAgICAgICAgICAg ICAgICBBIGxlZ2FjeSBmZCwgZ2V0IHRoZSBhdXRoZW50aWNhdGVkIGZvciBjb21wYXRpYmlsaXR5 IHJvb3QKPiA+IC0qCj4gPiAtKiBccmV0dXJuICAgMCBvbiBzdWNjZXNzXG4KPiA+IC0qICAgICAg ICAgID4wIC0gQU1EIHNwZWNpZmljIGVycm9yIGNvZGVcbgo+ID4gLSogICAgICAgICAgPDAgLSBO ZWdhdGl2ZSBQT1NJWCBFcnJvciBjb2RlCj4gPiAtKi8KPiA+IC1zdGF0aWMgaW50IGFtZGdwdV9n ZXRfYXV0aChpbnQgZmQsIGludCAqYXV0aCkKPiA+IC17Cj4gPiAtICAgICAgIGludCByID0gMDsK PiA+IC0gICAgICAgZHJtX2NsaWVudF90IGNsaWVudCA9IHt9Owo+ID4gLQo+ID4gLSAgICAgICBp ZiAoZHJtR2V0Tm9kZVR5cGVGcm9tRmQoZmQpID09IERSTV9OT0RFX1JFTkRFUikKPiA+IC0gICAg ICAgICAgICAgICAqYXV0aCA9IDA7Cj4gPiAtICAgICAgIGVsc2Ugewo+ID4gLSAgICAgICAgICAg ICAgIGNsaWVudC5pZHggPSAwOwo+ID4gLSAgICAgICAgICAgICAgIHIgPSBkcm1Jb2N0bChmZCwg RFJNX0lPQ1RMX0dFVF9DTElFTlQsICZjbGllbnQpOwo+ID4gLSAgICAgICAgICAgICAgIGlmICgh cikKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICphdXRoID0gY2xpZW50LmF1dGg7Cj4gPiAt ICAgICAgIH0KPiA+IC0gICAgICAgcmV0dXJuIHI7Cj4gPiAtfQoKR0VUQ0xJRU5UIGlzIDk5JSBu ZXJmZWQsIGJ1dCB0aGlzIHBhcnQgaGVyZSBpcyB1YWJpIGFuZCBoZW5jZSB3aWxsIGtlZXAKd29y a2luZyBmb3JldmVyLiBOb3Qgc3VyZSB3aGF0J3MgdGhlIHZhbHVlIGluIHJlbW92aW5nIGl0IChi ZXNpZGUgbWF5YmUKY2xlYW5pbmcgc3R1ZmYgdXApLgotRGFuaWVsCgo+ID4gLQo+ID4gIHN0YXRp YyB2b2lkIGFtZGdwdV9kZXZpY2VfZnJlZV9pbnRlcm5hbChhbWRncHVfZGV2aWNlX2hhbmRsZSBk ZXYpCj4gPiAgewo+ID4gICAgICAgICBhbWRncHVfdmFtZ3JfZGVpbml0KGRldi0+dmFtZ3IpOwo+ ID4gQEAgLTE3NSw4ICsxNDcsNiBAQCBpbnQgYW1kZ3B1X2RldmljZV9pbml0aWFsaXplKGludCBm ZCwKPiA+ICAgICAgICAgc3RydWN0IGFtZGdwdV9kZXZpY2UgKmRldjsKPiA+ICAgICAgICAgZHJt VmVyc2lvblB0ciB2ZXJzaW9uOwo+ID4gICAgICAgICBpbnQgcjsKPiA+IC0gICAgICAgaW50IGZs YWdfYXV0aCA9IDA7Cj4gPiAtICAgICAgIGludCBmbGFnX2F1dGhleGlzdD0wOwo+ID4gICAgICAg ICB1aW50MzJfdCBhY2NlbF93b3JraW5nID0gMDsKPiA+ICAgICAgICAgdWludDY0X3Qgc3RhcnQs IG1heDsKPiA+Cj4gPiBAQCAtMTg1LDE5ICsxNTUsMTAgQEAgaW50IGFtZGdwdV9kZXZpY2VfaW5p dGlhbGl6ZShpbnQgZmQsCj4gPiAgICAgICAgIHB0aHJlYWRfbXV0ZXhfbG9jaygmZmRfbXV0ZXgp Owo+ID4gICAgICAgICBpZiAoIWZkX3RhYikKPiA+ICAgICAgICAgICAgICAgICBmZF90YWIgPSB1 dGlsX2hhc2hfdGFibGVfY3JlYXRlKGZkX2hhc2gsIGZkX2NvbXBhcmUpOwo+ID4gLSAgICAgICBy ID0gYW1kZ3B1X2dldF9hdXRoKGZkLCAmZmxhZ19hdXRoKTsKPiA+IC0gICAgICAgaWYgKHIpIHsK PiA+IC0gICAgICAgICAgICAgICBwdGhyZWFkX211dGV4X3VubG9jaygmZmRfbXV0ZXgpOwo+ID4g LSAgICAgICAgICAgICAgIHJldHVybiByOwo+ID4gLSAgICAgICB9Cj4gPiAgICAgICAgIGRldiA9 IHV0aWxfaGFzaF90YWJsZV9nZXQoZmRfdGFiLCBVSU5UX1RPX1BUUihmZCkpOwo+ID4gICAgICAg ICBpZiAoZGV2KSB7Cj4gPiAtICAgICAgICAgICAgICAgciA9IGFtZGdwdV9nZXRfYXV0aChkZXYt PmZkLCAmZmxhZ19hdXRoZXhpc3QpOwo+ID4gLSAgICAgICAgICAgICAgIGlmIChyKSB7Cj4gPiAt ICAgICAgICAgICAgICAgICAgICAgICBwdGhyZWFkX211dGV4X3VubG9jaygmZmRfbXV0ZXgpOwo+ ID4gLSAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHI7Cj4gPiAtICAgICAgICAgICAgICAg fQo+ID4gLSAgICAgICAgICAgICAgIGlmICgoZmxhZ19hdXRoKSAmJiAoIWZsYWdfYXV0aGV4aXN0 KSkgewo+ID4gKyAgICAgICAgICAgICAgIGlmIChkcm1HZXROb2RlVHlwZUZyb21GZChmZCkgPT0g RFJNX05PREVfUkVOREVSICYmCj4gPiArICAgICAgICAgICAgICAgICAgIGRybUdldE5vZGVUeXBl RnJvbUZkKGRldi0+ZmQpID09IERSTV9OT0RFX1BSSU1BUlkpIHsKPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgIGRldi0+ZmxpbmtfZmQgPSBkdXAoZmQpOwo+ID4gICAgICAgICAgICAgICAgIH0K PiA+ICAgICAgICAgICAgICAgICAqbWFqb3JfdmVyc2lvbiA9IGRldi0+bWFqb3JfdmVyc2lvbjsK PiA+IC0tCj4gPiAyLjExLjAKPiA+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==