All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	linux-kernel@vger.kernel.org, taeung@kosslab.kr,
	Namhyung Kim <namhyung@kernel.org>,
	Milian Wolff <milian.wolff@kdab.com>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view
Date: Mon, 21 Aug 2017 16:19:37 -0300	[thread overview]
Message-ID: <20170821191937.GK10891@kernel.org> (raw)
In-Reply-To: <1136b710-2012-fc5b-cee6-7b4b82e742ba@gmail.com>

Em Mon, Aug 21, 2017 at 02:47:09PM +0900, Taeung Song escreveu:
> 
> 
> On 08/18/2017 11:23 PM, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu:
> > > With a existing 't' hotkey, support the three view based on percent,
> > > total period and number of samples on the annotate TUI browser,
> > > circulating them like below:
> > > 
> > >    Percent -> Period -> Samples -> Percent ...
> > > 
> > > Suggested-by: Namhyung Kim <namhyung@kernel.org>
> > > Cc: Milian Wolff <milian.wolff@kdab.com>
> > > Cc: Jiri Olsa <jolsa@redhat.com>
> > > Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> > > ---
> > 
> > Ok, here I removed this part, that is not documented in the patch nor in
> > the 'h' help screen, if you think it should be considered, please
> > resubmit it with a proper explanation:
> 
> I'm really sorry. The case 'e' code is a residue..
> I missed removing the code.
> Thank you for indicating my mistakes.
> 
> Do I resend this patchkit based on your changes ?
> Or, will you modify it by yourself ?

I fixed it myself, sending to Ingo now.

Thanks!

- Arnaldo

  reply	other threads:[~2017-08-21 19:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18  8:47 [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view Taeung Song
2017-08-18 14:23 ` Arnaldo Carvalho de Melo
2017-08-21  5:47   ` Taeung Song
2017-08-21 19:19     ` Arnaldo Carvalho de Melo [this message]
2017-08-22 10:27 ` [tip:perf/core] perf annotate browser: Circulate percent, total-period and nr-samples view tip-bot for Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821191937.GK10891@kernel.org \
    --to=acme@kernel.org \
    --cc=arnaldo.melo@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=milian.wolff@kdab.com \
    --cc=namhyung@kernel.org \
    --cc=taeung@kosslab.kr \
    --cc=treeze.taeung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.