From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933050AbdHVOE4 (ORCPT ); Tue, 22 Aug 2017 10:04:56 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:36131 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932842AbdHVOEw (ORCPT ); Tue, 22 Aug 2017 10:04:52 -0400 Date: Tue, 22 Aug 2017 17:03:43 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Julia Lawall , Takashi Iwai , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: maestro3: Use common error handling code in two functions Message-ID: <20170822140343.yg7bh3qylthja3tn@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2017 at 03:43:03PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 22 Aug 2017 15:00:27 +0200 > > Add jump targets so that a bit of exception handling can be better reused > at the end of these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > sound/pci/maestro3.c | 55 +++++++++++++++++++++++++--------------------------- > 1 file changed, 26 insertions(+), 29 deletions(-) > > diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c > index cafea6dc5c01..759c3f6ad7aa 100644 > --- a/sound/pci/maestro3.c > +++ b/sound/pci/maestro3.c > @@ -2622,22 +2622,18 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci, > > err = request_firmware(&chip->assp_kernel_image, > "ess/maestro3_assp_kernel.fw", &pci->dev); > - if (err < 0) { > - snd_m3_free(chip); > - return err; > - } > + if (err) > + goto free_chip; You never mention in the changelog you've changed these checks from "if (err < 0)" to "if (err)". Don't slip in unexpected little changes like this. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 22 Aug 2017 14:03:43 +0000 Subject: Re: [PATCH] ALSA: maestro3: Use common error handling code in two functions Message-Id: <20170822140343.yg7bh3qylthja3tn@mwanda> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai , LKML , Julia Lawall On Tue, Aug 22, 2017 at 03:43:03PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 22 Aug 2017 15:00:27 +0200 > > Add jump targets so that a bit of exception handling can be better reused > at the end of these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > sound/pci/maestro3.c | 55 +++++++++++++++++++++++++--------------------------- > 1 file changed, 26 insertions(+), 29 deletions(-) > > diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c > index cafea6dc5c01..759c3f6ad7aa 100644 > --- a/sound/pci/maestro3.c > +++ b/sound/pci/maestro3.c > @@ -2622,22 +2622,18 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci, > > err = request_firmware(&chip->assp_kernel_image, > "ess/maestro3_assp_kernel.fw", &pci->dev); > - if (err < 0) { > - snd_m3_free(chip); > - return err; > - } > + if (err) > + goto free_chip; You never mention in the changelog you've changed these checks from "if (err < 0)" to "if (err)". Don't slip in unexpected little changes like this. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH] ALSA: maestro3: Use common error handling code in two functions Date: Tue, 22 Aug 2017 17:03:43 +0300 Message-ID: <20170822140343.yg7bh3qylthja3tn@mwanda> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by alsa0.perex.cz (Postfix) with ESMTP id 22F0F266812 for ; Tue, 22 Aug 2017 16:04:03 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: SF Markus Elfring Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai , LKML , Julia Lawall List-Id: alsa-devel@alsa-project.org On Tue, Aug 22, 2017 at 03:43:03PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 22 Aug 2017 15:00:27 +0200 > > Add jump targets so that a bit of exception handling can be better reused > at the end of these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > sound/pci/maestro3.c | 55 +++++++++++++++++++++++++--------------------------- > 1 file changed, 26 insertions(+), 29 deletions(-) > > diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c > index cafea6dc5c01..759c3f6ad7aa 100644 > --- a/sound/pci/maestro3.c > +++ b/sound/pci/maestro3.c > @@ -2622,22 +2622,18 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci, > > err = request_firmware(&chip->assp_kernel_image, > "ess/maestro3_assp_kernel.fw", &pci->dev); > - if (err < 0) { > - snd_m3_free(chip); > - return err; > - } > + if (err) > + goto free_chip; You never mention in the changelog you've changed these checks from "if (err < 0)" to "if (err)". Don't slip in unexpected little changes like this. regards, dan carpenter