From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: Add support for TI LMP92001 Date: Tue, 22 Aug 2017 17:23:18 +0100 Message-ID: <20170822162318.sg7ccobciymy5b7h@dell> References: <1503383171-15515-1-git-send-email-s.abhisit@gmail.com> <20170822150330.00007eeb@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:37624 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbdHVQXb (ORCPT ); Tue, 22 Aug 2017 12:23:31 -0400 Received: by mail-wm0-f44.google.com with SMTP id b189so1670330wmd.0 for ; Tue, 22 Aug 2017 09:23:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Abhisit Sangjan Cc: Jonathan Cameron , Peter Meerwald-Stadler , jmondi , Linus Walleij , linux-kernel@vger.kernel.org, knaack.h@gmx.de, lars@metafoo.de, fabrice.gasnier@st.com, robh@kernel.org, Akinobu Mita , marek.vasut+renesas@gmail.com, jacopo+renesas@jmondi.org, mike.looijmans@topic.nl, peda@axentia.se, =?iso-8859-1?Q?Jean-Fran=E7ois?= Dagenais , linux-iio@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org On Tue, 22 Aug 2017, Abhisit Sangjan wrote: > Hi Jonathan - Thank you for your review, I will clean up and submit again. Please do not top post, only reply in-line. Also, when replying to a mail, especially one of this length, please snip past your last comment. Some people complain that it's a waste of data (which I don't really subscribe to TBH), but it certainly is a waste of people's time. I just spent a good amount of time scrolling through your reply looking for a response to Jonathan's review, but none was found. > On Tue, Aug 22, 2017 at 9:03 PM, Jonathan Cameron < > Jonathan.Cameron@huawei.com> wrote: > > > On Tue, 22 Aug 2017 13:26:11 +0700 > > wrote: > > > > > From: Abhisit Sangjan > > > > > > TI LMP92001 Analog System Monitor and Controller > > > > > > 8-bit GPIOs. > > > 12 DACs with 12-bit resolution. > > > The GPIOs and DACs are shared port function with Cy function pin to > > > take control the pin suddenly from external hardware. > > > DAC's referance voltage selectable for Internal/External. > > > > > > 16 + 1 ADCs with 12-bit resolution. > > > Built-in internal Temperature Sensor on channel 17. > > > Windows Comparator Function is supported on channel 1-3 and 9-11 for > > > monitoring with interrupt signal (pending to implement for interrupt). > > > ADC's referance voltage selectable for Internal/External. > > > > > > Signed-off-by: Abhisit Sangjan > > > > As Lee said, break this up. I've done a quick read through but much easier > > to parse in smaller parts! -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog