From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v3 2/5] intel_pstate: convert to use acpi_match_platform_list() Date: Wed, 23 Aug 2017 17:46:16 +0200 Message-ID: <20170823154615.bqbz2cpywlie2zh7@pd.tnic> References: <20170818194644.14538-1-toshi.kani@hpe.com> <20170818194644.14538-3-toshi.kani@hpe.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20170818194644.14538-3-toshi.kani@hpe.com> Sender: linux-kernel-owner@vger.kernel.org To: Toshi Kani Cc: rjw@rjwysocki.net, mchehab@kernel.org, tony.luck@intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada List-Id: linux-acpi@vger.kernel.org On Fri, Aug 18, 2017 at 01:46:41PM -0600, Toshi Kani wrote: > Convert to use acpi_match_platform_list() for the platform check. > There is no change in functionality. > > Signed-off-by: Toshi Kani > Cc: "Rafael J. Wysocki" > Cc: Srinivas Pandruvada > Cc: Len Brown > Cc: Borislav Petkov > --- > drivers/cpufreq/intel_pstate.c | 64 ++++++++++++++++------------------------ > 1 file changed, 25 insertions(+), 39 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index 65ee4fc..ad713cd 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -2466,39 +2466,31 @@ enum { > PPC, > }; > > -struct hw_vendor_info { > - u16 valid; > - char oem_id[ACPI_OEM_ID_SIZE]; > - char oem_table_id[ACPI_OEM_TABLE_ID_SIZE]; > - int oem_pwr_table; > -}; > - > /* Hardware vendor-specific info that has its own power management modes */ > -static struct hw_vendor_info vendor_info[] __initdata = { > - {1, "HP ", "ProLiant", PSS}, > - {1, "ORACLE", "X4-2 ", PPC}, > - {1, "ORACLE", "X4-2L ", PPC}, > - {1, "ORACLE", "X4-2B ", PPC}, > - {1, "ORACLE", "X3-2 ", PPC}, > - {1, "ORACLE", "X3-2L ", PPC}, > - {1, "ORACLE", "X3-2B ", PPC}, > - {1, "ORACLE", "X4470M2 ", PPC}, > - {1, "ORACLE", "X4270M3 ", PPC}, > - {1, "ORACLE", "X4270M2 ", PPC}, > - {1, "ORACLE", "X4170M2 ", PPC}, > - {1, "ORACLE", "X4170 M3", PPC}, > - {1, "ORACLE", "X4275 M3", PPC}, > - {1, "ORACLE", "X6-2 ", PPC}, > - {1, "ORACLE", "Sudbury ", PPC}, > - {0, "", ""}, > +static struct acpi_platform_list plat_info[] __initdata = { > + {"HP ", "ProLiant", 0, ACPI_SIG_FADT, all_versions, 0, PSS}, Btw, why is that ACPI_SIG_FADT's description not "FADT" ? #define ACPI_SIG_FADT "FACP" /* Fixed ACPI Description Table */ More ACPI fun? I don't think I can take any more fun. Oh well, Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,2/5] intel_pstate: convert to use acpi_match_platform_list() From: Borislav Petkov Message-Id: <20170823154615.bqbz2cpywlie2zh7@pd.tnic> Date: Wed, 23 Aug 2017 17:46:16 +0200 To: Toshi Kani Cc: rjw@rjwysocki.net, mchehab@kernel.org, tony.luck@intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada List-ID: T24gRnJpLCBBdWcgMTgsIDIwMTcgYXQgMDE6NDY6NDFQTSAtMDYwMCwgVG9zaGkgS2FuaSB3cm90 ZToKPiBDb252ZXJ0IHRvIHVzZSBhY3BpX21hdGNoX3BsYXRmb3JtX2xpc3QoKSBmb3IgdGhlIHBs YXRmb3JtIGNoZWNrLgo+IFRoZXJlIGlzIG5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5Lgo+IAo+ IFNpZ25lZC1vZmYtYnk6IFRvc2hpIEthbmkgPHRvc2hpLmthbmlAaHBlLmNvbT4KPiBDYzogIlJh ZmFlbCBKLiBXeXNvY2tpIiA8cmp3QHJqd3lzb2NraS5uZXQ+Cj4gQ2M6IFNyaW5pdmFzIFBhbmRy dXZhZGEgPHNyaW5pdmFzLnBhbmRydXZhZGFAbGludXguaW50ZWwuY29tPgo+IENjOiBMZW4gQnJv d24gPGxlbmJAa2VybmVsLm9yZz4KPiBDYzogQm9yaXNsYXYgUGV0a292IDxicEBhbGllbjguZGU+ Cj4gLS0tCj4gIGRyaXZlcnMvY3B1ZnJlcS9pbnRlbF9wc3RhdGUuYyB8ICAgNjQgKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5z ZXJ0aW9ucygrKSwgMzkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY3B1 ZnJlcS9pbnRlbF9wc3RhdGUuYyBiL2RyaXZlcnMvY3B1ZnJlcS9pbnRlbF9wc3RhdGUuYwo+IGlu ZGV4IDY1ZWU0ZmMuLmFkNzEzY2QgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9jcHVmcmVxL2ludGVs X3BzdGF0ZS5jCj4gKysrIGIvZHJpdmVycy9jcHVmcmVxL2ludGVsX3BzdGF0ZS5jCj4gQEAgLTI0 NjYsMzkgKzI0NjYsMzEgQEAgZW51bSB7Cj4gIAlQUEMsCj4gIH07Cj4gIAo+IC1zdHJ1Y3QgaHdf dmVuZG9yX2luZm8gewo+IC0JdTE2ICB2YWxpZDsKPiAtCWNoYXIgb2VtX2lkW0FDUElfT0VNX0lE X1NJWkVdOwo+IC0JY2hhciBvZW1fdGFibGVfaWRbQUNQSV9PRU1fVEFCTEVfSURfU0laRV07Cj4g LQlpbnQgIG9lbV9wd3JfdGFibGU7Cj4gLX07Cj4gLQo+ICAvKiBIYXJkd2FyZSB2ZW5kb3Itc3Bl Y2lmaWMgaW5mbyB0aGF0IGhhcyBpdHMgb3duIHBvd2VyIG1hbmFnZW1lbnQgbW9kZXMgKi8KPiAt c3RhdGljIHN0cnVjdCBod192ZW5kb3JfaW5mbyB2ZW5kb3JfaW5mb1tdIF9faW5pdGRhdGEgPSB7 Cj4gLQl7MSwgIkhQICAgICIsICJQcm9MaWFudCIsIFBTU30sCj4gLQl7MSwgIk9SQUNMRSIsICJY NC0yICAgICIsIFBQQ30sCj4gLQl7MSwgIk9SQUNMRSIsICJYNC0yTCAgICIsIFBQQ30sCj4gLQl7 MSwgIk9SQUNMRSIsICJYNC0yQiAgICIsIFBQQ30sCj4gLQl7MSwgIk9SQUNMRSIsICJYMy0yICAg ICIsIFBQQ30sCj4gLQl7MSwgIk9SQUNMRSIsICJYMy0yTCAgICIsIFBQQ30sCj4gLQl7MSwgIk9S QUNMRSIsICJYMy0yQiAgICIsIFBQQ30sCj4gLQl7MSwgIk9SQUNMRSIsICJYNDQ3ME0yICIsIFBQ Q30sCj4gLQl7MSwgIk9SQUNMRSIsICJYNDI3ME0zICIsIFBQQ30sCj4gLQl7MSwgIk9SQUNMRSIs ICJYNDI3ME0yICIsIFBQQ30sCj4gLQl7MSwgIk9SQUNMRSIsICJYNDE3ME0yICIsIFBQQ30sCj4g LQl7MSwgIk9SQUNMRSIsICJYNDE3MCBNMyIsIFBQQ30sCj4gLQl7MSwgIk9SQUNMRSIsICJYNDI3 NSBNMyIsIFBQQ30sCj4gLQl7MSwgIk9SQUNMRSIsICJYNi0yICAgICIsIFBQQ30sCj4gLQl7MSwg Ik9SQUNMRSIsICJTdWRidXJ5ICIsIFBQQ30sCj4gLQl7MCwgIiIsICIifSwKPiArc3RhdGljIHN0 cnVjdCBhY3BpX3BsYXRmb3JtX2xpc3QgcGxhdF9pbmZvW10gX19pbml0ZGF0YSA9IHsKPiArCXsi SFAgICAgIiwgIlByb0xpYW50IiwgMCwgQUNQSV9TSUdfRkFEVCwgYWxsX3ZlcnNpb25zLCAwLCBQ U1N9LAoKQnR3LCB3aHkgaXMgdGhhdCBBQ1BJX1NJR19GQURUJ3MgZGVzY3JpcHRpb24gbm90ICJG QURUIiA/CgojZGVmaW5lIEFDUElfU0lHX0ZBRFQgICAgICAgICAgICJGQUNQIiAgLyogRml4ZWQg QUNQSSBEZXNjcmlwdGlvbiBUYWJsZSAqLwoKTW9yZSBBQ1BJIGZ1bj8gSSBkb24ndCB0aGluayBJ IGNhbiB0YWtlIGFueSBtb3JlIGZ1bi4KCk9oIHdlbGwsCgpSZXZpZXdlZC1ieTogQm9yaXNsYXYg UGV0a292IDxicEBzdXNlLmRlPgo=